Merge pull request #777 from microsoft/psl-codeql

fix: fixed code quality issues

Author: Roopan-Microsoft

src/backend/v4/api/router.py

@@ -501,6 +501,8 @@ async def plan_approval(
             logging.warning(f"Failed to send WebSocket error: {ws_error}")
         raise HTTPException(status_code=500, detail="Internal server error")
 
+    return None
+
 
 @app_v4.post("/user_clarification")
 async def user_clarification(
@@ -639,6 +641,8 @@ async def user_clarification(
                 status_code=404, detail="No active plan found for clarification"
             )
 
+    return None
+
 
 @app_v4.post("/agent_message")
 async def agent_message_user(

src/backend/v4/common/services/team_service.py

@@ -207,15 +207,6 @@ async def get_team_configuration(
             if team_config is None:
                 return None
 
-            # Verify the configuration belongs to the user
-            # if team_config.user_id != user_id:
-            #     self.logger.warning(
-            #         "Access denied: config %s does not belong to user %s",
-            #         team_id,
-            #         user_id,
-            #     )
-            #     return None
-
             return team_config
 
         except (KeyError, TypeError, ValueError) as e:

src/backend/v4/magentic_agents/common/lifecycle.py

@@ -413,13 +413,6 @@ async def close(self) -> None:
         optionally delete the agent definition here.
         """
         try:
-            # Example optional clean up of an agent id:
-            # if self._agent and isinstance(self._agent, AzureAIAgentClient) and self._agent._should_delete_agent:
-            #     try:
-            #         if self.client and self._agent.agent_id:
-            #             await self.client.agents.delete_agent(self._agent.agent_id)
-            #     except Exception:
-            #         pass
 
             # Close underlying client via base close
             if self._agent and hasattr(self._agent, "close"):

src/frontend/src/components/common/TeamSelector.tsx

@@ -704,18 +704,16 @@ const TeamSelector: React.FC<TeamSelectorProps> = ({
           </DialogContent>
 
 
-          {tempSelectedTeam && (
-            <div className={styles.dialogActions}>
-              <Button
-                appearance="primary"
-                onClick={handleContinue}
-                disabled={!tempSelectedTeam || selectionLoading}
-                className={styles.continueButton}
-              >
-                {selectionLoading ? 'Selecting...' : 'Continue'}
-              </Button>
-            </div>
-          )}
+          <div className={styles.dialogActions}>
+            <Button
+              appearance="primary"
+              onClick={handleContinue}
+              disabled={!tempSelectedTeam || selectionLoading}
+              className={styles.continueButton}
+            >
+              {selectionLoading ? 'Selecting...' : 'Continue'}
+            </Button>
+          </div>
         </DialogSurface>
       </Dialog>
 

src/frontend/src/components/content/PlanPanelLeft.tsx

@@ -26,7 +26,6 @@ import { getUserInfoGlobal } from "@/api/config";
 import TeamSelector from "../common/TeamSelector";
 import { TeamConfig } from "../../models/Team";
 import TeamSelected from "../common/TeamSelected";
-import TeamService from "@/services/TeamService";
 
 const PlanPanelLeft: React.FC<PlanPanelLefProps> = ({
   reloadTasks,
@@ -100,7 +99,7 @@ const PlanPanelLeft: React.FC<PlanPanelLefProps> = ({
   }, [loadPlansData, setUserInfo, reloadTasks]);
   useEffect(() => {
     if (plans) {
-      const { inProgress, completed } =
+      const { completed } =
         TaskService.transformPlansToTasks(plans);
       setCompletedTasks(completed);
     }

src/frontend/src/pages/HomePage.tsx

@@ -1,5 +1,4 @@
 import React, { useEffect, useState, useCallback } from 'react';
-import { useNavigate } from 'react-router-dom';
 import {
     Spinner
 } from '@fluentui/react-components';

tests/e2e-test/tests/test_MACAE_Smoke_test.py

@@ -94,7 +94,6 @@ def test_retail_customer_success_workflow(login_logout, request):
         logger.info("STEP 5: Approving Retail Task Plan")
         logger.info("=" * 80)
         step5_start = time.time()
-        step5_retry_attempted = False
         try:
             biab_page.approve_retail_task_plan()
             step5_end = time.time()