Skip to content

Commit 53a3696

Browse files
Vamshi-MicrosoftVamshi-Microsoft
committed
Minor fixes
1 parent db3d217 commit 53a3696

5 files changed

Lines changed: 74 additions & 32 deletions

File tree

‎.github/workflows/job-deploy-linux.yml‎

Lines changed: 17 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -155,8 +155,9 @@ jobs:
155155
156156
# Validate AZURE_ENV_LOG_ANALYTICS_WORKSPACE_ID (optional, if provided must be valid Resource ID)
157157
if [[ -n "$INPUT_AZURE_ENV_LOG_ANALYTICS_WORKSPACE_ID" ]]; then
158-
if [[ ! "$INPUT_AZURE_ENV_LOG_ANALYTICS_WORKSPACE_ID" =~ ^/subscriptions/[a-fA-F0-9-]+/resourceGroups/[^/]+/providers/Microsoft\.(OperationalInsights|Insights)/workspaces/[^/]+$ ]]; then
159-
echo "❌ ERROR: AZURE_ENV_LOG_ANALYTICS_WORKSPACE_ID is invalid. Must be a valid Azure Resource ID format"
158+
if [[ ! "$INPUT_AZURE_ENV_LOG_ANALYTICS_WORKSPACE_ID" =~ ^/[Ss]ubscriptions/[a-fA-F0-9-]+/[Rr]esource[Gg]roups/[^/]+/[Pp]roviders/[Mm]icrosoft\.([Oo]perational[Ii]nsights|[Ii]nsights)/[Ww]orkspaces/[^/]+$ ]]; then
159+
echo "❌ ERROR: AZURE_ENV_LOG_ANALYTICS_WORKSPACE_ID is invalid. Must be a valid Azure Resource ID format:"
160+
echo " /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OperationalInsights/workspaces/{workspaceName}"
160161
echo " Got: '$INPUT_AZURE_ENV_LOG_ANALYTICS_WORKSPACE_ID'"
161162
VALIDATION_FAILED=true
162163
else
@@ -166,8 +167,9 @@ jobs:
166167
167168
# Validate AZURE_EXISTING_AI_PROJECT_RESOURCE_ID (optional, if provided must be valid Resource ID)
168169
if [[ -n "$INPUT_AZURE_EXISTING_AI_PROJECT_RESOURCE_ID" ]]; then
169-
if [[ ! "$INPUT_AZURE_EXISTING_AI_PROJECT_RESOURCE_ID" =~ ^/subscriptions/[a-fA-F0-9-]+/resourceGroups/[^/]+/providers/Microsoft\.MachineLearningServices/(workspaces|projects)/[^/]+$ ]]; then
170-
echo "❌ ERROR: AZURE_EXISTING_AI_PROJECT_RESOURCE_ID is invalid. Must be a valid Azure Resource ID format"
170+
if [[ ! "$INPUT_AZURE_EXISTING_AI_PROJECT_RESOURCE_ID" =~ ^/subscriptions/[a-fA-F0-9-]+/resourceGroups/[^/]+/providers/(Microsoft\.MachineLearningServices/(workspaces|projects)/[^/]+|Microsoft\.CognitiveServices/accounts/[^/]+/projects/[^/]+)$ ]]; then
171+
echo "❌ ERROR: AZURE_EXISTING_AI_PROJECT_RESOURCE_ID is invalid. Must be a valid Azure Resource ID format:"
172+
echo " /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.CognitiveServices/accounts/{accountName}/projects/{projectName}"
171173
echo " Got: '$INPUT_AZURE_EXISTING_AI_PROJECT_RESOURCE_ID'"
172174
VALIDATION_FAILED=true
173175
else
@@ -350,7 +352,17 @@ jobs:
350352
echo "|-------|--------|" >> $GITHUB_STEP_SUMMARY
351353
echo "| **Job Status** | ${{ job.status == 'success' && '✅ Success' || '❌ Failed' }} |" >> $GITHUB_STEP_SUMMARY
352354
echo "| **Resource Group** | \`$INPUT_RESOURCE_GROUP_NAME\` |" >> $GITHUB_STEP_SUMMARY
353-
echo "| **Configuration Type** | \`${{ inputs.WAF_ENABLED == 'true' && inputs.EXP == 'true' && 'WAF + EXP' || inputs.WAF_ENABLED == 'true' && inputs.EXP != 'true' && 'WAF + Non-EXP' || inputs.WAF_ENABLED != 'true' && inputs.EXP == 'true' && 'Non-WAF + EXP' || 'Non-WAF + Non-EXP' }}\` |" >> $GITHUB_STEP_SUMMARY
355+
CONFIG_TYPE=""
356+
if [[ "$INPUT_WAF_ENABLED" == "true" && "$INPUT_EXP" == "true" ]]; then
357+
CONFIG_TYPE="WAF + EXP"
358+
elif [[ "$INPUT_WAF_ENABLED" == "true" && "$INPUT_EXP" != "true" ]]; then
359+
CONFIG_TYPE="WAF + Non-EXP"
360+
elif [[ "$INPUT_WAF_ENABLED" != "true" && "$INPUT_EXP" == "true" ]]; then
361+
CONFIG_TYPE="Non-WAF + EXP"
362+
else
363+
CONFIG_TYPE="Non-WAF + Non-EXP"
364+
fi
365+
echo "| **Configuration Type** | \`$CONFIG_TYPE\` |" >> $GITHUB_STEP_SUMMARY
354366
echo "| **Azure Region (Infrastructure)** | \`$INPUT_AZURE_LOCATION\` |" >> $GITHUB_STEP_SUMMARY
355367
echo "| **Azure OpenAI Region** | \`$INPUT_AZURE_ENV_OPENAI_LOCATION\` |" >> $GITHUB_STEP_SUMMARY
356368
echo "| **Docker Image Tag** | \`$INPUT_IMAGE_TAG\` |" >> $GITHUB_STEP_SUMMARY

‎.github/workflows/job-deploy-windows.yml‎

Lines changed: 15 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -154,8 +154,9 @@ jobs:
154154
155155
# Validate AZURE_ENV_LOG_ANALYTICS_WORKSPACE_ID (optional, if provided must be valid Resource ID)
156156
if [[ -n "$INPUT_AZURE_ENV_LOG_ANALYTICS_WORKSPACE_ID" ]]; then
157-
if [[ ! "$INPUT_AZURE_ENV_LOG_ANALYTICS_WORKSPACE_ID" =~ ^/subscriptions/[a-fA-F0-9-]+/resourceGroups/[^/]+/providers/Microsoft\.(OperationalInsights|Insights)/workspaces/[^/]+$ ]]; then
158-
echo "❌ ERROR: AZURE_ENV_LOG_ANALYTICS_WORKSPACE_ID is invalid. Must be a valid Azure Resource ID format"
157+
if [[ ! "$INPUT_AZURE_ENV_LOG_ANALYTICS_WORKSPACE_ID" =~ ^/[Ss]ubscriptions/[a-fA-F0-9-]+/[Rr]esource[Gg]roups/[^/]+/[Pp]roviders/[Mm]icrosoft\.([Oo]perational[Ii]nsights|[Ii]nsights)/[Ww]orkspaces/[^/]+$ ]]; then
158+
echo "❌ ERROR: AZURE_ENV_LOG_ANALYTICS_WORKSPACE_ID is invalid. Must be a valid Azure Resource ID format:"
159+
echo " /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OperationalInsights/workspaces/{workspaceName}"
159160
echo " Got: '$INPUT_AZURE_ENV_LOG_ANALYTICS_WORKSPACE_ID'"
160161
VALIDATION_FAILED=true
161162
else
@@ -165,8 +166,9 @@ jobs:
165166
166167
# Validate AZURE_EXISTING_AI_PROJECT_RESOURCE_ID (optional, if provided must be valid Resource ID)
167168
if [[ -n "$INPUT_AZURE_EXISTING_AI_PROJECT_RESOURCE_ID" ]]; then
168-
if [[ ! "$INPUT_AZURE_EXISTING_AI_PROJECT_RESOURCE_ID" =~ ^/subscriptions/[a-fA-F0-9-]+/resourceGroups/[^/]+/providers/Microsoft\.MachineLearningServices/(workspaces|projects)/[^/]+$ ]]; then
169-
echo "❌ ERROR: AZURE_EXISTING_AI_PROJECT_RESOURCE_ID is invalid. Must be a valid Azure Resource ID format"
169+
if [[ ! "$INPUT_AZURE_EXISTING_AI_PROJECT_RESOURCE_ID" =~ ^/subscriptions/[a-fA-F0-9-]+/resourceGroups/[^/]+/providers/(Microsoft\.MachineLearningServices/(workspaces|projects)/[^/]+|Microsoft\.CognitiveServices/accounts/[^/]+/projects/[^/]+)$ ]]; then
170+
echo "❌ ERROR: AZURE_EXISTING_AI_PROJECT_RESOURCE_ID is invalid. Must be a valid Azure Resource ID format:"
171+
echo " /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.CognitiveServices/accounts/{accountName}/projects/{projectName}"
170172
echo " Got: '$INPUT_AZURE_EXISTING_AI_PROJECT_RESOURCE_ID'"
171173
VALIDATION_FAILED=true
172174
else
@@ -346,7 +348,15 @@ jobs:
346348
echo "|-------|--------|" >> $GITHUB_STEP_SUMMARY
347349
echo "| **Job Status** | ${{ job.status == 'success' && '✅ Success' || '❌ Failed' }} |" >> $GITHUB_STEP_SUMMARY
348350
echo "| **Resource Group** | \`$INPUT_RESOURCE_GROUP_NAME\` |" >> $GITHUB_STEP_SUMMARY
349-
echo "| **Configuration Type** | \`${{ inputs.WAF_ENABLED == 'true' && inputs.EXP == 'true' && 'WAF + EXP' || inputs.WAF_ENABLED == 'true' && inputs.EXP != 'true' && 'WAF + Non-EXP' || inputs.WAF_ENABLED != 'true' && inputs.EXP == 'true' && 'Non-WAF + EXP' || 'Non-WAF + Non-EXP' }}\` |" >> $GITHUB_STEP_SUMMARY
351+
config_type="Non-WAF + Non-EXP"
352+
if [[ "$INPUT_WAF_ENABLED" == "true" && "$INPUT_EXP" == "true" ]]; then
353+
config_type="WAF + EXP"
354+
elif [[ "$INPUT_WAF_ENABLED" == "true" && "$INPUT_EXP" != "true" ]]; then
355+
config_type="WAF + Non-EXP"
356+
elif [[ "$INPUT_WAF_ENABLED" != "true" && "$INPUT_EXP" == "true" ]]; then
357+
config_type="Non-WAF + EXP"
358+
fi
359+
echo "| **Configuration Type** | \`$config_type\` |" >> $GITHUB_STEP_SUMMARY
350360
echo "| **Azure Region (Infrastructure)** | \`$INPUT_AZURE_LOCATION\` |" >> $GITHUB_STEP_SUMMARY
351361
echo "| **Azure OpenAI Region** | \`$INPUT_AZURE_ENV_OPENAI_LOCATION\` |" >> $GITHUB_STEP_SUMMARY
352362
echo "| **Docker Image Tag** | \`$INPUT_IMAGE_TAG\` |" >> $GITHUB_STEP_SUMMARY

‎.github/workflows/job-deploy.yml‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -206,7 +206,7 @@ jobs:
206206
207207
# Validate run_e2e_tests (specific allowed values)
208208
if [[ -n "$INPUT_RUN_E2E_TESTS" ]]; then
209-
ALLOWED_VALUES=("None" "GoldenPath-Testing" "Smoke-Testing" "")
209+
ALLOWED_VALUES=("None" "GoldenPath-Testing" "Smoke-Testing")
210210
if [[ ! " ${ALLOWED_VALUES[@]} " =~ " ${INPUT_RUN_E2E_TESTS} " ]]; then
211211
echo "❌ ERROR: run_e2e_tests '$INPUT_RUN_E2E_TESTS' is invalid. Allowed values: ${ALLOWED_VALUES[*]}"
212212
VALIDATION_FAILED=true
@@ -217,7 +217,7 @@ jobs:
217217
218218
# Validate AZURE_ENV_LOG_ANALYTICS_WORKSPACE_ID (Azure Resource ID format)
219219
if [[ -n "$INPUT_AZURE_ENV_LOG_ANALYTICS_WORKSPACE_ID" ]]; then
220-
if [[ ! "$INPUT_AZURE_ENV_LOG_ANALYTICS_WORKSPACE_ID" =~ ^/subscriptions/[a-fA-F0-9-]+/resourceGroups/[^/]+/providers/Microsoft\.(OperationalInsights|Insights)/workspaces/[^/]+$ ]]; then
220+
if [[ ! "$INPUT_AZURE_ENV_LOG_ANALYTICS_WORKSPACE_ID" =~ ^/[Ss]ubscriptions/[a-fA-F0-9-]+/[Rr]esource[Gg]roups/[^/]+/[Pp]roviders/[Mm]icrosoft\.([Oo]perational[Ii]nsights|[Ii]nsights)/[Ww]orkspaces/[^/]+$ ]]; then
221221
echo "❌ ERROR: AZURE_ENV_LOG_ANALYTICS_WORKSPACE_ID is invalid. Must be a valid Azure Resource ID format:"
222222
echo " /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OperationalInsights/workspaces/{workspaceName}"
223223
echo " Got: '$INPUT_AZURE_ENV_LOG_ANALYTICS_WORKSPACE_ID'"
@@ -229,9 +229,9 @@ jobs:
229229
230230
# Validate AZURE_EXISTING_AI_PROJECT_RESOURCE_ID (Azure Resource ID format)
231231
if [[ -n "$INPUT_AZURE_EXISTING_AI_PROJECT_RESOURCE_ID" ]]; then
232-
if [[ ! "$INPUT_AZURE_EXISTING_AI_PROJECT_RESOURCE_ID" =~ ^/subscriptions/[a-fA-F0-9-]+/resourceGroups/[^/]+/providers/Microsoft\.MachineLearningServices/(workspaces|projects)/[^/]+$ ]]; then
232+
if [[ ! "$INPUT_AZURE_EXISTING_AI_PROJECT_RESOURCE_ID" =~ ^/subscriptions/[a-fA-F0-9-]+/resourceGroups/[^/]+/providers/(Microsoft\.MachineLearningServices/(workspaces|projects)/[^/]+|Microsoft\.CognitiveServices/accounts/[^/]+/projects/[^/]+)$ ]]; then
233233
echo "❌ ERROR: AZURE_EXISTING_AI_PROJECT_RESOURCE_ID is invalid. Must be a valid Azure Resource ID format:"
234-
echo " /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}"
234+
echo " /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.CognitiveServices/accounts/{accountName}/projects/{projectName}"
235235
echo " Got: '$INPUT_AZURE_EXISTING_AI_PROJECT_RESOURCE_ID'"
236236
VALIDATION_FAILED=true
237237
else

‎.github/workflows/job-send-notification.yml‎

Lines changed: 31 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -111,9 +111,11 @@ jobs:
111111
- name: Send Deployment Failure Notification
112112
if: inputs.deploy_result == 'failure' && inputs.QUOTA_FAILED != 'true'
113113
shell: bash
114+
env:
115+
INPUT_RESOURCE_GROUP_NAME: ${{ inputs.RESOURCE_GROUP_NAME }}
114116
run: |
115117
RUN_URL="https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}"
116-
RESOURCE_GROUP="${{ inputs.RESOURCE_GROUP_NAME }}"
118+
RESOURCE_GROUP="$INPUT_RESOURCE_GROUP_NAME"
117119
118120
EMAIL_BODY=$(cat <<EOF
119121
{
@@ -130,14 +132,20 @@ jobs:
130132
- name: Send Success Notification
131133
if: inputs.deploy_result == 'success' && (inputs.e2e_test_result == 'skipped' || inputs.TEST_SUCCESS == 'true')
132134
shell: bash
135+
env:
136+
INPUT_E2E_TEST_RESULT: ${{ inputs.e2e_test_result }}
137+
INPUT_CONTAINER_WEB_APPURL: ${{ inputs.CONTAINER_WEB_APPURL }}
138+
INPUT_EXISTING_WEBAPP_URL: ${{ inputs.existing_webapp_url }}
139+
INPUT_RESOURCE_GROUP_NAME: ${{ inputs.RESOURCE_GROUP_NAME }}
140+
INPUT_TEST_REPORT_URL: ${{ inputs.TEST_REPORT_URL }}
133141
run: |
134142
RUN_URL="https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}"
135-
WEBAPP_URL="${{ inputs.CONTAINER_WEB_APPURL || inputs.existing_webapp_url }}"
136-
RESOURCE_GROUP="${{ inputs.RESOURCE_GROUP_NAME }}"
137-
TEST_REPORT_URL="${{ inputs.TEST_REPORT_URL }}"
143+
WEBAPP_URL="${INPUT_CONTAINER_WEB_APPURL:-$INPUT_EXISTING_WEBAPP_URL}"
144+
RESOURCE_GROUP="$INPUT_RESOURCE_GROUP_NAME"
145+
TEST_REPORT_URL="$INPUT_TEST_REPORT_URL"
138146
TEST_SUITE_NAME="${{ steps.test_suite.outputs.TEST_SUITE_NAME }}"
139147
140-
if [ "${{ inputs.e2e_test_result }}" = "skipped" ]; then
148+
if [ "$INPUT_E2E_TEST_RESULT" = "skipped" ]; then
141149
EMAIL_BODY=$(cat <<EOF
142150
{
143151
"body": "<p>Dear Team,</p><p>We would like to inform you that the ${{ env.accelerator_name }} deployment has completed successfully.</p><p><strong>Deployment Details:</strong><br>• Resource Group: ${RESOURCE_GROUP}<br>• Web App URL: <a href='${WEBAPP_URL}'>${WEBAPP_URL}</a><br>• E2E Tests: Skipped (as configured)</p><p><strong>Configuration:</strong><br>• WAF Enabled: ${{ env.WAF_ENABLED }}<br>• EXP Enabled: ${{ env.EXP }}</p><p><strong>Run URL:</strong> <a href='${RUN_URL}'>${RUN_URL}</a></p><p>Best regards,<br>Your Automation Team</p>",
@@ -162,11 +170,16 @@ jobs:
162170
- name: Send Test Failure Notification
163171
if: inputs.deploy_result == 'success' && inputs.e2e_test_result != 'skipped' && inputs.TEST_SUCCESS != 'true'
164172
shell: bash
173+
env:
174+
INPUT_TEST_REPORT_URL: ${{ inputs.TEST_REPORT_URL }}
175+
INPUT_CONTAINER_WEB_APPURL: ${{ inputs.CONTAINER_WEB_APPURL }}
176+
INPUT_EXISTING_WEBAPP_URL: ${{ inputs.existing_webapp_url }}
177+
INPUT_RESOURCE_GROUP_NAME: ${{ inputs.RESOURCE_GROUP_NAME }}
165178
run: |
166179
RUN_URL="https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}"
167-
TEST_REPORT_URL="${{ inputs.TEST_REPORT_URL }}"
168-
WEBAPP_URL="${{ inputs.CONTAINER_WEB_APPURL || inputs.existing_webapp_url }}"
169-
RESOURCE_GROUP="${{ inputs.RESOURCE_GROUP_NAME }}"
180+
TEST_REPORT_URL="$INPUT_TEST_REPORT_URL"
181+
WEBAPP_URL="${INPUT_CONTAINER_WEB_APPURL:-$INPUT_EXISTING_WEBAPP_URL}"
182+
RESOURCE_GROUP="$INPUT_RESOURCE_GROUP_NAME"
170183
TEST_SUITE_NAME="${{ steps.test_suite.outputs.TEST_SUITE_NAME }}"
171184
172185
EMAIL_BODY=$(cat <<EOF
@@ -184,10 +197,13 @@ jobs:
184197
- name: Send Existing URL Success Notification
185198
if: inputs.deploy_result == 'skipped' && inputs.existing_webapp_url != '' && inputs.e2e_test_result == 'success' && (inputs.TEST_SUCCESS == 'true' || inputs.TEST_SUCCESS == '')
186199
shell: bash
200+
env:
201+
INPUT_EXISTING_WEBAPP_URL: ${{ inputs.existing_webapp_url }}
202+
INPUT_TEST_REPORT_URL: ${{ inputs.TEST_REPORT_URL }}
187203
run: |
188204
RUN_URL="https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}"
189-
EXISTING_URL="${{ inputs.existing_webapp_url }}"
190-
TEST_REPORT_URL="${{ inputs.TEST_REPORT_URL }}"
205+
EXISTING_URL="$INPUT_EXISTING_WEBAPP_URL"
206+
TEST_REPORT_URL="$INPUT_TEST_REPORT_URL"
191207
TEST_SUITE_NAME="${{ steps.test_suite.outputs.TEST_SUITE_NAME }}"
192208
193209
EMAIL_BODY=$(cat <<EOF
@@ -205,10 +221,13 @@ jobs:
205221
- name: Send Existing URL Test Failure Notification
206222
if: inputs.deploy_result == 'skipped' && inputs.existing_webapp_url != '' && inputs.e2e_test_result == 'failure'
207223
shell: bash
224+
env:
225+
INPUT_EXISTING_WEBAPP_URL: ${{ inputs.existing_webapp_url }}
226+
INPUT_TEST_REPORT_URL: ${{ inputs.TEST_REPORT_URL }}
208227
run: |
209228
RUN_URL="https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}"
210-
EXISTING_URL="${{ inputs.existing_webapp_url }}"
211-
TEST_REPORT_URL="${{ inputs.TEST_REPORT_URL }}"
229+
EXISTING_URL="$INPUT_EXISTING_WEBAPP_URL"
230+
TEST_REPORT_URL="$INPUT_TEST_REPORT_URL"
212231
TEST_SUITE_NAME="${{ steps.test_suite.outputs.TEST_SUITE_NAME }}"
213232
214233
EMAIL_BODY=$(cat <<EOF

‎.github/workflows/test-automation-v2.yml‎

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ env:
3131
MACAE_WEB_URL: ${{ inputs.MACAE_WEB_URL }}
3232
MACAE_URL_API: ${{ inputs.MACAE_URL_API }}
3333
MACAE_RG: ${{ inputs.MACAE_RG }}
34+
TEST_SUITE: ${{ inputs.TEST_SUITE }}
3435
accelerator_name: "MACAE v4"
3536

3637
jobs:
@@ -91,7 +92,7 @@ jobs:
9192
- name: Run tests(1)
9293
id: test1
9394
run: |
94-
if [ "${{ inputs.TEST_SUITE }}" == "GoldenPath-Testing" ]; then
95+
if [ "${{ env.TEST_SUITE }}" == "GoldenPath-Testing" ]; then
9596
xvfb-run pytest -m gp --html=report/report.html --self-contained-html
9697
else
9798
xvfb-run pytest --html=report/report.html --self-contained-html
@@ -108,7 +109,7 @@ jobs:
108109
id: test2
109110
if: ${{ steps.test1.outcome == 'failure' }}
110111
run: |
111-
if [ "${{ inputs.TEST_SUITE }}" == "GoldenPath-Testing" ]; then
112+
if [ "${{ env.TEST_SUITE }}" == "GoldenPath-Testing" ]; then
112113
xvfb-run pytest -m gp --html=report/report.html --self-contained-html
113114
else
114115
xvfb-run pytest --html=report/report.html --self-contained-html
@@ -125,7 +126,7 @@ jobs:
125126
id: test3
126127
if: ${{ steps.test2.outcome == 'failure' }}
127128
run: |
128-
if [ "${{ inputs.TEST_SUITE }}" == "GoldenPath-Testing" ]; then
129+
if [ "${{ env.TEST_SUITE }}" == "GoldenPath-Testing" ]; then
129130
xvfb-run pytest -m gp --html=report/report.html --self-contained-html
130131
else
131132
xvfb-run pytest --html=report/report.html --self-contained-html
@@ -144,7 +145,7 @@ jobs:
144145
if: always()
145146
run: |
146147
# Determine test suite type for title
147-
if [ "${{ inputs.TEST_SUITE }}" == "GoldenPath-Testing" ]; then
148+
if [ "${{ env.TEST_SUITE }}" == "GoldenPath-Testing" ]; then
148149
echo "## 🧪 E2E Test Job Summary : Golden Path Testing" >> $GITHUB_STEP_SUMMARY
149150
else
150151
echo "## 🧪 E2E Test Job Summary : Smoke Testing" >> $GITHUB_STEP_SUMMARY
@@ -161,8 +162,8 @@ jobs:
161162
echo "| **Job Status** | ❌ Failed |" >> $GITHUB_STEP_SUMMARY
162163
fi
163164
164-
echo "| **Target URL** | [${{ inputs.MACAE_WEB_URL }}](${{ inputs.MACAE_WEB_URL }}) |" >> $GITHUB_STEP_SUMMARY
165-
echo "| **Test Suite** | \`${{ inputs.TEST_SUITE }}\` |" >> $GITHUB_STEP_SUMMARY
165+
echo "| **Target URL** | [${{ env.MACAE_WEB_URL }}](${{ env.MACAE_WEB_URL }}) |" >> $GITHUB_STEP_SUMMARY
166+
echo "| **Test Suite** | \`${{ env.TEST_SUITE }}\` |" >> $GITHUB_STEP_SUMMARY
166167
echo "| **Test Report** | [Download Artifact](${{ steps.upload_report.outputs.artifact-url }}) |" >> $GITHUB_STEP_SUMMARY
167168
echo "" >> $GITHUB_STEP_SUMMARY
168169

0 commit comments

Comments
 (0)