Skip to content

Commit bfa0e96

Browse files
codeQL issue fix
1 parent 176046f commit bfa0e96

3 files changed

Lines changed: 4 additions & 5 deletions

File tree

src/backend/common/config/app_config.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -112,9 +112,7 @@ def get_azure_credential(self, client_id=None):
112112
Credential object: Either DefaultAzureCredential or ManagedIdentityCredential.
113113
"""
114114
if self.APP_ENV == "dev":
115-
return (
116-
DefaultAzureCredential()
117-
) # CodeQL [SM05139] Okay use of DefaultAzureCredential as it is only used in development
115+
return DefaultAzureCredential() # CodeQL [SM05139]: DefaultAzureCredential is safe here
118116
else:
119117
return ManagedIdentityCredential(client_id=client_id)
120118

src/backend/v3/magentic_agents/reasoning_search.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ async def initialize(self, kernel: Kernel) -> bool:
2929
return False
3030

3131
try:
32-
credential = SyncDefaultAzureCredential()
32+
# credential = SyncDefaultAzureCredential()
3333

3434
self.search_client = SearchClient(endpoint=self.search_config.endpoint,
3535
credential=AzureKeyCredential(self.search_config.api_key),

src/backend/v3/orchestration/orchestration_manager.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,8 @@ async def init_orchestration(cls, agents: List, user_id: str = None)-> MagenticO
5252
temperature=0.1
5353
)
5454

55-
credential = SyncDefaultAzureCredential()
55+
credential = config.get_azure_credential(client_id=config.AZURE_CLIENT_ID)
56+
# credential = SyncDefaultAzureCredential()
5657

5758
def get_token():
5859
token = credential.get_token("https://cognitiveservices.azure.com/.default")

0 commit comments

Comments
 (0)