implemented codeQL and copilot sugestions

Author: Ayaz-Microsoft

src/tests/backend/common/database/test_database_base.py

@@ -6,7 +6,6 @@
 
 import os
 import sys
-from pathlib import Path
 from types import ModuleType
 from unittest.mock import Mock, MagicMock
 

src/tests/backend/conftest.py

@@ -36,7 +36,7 @@
 os.environ.setdefault("AZURE_OPENAI_RAI_DEPLOYMENT_NAME", "test-rai-deployment")
 
 # Check if v4 has been mocked by another test file (prevents import errors)
-_v4_is_mocked = 'v4' in sys.modules and isinstance(sys.modules['v4'], Mock)
+_v4_is_mocked = 'v4' in sys.modules and isinstance(sys.modules['v4'], (Mock, MagicMock))
 if _v4_is_mocked:
     # Skip this module - v4 has been mocked by another test file
     pytest.skip(

src/tests/backend/test_app.py

@@ -503,28 +503,6 @@ async def test_close_connection_with_exception(self):
             # Connection should still be removed
             self.assertNotIn(process_id, config.connections)
 
-    async def test_send_status_update_async_success(self):
-        """Test sending status update successfully."""
-        config = ConnectionConfig()
-        user_id = "user-123"
-        process_id = "process-456"
-        message = "Test message"
-        connection = AsyncMock()
-        
-        config.add_connection(process_id, connection, user_id)
-        
-        await config.send_status_update_async(message, user_id)
-        
-        connection.send_text.assert_called_once()
-        sent_data = json.loads(connection.send_text.call_args[0][0])
-        # Verify payload structure - type field exists (may be mocked or real enum value)
-        self.assertIn('type', sent_data)
-        # If not mocked, verify actual value
-        type_val = str(sent_data['type'])
-        if 'MagicMock' not in type_val:
-            self.assertEqual(sent_data['type'], 'system_message')
-        self.assertEqual(sent_data['data'], message)
-
     async def test_send_status_update_async_no_user_id(self):
         """Test sending status update with no user ID."""
 
@@ -811,7 +789,7 @@ async def approve_task():
         result = await config.wait_for_approval(plan_id, timeout=1.0)
 
         self.assertTrue(result)
-        await approve_task_handle
+        _ = await approve_task_handle
 
     async def test_wait_for_approval_rejected(self):
         """Test waiting for approval when plan is rejected."""
@@ -828,7 +806,7 @@ async def reject_task():
         result = await config.wait_for_approval(plan_id, timeout=1.0)
 
         self.assertFalse(result)
-        await reject_task_handle
+        _ = await reject_task_handle
 
     async def test_wait_for_clarification_key_error(self):
         """Test waiting for clarification with non-existent request_id raises KeyError."""
@@ -854,7 +832,7 @@ async def answer_task():
         result = await config.wait_for_clarification(request_id, timeout=1.0)
 
         self.assertEqual(result, "User answer")
-        await answer_task_handle
+        _ = await answer_task_handle
 
     async def test_wait_for_approval_creates_new_event(self):
         """Test that waiting for approval creates event if not exists."""
@@ -872,7 +850,7 @@ async def approve_task():
         result = await config.wait_for_approval(plan_id, timeout=1.0)
 
         self.assertTrue(result)
-        await approve_task_handle
+        _ = await approve_task_handle
 
 
 if __name__ == '__main__':

src/tests/backend/v4/config/test_settings.py

@@ -11,13 +11,13 @@
 
 import unittest
 import sys
-from unittest.mock import Mock
+from unittest.mock import Mock, MagicMock
 
 import pytest
 
 # Check if v4 has been mocked by another test file (prevents import errors)
-_v4_is_mocked = 'v4' in sys.modules and isinstance(sys.modules['v4'], Mock)
-_v4_models_is_mocked = 'v4.models' in sys.modules and isinstance(sys.modules['v4.models'], Mock)
+_v4_is_mocked = 'v4' in sys.modules and isinstance(sys.modules['v4'], (Mock, MagicMock))
+_v4_models_is_mocked = 'v4.models' in sys.modules and isinstance(sys.modules['v4.models'], (Mock, MagicMock))
 if _v4_is_mocked or _v4_models_is_mocked:
     pytest.skip(
         "Skipping test_plan_to_mplan_converter.py: v4 module has been mocked by another test file. "

src/tests/backend/v4/orchestration/helper/test_plan_to_mplan_converter.py

@@ -927,9 +927,8 @@ def test_extract_response_text_agent_executor_response_with_agent_response(self)
         agent_resp = Mock()
         agent_resp.text = "Agent executor response"
 
-        executor_resp = Mock()
+        executor_resp = Mock(spec=['agent_response'])
         executor_resp.agent_response = agent_resp
-        del executor_resp.text  # Remove text attr so it falls through
 
         result = self.manager._extract_response_text(executor_resp)
         self.assertEqual(result, "Agent executor response")
@@ -941,10 +940,9 @@ def test_extract_response_text_agent_executor_response_fallback_to_conversation(
 
         last_msg = MockChatMessage("Last conversation message")
 
-        executor_resp = Mock()
+        executor_resp = Mock(spec=['agent_response', 'full_conversation'])
         executor_resp.agent_response = agent_resp
         executor_resp.full_conversation = [MockChatMessage("First"), last_msg]
-        del executor_resp.text  # Remove text attr
 
         result = self.manager._extract_response_text(executor_resp)
         self.assertEqual(result, "Last conversation message")
@@ -954,10 +952,9 @@ def test_extract_response_text_agent_executor_response_empty_conversation(self):
         agent_resp = Mock()
         agent_resp.text = None
 
-        executor_resp = Mock()
+        executor_resp = Mock(spec=['agent_response', 'full_conversation'])
         executor_resp.agent_response = agent_resp
         executor_resp.full_conversation = []
-        del executor_resp.text  # Remove text attr
 
         result = self.manager._extract_response_text(executor_resp)
         self.assertEqual(result, "")