From 60f1215dd43cfdff31f94458abf1a4f4569f3d28 Mon Sep 17 00:00:00 2001 From: "Ashwal Vishwanath (Persistent Systems Inc)" Date: Tue, 14 Apr 2026 17:35:47 +0530 Subject: [PATCH 1/2] code quality --- .../common/database/test_database_base.py | 4 ++-- src/tests/backend/v4/config/test_settings.py | 16 ++++------------ 2 files changed, 6 insertions(+), 14 deletions(-) diff --git a/src/tests/backend/common/database/test_database_base.py b/src/tests/backend/common/database/test_database_base.py index 128d26cf7..b19740132 100644 --- a/src/tests/backend/common/database/test_database_base.py +++ b/src/tests/backend/common/database/test_database_base.py @@ -500,8 +500,8 @@ async def get_team_agent(self, team_id, agent_name): return None # Raise an exception to test cleanup raise ValueError("Test exception") - # Even with exception, close should have been called - assert database.closed is True + # Even with exception, close should have been called + assert database.closed is True class TestDatabaseBaseInheritance: diff --git a/src/tests/backend/v4/config/test_settings.py b/src/tests/backend/v4/config/test_settings.py index 44c8191e7..d254cff10 100644 --- a/src/tests/backend/v4/config/test_settings.py +++ b/src/tests/backend/v4/config/test_settings.py @@ -336,17 +336,13 @@ async def test_wait_for_approval_cancelled(self): config.set_approval_pending(plan_id) - async def cancel_task(): - await asyncio.sleep(0.05) - task.cancel() - task = asyncio.create_task(config.wait_for_approval(plan_id, timeout=1.0)) - cancel_task_handle = asyncio.create_task(cancel_task()) + await asyncio.sleep(0.05) + task.cancel() with self.assertRaises(asyncio.CancelledError): _ = await task - await cancel_task_handle self.assertTrue(task.cancelled()) async def test_wait_for_clarification_cancelled(self): @@ -357,17 +353,13 @@ async def test_wait_for_clarification_cancelled(self): config.set_clarification_pending(request_id) - async def cancel_task(): - await asyncio.sleep(0.05) - task.cancel() - task = asyncio.create_task(config.wait_for_clarification(request_id, timeout=1.0)) - cancel_task_handle = asyncio.create_task(cancel_task()) + await asyncio.sleep(0.05) + task.cancel() with self.assertRaises(asyncio.CancelledError): _ = await task - await cancel_task_handle self.assertTrue(task.cancelled()) def test_cleanup_approval(self): From d3cda6c4671072e99218322008a251eba698bb2b Mon Sep 17 00:00:00 2001 From: "Ashwal Vishwanath (Persistent Systems Inc)" Date: Thu, 16 Apr 2026 14:52:50 +0530 Subject: [PATCH 2/2] chore: code quality updates --- src/tests/backend/common/database/test_database_base.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/tests/backend/common/database/test_database_base.py b/src/tests/backend/common/database/test_database_base.py index b19740132..3507f5d1c 100644 --- a/src/tests/backend/common/database/test_database_base.py +++ b/src/tests/backend/common/database/test_database_base.py @@ -500,8 +500,8 @@ async def get_team_agent(self, team_id, agent_name): return None # Raise an exception to test cleanup raise ValueError("Test exception") - # Even with exception, close should have been called - assert database.closed is True + # Even with exception, close should have been called + assert database.closed is True class TestDatabaseBaseInheritance: