fix: remove unused imports and improve error handling across multiple scripts

Author: Kingshuk-Microsoft

archive-doc-gen/src/backend/settings.py

@@ -266,6 +266,11 @@ class _AzureSearchSettings(BaseSettings, DatasourcePayloadConstructor):
         extra="ignore",
         env_ignore_empty=True,
     )
+
+    def __init__(self, *args, settings: "_AppSettings", **data):
+        # Ensure DatasourcePayloadConstructor.__init__ runs so that _settings is initialized
+        super().__init__(*args, settings=settings, **data)
+
     _type: Literal["azure_search"] = PrivateAttr(default="azure_search")
     top_k: int = Field(default=5, serialization_alias="top_n_documents")
     strictness: int = 3

archive-doc-gen/src/frontend/src/components/ChatHistory/ChatHistoryListItem.tsx

@@ -7,7 +7,6 @@ import {
   DialogType,
   IconButton,
   ITextField,
-  ITooltipHostStyles,
   List,
   PrimaryButton,
   Separator,

archive-doc-gen/src/frontend/src/components/ChatHistory/chatHistoryListItem.test.tsx

@@ -553,11 +553,10 @@ describe('ChatHistoryListItemCell', () => {
   }, 10000)
 
   test('shows error when trying to rename to an existing title', async () => {
-    const existingTitle = 'Existing Chat Title'
-      ; (historyRename as jest.Mock).mockResolvedValueOnce({
-        ok: false,
-        json: async () => ({ message: 'Title already exists' })
-      })
+    (historyRename as jest.Mock).mockResolvedValueOnce({
+      ok: false,
+      json: async () => ({ message: 'Title already exists' })
+    })
 
     renderWithContext(<ChatHistoryListItemCell item={conversation} onSelect={mockOnSelect} />, mockAppState)
 

archive-doc-gen/src/frontend/src/pages/chat/Chat.tsx

@@ -6,9 +6,6 @@ import {
   Dialog,
   DialogType,
   Stack,
-  IStackTokens,
-  mergeStyleSets,
-  IModalStyles,
   Spinner,
   SpinnerSize
 } from '@fluentui/react'

archive-doc-gen/tests/e2e-test/pages/draftPage.py

@@ -1,5 +1,4 @@
 import time
-import os
 from base.base import BasePage
 from pytest_check import check
 from playwright.sync_api import expect

archive-doc-gen/tests/e2e-test/tests/test_st_docgen_tc.py

@@ -6,7 +6,7 @@
 import pytest
 from pytest_check import check
 from playwright.sync_api import expect
-from config.constants import (URL, add_section, browse_question1, browse_question2, browse_question3,
+from config.constants import (add_section, browse_question1, browse_question2, browse_question3,
                               browse_question4, browse_question5, generate_question1, invalid_response, 
                               invalid_response1, remove_section)
 from pages.browsePage import BrowsePage
@@ -538,7 +538,6 @@ def test_show_hide_chat_history(login_logout, request):
 
     page = login_logout
     home_page = HomePage(page)
-    browse_page = BrowsePage(page)
     generate_page = GeneratePage(page)
 
     log_capture = io.StringIO()
@@ -2503,14 +2502,13 @@ def test_bug_7571_removed_sections_not_returning(request, login_logout):
         logger.info("Step 4: Enter a prompt to remove sections one by one 'Remove (section name)'")
         start = time.time()
 
-        # Select 3 sections to remove from the initial list
-        sections_to_remove = []
-        if initial_count >= 3:
-            # Remove sections at positions 1, 2, and 3 (avoid removing first section for stability)
-            indices_to_remove = [1, 2, 3] if initial_count > 3 else list(range(1, initial_count))
-            for idx in indices_to_remove:
-                if idx < len(initial_sections):
-                    sections_to_remove.append(initial_sections[idx])
+        # Select up to 3 sections to remove from the initial list (avoid removing first section for stability)
+        indices_to_remove = [1, 2, 3] if initial_count > 3 else list(range(1, initial_count))
+        sections_to_remove = [
+            initial_sections[idx]
+            for idx in indices_to_remove
+            if idx < len(initial_sections)
+        ]
 
         logger.info("Sections selected for removal: %s", sections_to_remove)
 
@@ -2739,6 +2737,9 @@ def test_bug_9825_navigate_between_sections(request, login_logout):
 
         page.wait_for_timeout(1000)
 
+        duration = time.time() - start
+        logger.info("Execution Time for Step 6: %.2fs", duration)
+        
         logger.info("\n" + "="*80)
         logger.info("✅ TC 10157 Test Summary - Navigate between sections")
         logger.info("="*80)
@@ -3398,7 +3399,7 @@ def test_bug_10177_edit_delete_icons_disabled_during_response(login_logout, requ
                 try:
                     threads.first.wait_for(state="visible", timeout=10000)
                     logger.info("✅ Chat history created and displayed with %d thread(s)", threads.count())
-                except:
+                except Exception:
                     logger.error("❌ Chat history threads not visible after creation")
                     # Try alternative locator
                     threads_alt = page.locator('div[data-list-index]')
@@ -3448,7 +3449,7 @@ def test_bug_10177_edit_delete_icons_disabled_during_response(login_logout, requ
         try:
             delete_icon.wait_for(state="visible", timeout=2000)
             is_delete_visible = True
-        except:
+        except Exception:
             is_delete_visible = False
 
         is_delete_enabled = delete_icon.is_enabled() if is_delete_visible else False
@@ -3460,7 +3461,7 @@ def test_bug_10177_edit_delete_icons_disabled_during_response(login_logout, requ
         try:
             edit_icon.wait_for(state="visible", timeout=2000)
             is_edit_visible = True
-        except:
+        except Exception:
             is_edit_visible = False
 
         is_edit_enabled = edit_icon.is_enabled() if is_edit_visible else False
@@ -3914,7 +3915,9 @@ def test_bug_16106_tooltip_on_chat_history_hover(login_logout, request):
         with check:
             assert thread_count > 0, "No chat history threads found to hover over"
 
-        if thread_count > 0:
+        if thread_count <= 0:
+            logger.warning("Skipping hover action: no chat history threads available.")
+        else:
             # Hover over the first chat thread to trigger tooltip
             first_thread = history_threads.nth(0)
             first_thread.hover()
@@ -3989,8 +3992,6 @@ def test_bug_16106_tooltip_on_chat_history_hover(login_logout, request):
         if tooltip_found:
             logger.info("✅ Tooltip displayed successfully on chat history hover")
             logger.info("Tooltip text length: %d characters", len(tooltip_text))
-        else:
-            logger.error("❌ BUG FOUND: No tooltip displayed when hovering over chat history")
 
         duration = time.time() - start
         logger.info("Execution Time for 'Verify tooltip': %.2fs", duration)
@@ -4007,7 +4008,7 @@ def test_bug_16106_tooltip_on_chat_history_hover(login_logout, request):
                 page.keyboard.press("Escape")
                 page.wait_for_timeout(1000)
                 logger.info("Closed chat history using Escape key")
-            except:
+            except Exception:
                 logger.warning("Chat history panel may still be open")
 
         logger.info("\n%s", "="*80)
@@ -4102,10 +4103,10 @@ def test_bug_26031_validate_empty_spaces_chat_input(login_logout, request):
                 assert current_responses_empty == initial_responses, \
                     f"BUG: System accepted empty query. Response count changed from {initial_responses} to {current_responses_empty}"
 
-            if current_responses_empty == initial_responses:
-                logger.info("✅ System did not accept empty query - no response generated")
-            else:
+            if current_responses_empty != initial_responses:
                 logger.error("❌ BUG: System accepted empty query and generated response")
+            else:
+                logger.info("✅ System did not accept empty query - no response generated")
         else:
             logger.info("✅ Send button is properly disabled for empty input")
 

content-gen/scripts/create_image_search_index.py

@@ -10,7 +10,6 @@
 """
 
 import asyncio
-import json
 import os
 import sys
 from pathlib import Path

content-gen/scripts/post_deploy.py

@@ -36,13 +36,11 @@
 import argparse
 import asyncio
 import base64
-import json
 import os
 import sys
-import time
 from dataclasses import dataclass
 from pathlib import Path
-from typing import Optional, List, Dict, Any
+from typing import List, Dict, Any
 
 try:
     import httpx

content-gen/scripts/sample_content_generation.py

@@ -28,7 +28,6 @@
 import asyncio
 import argparse
 import json
-import os
 import sys
 from datetime import datetime
 from pathlib import Path
@@ -288,7 +287,7 @@ async def main():
 
     # Generate content
     try:
-        result = await generate_content_sample(
+        await generate_content_sample(
             brief=brief,
             products=products,
             generate_images=not args.no_images,

content-gen/scripts/test_content_generation.py

@@ -12,7 +12,6 @@
 """
 
 import asyncio
-import json
 import sys
 import os
 from typing import Dict, Any