refactor(frontend): dedup streamChat, remove dead code, tighten imports and memoization

Author: Shubhangi-Microsoft

content-gen/src/app/frontend/src/App.tsx

@@ -32,7 +32,6 @@ function App() {
     newConversation,
     confirmBrief,
     cancelBrief,
-    productsStartOver,
     selectProduct,
     toggleHistory,
   } = useConversationActions();
@@ -63,7 +62,6 @@ function App() {
             onBriefCancel={cancelBrief}
             onGenerateContent={generateContent}
             onRegenerateContent={generateContent}
-            onProductsStartOver={productsStartOver}
             onProductSelect={selectProduct}
             onNewConversation={newConversation}
           />

content-gen/src/app/frontend/src/api/index.ts

@@ -10,8 +10,7 @@ import type {
   AppConfig,
 } from '../types';
 import httpClient from './httpClient';
-import { parseSSEStream } from '../utils/sseParser';
-import { getGenerationStage } from '../utils/generationStages';
+import { parseSSEStream, getGenerationStage } from '../utils';
 
 /**
  * Get application configuration including feature flags
@@ -178,7 +177,6 @@ export async function* streamGenerateContent(
         } as AgentResponse;
       }
     } catch (error) {
-      console.error(`Error polling task ${taskId}:`, error);
       // Continue polling on transient errors
       if (attempts >= maxAttempts) {
         throw error;

content-gen/src/app/frontend/src/components/ChatPanel.tsx

@@ -30,7 +30,6 @@ interface ChatPanelProps {
   onBriefCancel?: () => void;
   onGenerateContent?: () => void;
   onRegenerateContent?: () => void;
-  onProductsStartOver?: () => void;
   onProductSelect?: (product: Product) => void;
   onNewConversation?: () => void;
 }
@@ -42,7 +41,6 @@ export const ChatPanel = memo(function ChatPanel({
   onBriefCancel,
   onGenerateContent,
   onRegenerateContent,
-  onProductsStartOver,
   onProductSelect,
   onNewConversation,
 }: ChatPanelProps) {
@@ -88,9 +86,6 @@ export const ChatPanel = memo(function ChatPanel({
 
   const isInputDisabled = useMemo(() => isLoading, [isLoading]);
 
-  const startOverFallback = useCallback(() => {}, []);
-  const effectiveProductsStartOver = onProductsStartOver || startOverFallback;
-
   return (
     <div className="chat-container">
       {/* Messages Area */}
@@ -142,7 +137,6 @@ export const ChatPanel = memo(function ChatPanel({
                 products={selectedProducts}
                 availableProducts={availableProducts}
                 onConfirm={onGenerateContent!}
-                onStartOver={effectiveProductsStartOver}
                 isAwaitingResponse={isLoading}
                 onProductSelect={onProductSelect}
                 disabled={isLoading}

content-gen/src/app/frontend/src/components/InlineContentPreview.tsx

@@ -7,8 +7,7 @@ import {
 import { ShieldError20Regular } from '@fluentui/react-icons';
 import type { GeneratedContent, Product } from '../types';
 import { useWindowSize } from '../hooks/useWindowSize';
-import { isContentFilterError, getErrorMessage } from '../utils/contentErrors';
-import { downloadImage } from '../utils/downloadImage';
+import { isContentFilterError, getErrorMessage, downloadImage } from '../utils';
 import { useCopyToClipboard } from '../hooks/useCopyToClipboard';
 import { ImagePreviewCard } from './ImagePreviewCard';
 import { ComplianceSection } from './ComplianceSection';

content-gen/src/app/frontend/src/components/ProductReview.tsx

@@ -13,7 +13,6 @@ import { ProductCard } from './ProductCard';
 interface ProductReviewProps {
   products: Product[];
   onConfirm: () => void;
-  onStartOver: () => void;
   isAwaitingResponse?: boolean;
   availableProducts?: Product[];
   onProductSelect?: (product: Product) => void;
@@ -23,7 +22,6 @@ interface ProductReviewProps {
 export const ProductReview = memo(function ProductReview({
   products,
   onConfirm,
-  onStartOver: _onStartOver,
   isAwaitingResponse = false,
   availableProducts = [],
   onProductSelect,

content-gen/src/app/frontend/src/components/ViolationCard.tsx

@@ -1,4 +1,4 @@
-import { memo } from 'react';
+import { memo, useMemo } from 'react';
 import {
   Text,
 } from '@fluentui/react-components';
@@ -17,7 +17,7 @@ export interface ViolationCardProps {
  * A single compliance violation row with severity-coloured icon and background.
  */
 export const ViolationCard = memo(function ViolationCard({ violation }: ViolationCardProps) {
-  const getSeverityStyles = () => {
+  const { icon, bg } = useMemo(() => {
     switch (violation.severity) {
       case 'error':
         return {
@@ -35,9 +35,7 @@ export const ViolationCard = memo(function ViolationCard({ violation }: Violatio
           bg: '#deecf9',
         };
     }
-  };
-
-  const { icon, bg } = getSeverityStyles();
+  }, [violation.severity]);
 
   return (
     <div

content-gen/src/app/frontend/src/hooks/useChatOrchestrator.ts

@@ -1,6 +1,6 @@
 import { useCallback, type MutableRefObject } from 'react';
 
-import type { GeneratedContent } from '../types';
+import type { AgentResponse, GeneratedContent } from '../types';
 import { createMessage, createErrorMessage, matchesAnyKeyword, createNameSwapper } from '../utils';
 import {
   useAppDispatch,
@@ -25,6 +25,42 @@ import {
   selectConversationTitle,
   setConversationTitle,
 } from '../store';
+import type { AppDispatch } from '../store';
+
+/* ------------------------------------------------------------------ */
+/*  Shared helper — consumes a streamChat generator and dispatches     */
+/*  the final assistant message.  Used by branches 1-b, 3-b, 4-b.     */
+/* ------------------------------------------------------------------ */
+
+async function consumeStreamChat(
+  stream: AsyncGenerator<AgentResponse>,
+  dispatch: AppDispatch,
+): Promise<void> {
+  let fullContent = '';
+  let currentAgent = '';
+  let messageAdded = false;
+
+  for await (const response of stream) {
+    if (response.type === 'agent_response') {
+      fullContent = response.content;
+      currentAgent = response.agent || '';
+      if ((response.is_final || response.requires_user_input) && !messageAdded) {
+        dispatch(addMessage(createMessage('assistant', fullContent, currentAgent)));
+        messageAdded = true;
+      }
+    } else if (response.type === 'error') {
+      dispatch(
+        addMessage(
+          createMessage(
+            'assistant',
+            response.content || 'An error occurred while processing your request.',
+          ),
+        ),
+      );
+      messageAdded = true;
+    }
+  }
+}
 
 /* ------------------------------------------------------------------ */
 /*  Hook                                                               */
@@ -130,42 +166,11 @@ export function useChatOrchestrator(
             }
           } else {
             // --- 1-b  General question while brief is pending -----------
-            let fullContent = '';
-            let currentAgent = '';
-            let messageAdded = false;
-
             dispatch(setGenerationStatus('Processing your question...'));
-            for await (const response of streamChat(
-              content,
-              conversationId,
-              userId,
-              signal,
-            )) {
-              if (response.type === 'agent_response') {
-                fullContent = response.content;
-                currentAgent = response.agent || '';
-                if (
-                  (response.is_final || response.requires_user_input) &&
-                  !messageAdded
-                ) {
-                  dispatch(
-                    addMessage(createMessage('assistant', fullContent, currentAgent)),
-                  );
-                  messageAdded = true;
-                }
-              } else if (response.type === 'error') {
-                dispatch(
-                  addMessage(
-                    createMessage(
-                      'assistant',
-                      response.content ||
-                        'An error occurred while processing your request.',
-                    ),
-                  ),
-                );
-                messageAdded = true;
-              }
-            }
+            await consumeStreamChat(
+              streamChat(content, conversationId, userId, signal),
+              dispatch,
+            );
             dispatch(setGenerationStatus(''));
           }
 
@@ -321,41 +326,11 @@ export function useChatOrchestrator(
             );
           } else {
             // --- 3-b  General question after content generation --------
-            let fullContent = '';
-            let currentAgent = '';
-            let messageAdded = false;
-
             dispatch(setGenerationStatus('Processing your request...'));
-            for await (const response of streamChat(
-              content,
-              conversationId,
-              userId,
-              signal,
-            )) {
-              if (response.type === 'agent_response') {
-                fullContent = response.content;
-                currentAgent = response.agent || '';
-                if (
-                  (response.is_final || response.requires_user_input) &&
-                  !messageAdded
-                ) {
-                  dispatch(
-                    addMessage(createMessage('assistant', fullContent, currentAgent)),
-                  );
-                  messageAdded = true;
-                }
-              } else if (response.type === 'error') {
-                dispatch(
-                  addMessage(
-                    createMessage(
-                      'assistant',
-                      response.content || 'An error occurred.',
-                    ),
-                  ),
-                );
-                messageAdded = true;
-              }
-            }
+            await consumeStreamChat(
+              streamChat(content, conversationId, userId, signal),
+              dispatch,
+            );
             dispatch(setGenerationStatus(''));
           }
 
@@ -426,42 +401,11 @@ export function useChatOrchestrator(
             }
           } else {
             // --- 4-b  Generic chat -----------------------------------
-            let fullContent = '';
-            let currentAgent = '';
-            let messageAdded = false;
-
             dispatch(setGenerationStatus('Processing your request...'));
-            for await (const response of streamChat(
-              content,
-              conversationId,
-              userId,
-              signal,
-            )) {
-              if (response.type === 'agent_response') {
-                fullContent = response.content;
-                currentAgent = response.agent || '';
-                if (
-                  (response.is_final || response.requires_user_input) &&
-                  !messageAdded
-                ) {
-                  dispatch(
-                    addMessage(createMessage('assistant', fullContent, currentAgent)),
-                  );
-                  messageAdded = true;
-                }
-              } else if (response.type === 'error') {
-                dispatch(
-                  addMessage(
-                    createMessage(
-                      'assistant',
-                      response.content ||
-                        'An error occurred while processing your request.',
-                    ),
-                  ),
-                );
-                messageAdded = true;
-              }
-            }
+            await consumeStreamChat(
+              streamChat(content, conversationId, userId, signal),
+              dispatch,
+            );
             dispatch(setGenerationStatus(''));
           }
         }

content-gen/src/app/frontend/src/hooks/useConversationActions.ts

@@ -182,19 +182,6 @@ export function useConversationActions() {
   /* ------------------------------------------------------------ */
   /*  Product actions                                              */
   /* ------------------------------------------------------------ */
-  const productsStartOver = useCallback(() => {
-    dispatch(setSelectedProducts([]));
-    dispatch(setConfirmedBrief(null));
-    dispatch(
-      addMessage(
-        createMessage(
-          'assistant',
-          'Starting over. Please provide your creative brief to begin a new campaign.',
-        ),
-      ),
-    );
-  }, [dispatch]);
-
   const selectProduct = useCallback(
     (product: Product) => {
       const isSelected = selectedProducts.some(
@@ -224,7 +211,6 @@ export function useConversationActions() {
     newConversation,
     confirmBrief,
     cancelBrief,
-    productsStartOver,
     selectProduct,
     toggleHistory,
   };

content-gen/src/app/frontend/src/hooks/useDebounce.ts

@@ -23,10 +23,6 @@ export { BRIEF_FIELD_LABELS, BRIEF_DISPLAY_ORDER, BRIEF_FIELD_KEYS } from './bri
 // String utilities
 export { createNameSwapper, matchesAnyKeyword } from './stringUtils';
 
-// Production API utilities
-export { retryRequest, RequestCache, throttle } from './apiUtils';
-export type { RetryOptions } from './apiUtils';
-
 // Content error detection
 export { isContentFilterError, getErrorMessage } from './contentErrors';