unit test fixed

Author: AjitPadhi-Microsoft

src/tests/ContentProcessorAPI/helpers/test_azure_credential_utils.py

@@ -7,6 +7,8 @@
 import sys
 from unittest.mock import MagicMock, patch
 
+import pytest
+
 sys.path.insert(0, os.path.abspath(os.path.join(os.path.dirname(__file__), "..", "..", "..", "ContentProcessorAPI")))
 
 import app.utils.azure_credential_utils as azure_credential_utils  # noqa: E402
@@ -48,3 +50,43 @@ def test_get_azure_credential_non_dev_env(
     mock_managed_identity_credential.assert_called_once_with(client_id="test-client-id")
     mock_default_azure_credential.assert_not_called()
     assert credential == mock_managed_credential
+
+
+@pytest.mark.asyncio
+@patch("app.utils.azure_credential_utils.os.getenv")
+@patch("app.utils.azure_credential_utils.AioDefaultAzureCredential")
+@patch("app.utils.azure_credential_utils.AioManagedIdentityCredential")
+async def test_get_azure_credential_async_dev_env(
+    mock_aio_managed, mock_aio_default, mock_getenv
+):
+    """Test get_azure_credential_async in dev environment."""
+    mock_getenv.return_value = "dev"
+    mock_cred = MagicMock()
+    mock_aio_default.return_value = mock_cred
+
+    credential = await azure_credential_utils.get_azure_credential_async()
+
+    mock_getenv.assert_called_once_with("APP_ENV", "prod")
+    mock_aio_default.assert_called_once()
+    mock_aio_managed.assert_not_called()
+    assert credential == mock_cred
+
+
+@pytest.mark.asyncio
+@patch("app.utils.azure_credential_utils.os.getenv")
+@patch("app.utils.azure_credential_utils.AioDefaultAzureCredential")
+@patch("app.utils.azure_credential_utils.AioManagedIdentityCredential")
+async def test_get_azure_credential_async_non_dev_env(
+    mock_aio_managed, mock_aio_default, mock_getenv
+):
+    """Test get_azure_credential_async in non-dev environment."""
+    mock_getenv.return_value = "prod"
+    mock_cred = MagicMock()
+    mock_aio_managed.return_value = mock_cred
+
+    credential = await azure_credential_utils.get_azure_credential_async(client_id="test-id")
+
+    mock_getenv.assert_called_once_with("APP_ENV", "prod")
+    mock_aio_managed.assert_called_once_with(client_id="test-id")
+    mock_aio_default.assert_not_called()
+    assert credential == mock_cred

src/tests/ContentProcessorAPI/helpers/test_telemetry_filter.py

@@ -0,0 +1,190 @@
+# Copyright (c) Microsoft Corporation.
+# Licensed under the MIT License.
+
+"""Unit tests for the OpenTelemetry span-noise filter."""
+
+import os
+import sys
+from unittest.mock import MagicMock, patch
+
+sys.path.insert(0, os.path.abspath(os.path.join(os.path.dirname(__file__), "..", "..", "..", "ContentProcessorAPI")))
+
+from app.utils.telemetry_filter import install_noise_filter  # noqa: E402
+
+
+@patch("app.utils.telemetry_filter.trace")
+def test_install_noise_filter_no_active_processor(mock_trace):
+    """Early return when the provider has no _active_span_processor."""
+    mock_provider = MagicMock(spec=[])  # no attributes at all
+    mock_trace.get_tracer_provider.return_value = mock_provider
+
+    install_noise_filter(noisy_names=frozenset({"Foo"}))
+    # Nothing to wrap, should return without error
+
+
+@patch("app.utils.telemetry_filter.trace")
+def test_install_noise_filter_wraps_inner_processors(mock_trace):
+    """Wraps each processor in _span_processors tuple."""
+    inner_proc_1 = MagicMock()
+    inner_proc_2 = MagicMock()
+
+    active_proc = MagicMock()
+    active_proc._span_processors = (inner_proc_1, inner_proc_2)
+
+    mock_provider = MagicMock()
+    mock_provider._active_span_processor = active_proc
+    mock_trace.get_tracer_provider.return_value = mock_provider
+
+    install_noise_filter(
+        noisy_names=frozenset({"NoisySpan"}),
+        noisy_suffixes=(".noisy",),
+    )
+
+    # The tuple should have been replaced with wrapped processors
+    assert len(active_proc._span_processors) == 2
+    # Each element should be a _Filter wrapping the original
+    for wrapped in active_proc._span_processors:
+        assert hasattr(wrapped, "_inner")
+
+
+@patch("app.utils.telemetry_filter.trace")
+def test_install_noise_filter_wraps_direct_processor(mock_trace):
+    """Wraps the processor directly when _span_processors is absent."""
+    active_proc = MagicMock(spec=["on_start", "on_end", "shutdown", "force_flush"])
+    # No _span_processors attribute
+
+    mock_provider = MagicMock()
+    mock_provider._active_span_processor = active_proc
+    mock_trace.get_tracer_provider.return_value = mock_provider
+
+    install_noise_filter(noisy_names=frozenset({"NoisySpan"}))
+
+    # Provider should now have a wrapped processor
+    new_proc = mock_provider._active_span_processor
+    assert hasattr(new_proc, "_inner")
+    assert new_proc._inner is active_proc
+
+
+@patch("app.utils.telemetry_filter.trace")
+def test_filter_on_start_delegates(mock_trace):
+    """_Filter.on_start delegates to the inner processor."""
+    inner_proc = MagicMock()
+    active_proc = MagicMock()
+    active_proc._span_processors = (inner_proc,)
+
+    mock_provider = MagicMock()
+    mock_provider._active_span_processor = active_proc
+    mock_trace.get_tracer_provider.return_value = mock_provider
+
+    install_noise_filter(noisy_names=frozenset({"NoisySpan"}))
+
+    wrapped = active_proc._span_processors[0]
+    mock_span = MagicMock()
+    mock_context = MagicMock()
+    wrapped.on_start(mock_span, mock_context)
+
+    inner_proc.on_start.assert_called_once_with(mock_span, mock_context)
+
+
+@patch("app.utils.telemetry_filter.trace")
+def test_filter_on_end_drops_noisy_name(mock_trace):
+    """_Filter.on_end drops spans whose name is in noisy_names."""
+    inner_proc = MagicMock()
+    active_proc = MagicMock()
+    active_proc._span_processors = (inner_proc,)
+
+    mock_provider = MagicMock()
+    mock_provider._active_span_processor = active_proc
+    mock_trace.get_tracer_provider.return_value = mock_provider
+
+    install_noise_filter(noisy_names=frozenset({"MsiToken.Refresh"}))
+
+    wrapped = active_proc._span_processors[0]
+    mock_span = MagicMock()
+    mock_span.name = "MsiToken.Refresh"
+    wrapped.on_end(mock_span)
+
+    inner_proc.on_end.assert_not_called()
+
+
+@patch("app.utils.telemetry_filter.trace")
+def test_filter_on_end_drops_noisy_suffix(mock_trace):
+    """_Filter.on_end drops spans whose name ends with a noisy suffix."""
+    inner_proc = MagicMock()
+    active_proc = MagicMock()
+    active_proc._span_processors = (inner_proc,)
+
+    mock_provider = MagicMock()
+    mock_provider._active_span_processor = active_proc
+    mock_trace.get_tracer_provider.return_value = mock_provider
+
+    install_noise_filter(noisy_suffixes=(" send", " receive"))
+
+    wrapped = active_proc._span_processors[0]
+    mock_span = MagicMock()
+    mock_span.name = "ServiceBusReceiver receive"
+    wrapped.on_end(mock_span)
+
+    inner_proc.on_end.assert_not_called()
+
+
+@patch("app.utils.telemetry_filter.trace")
+def test_filter_on_end_passes_non_noisy(mock_trace):
+    """_Filter.on_end passes through non-noisy spans."""
+    inner_proc = MagicMock()
+    active_proc = MagicMock()
+    active_proc._span_processors = (inner_proc,)
+
+    mock_provider = MagicMock()
+    mock_provider._active_span_processor = active_proc
+    mock_trace.get_tracer_provider.return_value = mock_provider
+
+    install_noise_filter(
+        noisy_names=frozenset({"NoisySpan"}),
+        noisy_suffixes=(".noisy",),
+    )
+
+    wrapped = active_proc._span_processors[0]
+    mock_span = MagicMock()
+    mock_span.name = "ImportantOperation"
+    wrapped.on_end(mock_span)
+
+    inner_proc.on_end.assert_called_once_with(mock_span)
+
+
+@patch("app.utils.telemetry_filter.trace")
+def test_filter_shutdown_delegates(mock_trace):
+    """_Filter.shutdown delegates to the inner processor."""
+    inner_proc = MagicMock()
+    active_proc = MagicMock()
+    active_proc._span_processors = (inner_proc,)
+
+    mock_provider = MagicMock()
+    mock_provider._active_span_processor = active_proc
+    mock_trace.get_tracer_provider.return_value = mock_provider
+
+    install_noise_filter(noisy_names=frozenset())
+
+    wrapped = active_proc._span_processors[0]
+    wrapped.shutdown()
+
+    inner_proc.shutdown.assert_called_once()
+
+
+@patch("app.utils.telemetry_filter.trace")
+def test_filter_force_flush_delegates(mock_trace):
+    """_Filter.force_flush delegates to the inner processor."""
+    inner_proc = MagicMock()
+    active_proc = MagicMock()
+    active_proc._span_processors = (inner_proc,)
+
+    mock_provider = MagicMock()
+    mock_provider._active_span_processor = active_proc
+    mock_trace.get_tracer_provider.return_value = mock_provider
+
+    install_noise_filter(noisy_names=frozenset())
+
+    wrapped = active_proc._span_processors[0]
+    wrapped.force_flush(timeout_millis=5000)
+
+    inner_proc.force_flush.assert_called_once_with(5000)

src/tests/ContentProcessorAPI/libs/test_cosmos_db_helper.py

@@ -195,3 +195,45 @@ def test_update_document_by_query(mock_certifi, mock_mongo_client):
 
     assert result == mock_result
     mock_container.update_one.assert_called_once_with(query, {"$set": update})
+
+
+@patch("app.libs.azure.cosmos_db.helper.MongoClient")
+@patch("app.libs.azure.cosmos_db.helper.certifi.where")
+def test_init_with_indexes(mock_certifi, mock_mongo_client):
+    """Test CosmosMongDBHelper initialization with indexes creates missing indexes."""
+    mock_certifi.return_value = "/path/to/cert"
+    mock_client = MagicMock()
+    mock_mongo_client.return_value = mock_client
+    mock_db = MagicMock()
+    mock_client.__getitem__.return_value = mock_db
+    mock_db.list_collection_names.return_value = ["test_container"]
+    mock_container = MagicMock()
+    mock_db.__getitem__.return_value = mock_container
+    mock_container.index_information.return_value = {}
+
+    helper = CosmosMongDBHelper(
+        connection_string="mongodb://test",
+        db_name="test_db",
+        container_name="test_container",
+        indexes=[("field1", 1), ("field2", -1)],
+    )
+
+    assert mock_container.create_index.call_count == 2
+
+
+@patch("app.libs.azure.cosmos_db.helper.MongoClient")
+@patch("app.libs.azure.cosmos_db.helper.certifi.where")
+def test_create_container_when_missing(mock_certifi, mock_mongo_client):
+    """Test _create_container creates collection when it does not exist."""
+    mock_certifi.return_value = "/path/to/cert"
+    mock_client = MagicMock()
+    mock_mongo_client.return_value = mock_client
+    mock_db = MagicMock()
+    mock_client.__getitem__.return_value = mock_db
+    mock_db.list_collection_names.return_value = []
+    mock_container = MagicMock()
+    mock_db.__getitem__.return_value = mock_container
+
+    CosmosMongDBHelper("mongodb://test", "test_db", "new_container")
+
+    mock_db.create_collection.assert_called_once_with("new_container")