Fix remaining linting errors: add missing pytest imports, fix unused variables, fix indentation

Author: Prachig-Microsoft

src/tests/ContentProcessor/libs/test_application_context_extended.py

@@ -1,4 +1,5 @@
 """Extended tests for application_context.py to improve coverage"""
+import pytest
 from unittest.mock import Mock
 from libs.application.application_context import (
     ServiceLifetime,

src/tests/ContentProcessor/libs/test_final_push_80.py

@@ -10,7 +10,7 @@ def test_data_pipeline_update_status(self):
         from libs.pipeline.entities.pipeline_data import DataPipeline
         from libs.pipeline.entities.pipeline_status import PipelineStatus
 
-       # Create with required fields
+        # Create with required fields
         with patch('libs.pipeline.entities.pipeline_data.datetime') as mock_dt:
             mock_dt.now.return_value.isoformat.return_value = "2026-03-24T00:00:00"
 

src/tests/ContentProcessor/libs/test_utils_coverage_boost.py

@@ -1,5 +1,4 @@
 """Targeted tests for small utility gaps to reach 80%"""
-from unittest.mock import patch
 
 
 class TestBase64Util:

src/tests/ContentProcessor/utils/test_azure_credential_utils_extended.py

@@ -1,4 +1,5 @@
 """Extended tests for azure_credential_utils.py to improve coverage"""
+import pytest
 from unittest.mock import Mock, patch
 from libs.utils.azure_credential_utils import (
     get_azure_credential,

src/tests/ContentProcessorAPI/libs/test_cosmos_db_helper.py

@@ -167,7 +167,7 @@ def test_delete_document(mock_certifi, mock_mongo_client):
     mock_result = MagicMock()
     mock_container.delete_one.return_value = mock_result
 
-    result = helper.delete_document("test_id")
+    _result = helper.delete_document("test_id")
     mock_container.delete_one.assert_called_once_with({"Id": "test_id"})
 
 

src/tests/ContentProcessorWorkflow/libs/test_application_base_extended.py

@@ -38,7 +38,7 @@ def test_initialization_with_explicit_env_file(self, tmp_path):
             mock_cred_instance = Mock()
             mock_cred.return_value = mock_cred_instance
 
-            app = ConcreteApplication(env_file_path=str(env_file))
+            _app = ConcreteApplication(env_file_path=str(env_file))
 
             assert app.application_context is not None
             assert isinstance(app.application_context, AppContext)
@@ -60,7 +60,7 @@ def test_initialization_auto_discover_env_file(self, tmp_path, monkeypatch):
             mock_getfile.return_value = str(test_file)
             mock_cred.return_value = Mock()
 
-            app = ConcreteApplication()
+            _app = ConcreteApplication()
 
             assert app.application_context is not None
             assert app.initialized is True
@@ -81,7 +81,7 @@ def test_initialization_with_app_config_endpoint(self, tmp_path, monkeypatch):
             mock_app_config_instance = Mock()
             mock_app_config.return_value = mock_app_config_instance
 
-            app = ConcreteApplication(env_file_path=str(env_file))
+            _app = ConcreteApplication(env_file_path=str(env_file))
 
             mock_app_config.assert_called_once()
             mock_app_config_instance.read_and_set_environmental_variables.assert_called_once()
@@ -101,7 +101,7 @@ def test_initialization_with_logging_enabled(self, tmp_path, monkeypatch):
 
             mock_cred.return_value = Mock()
 
-            app = ConcreteApplication(env_file_path=str(env_file))
+            _app = ConcreteApplication(env_file_path=str(env_file))
 
             # Verify logging was configured
             mock_logging.assert_called_once()
@@ -122,7 +122,7 @@ def test_initialization_without_logging(self, tmp_path, monkeypatch):
 
             mock_cred.return_value = Mock()
 
-            app = ConcreteApplication(env_file_path=str(env_file))
+            _app = ConcreteApplication(env_file_path=str(env_file))
 
             # Verify logging was NOT configured
             mock_logging.assert_not_called()
@@ -140,7 +140,7 @@ def test_initialization_sets_llm_settings(self, tmp_path):
             mock_llm_instance = Mock()
             mock_llm_settings.return_value = mock_llm_instance
 
-            app = ConcreteApplication(env_file_path=str(env_file))
+            _app = ConcreteApplication(env_file_path=str(env_file))
 
             assert app.application_context.llm_settings == mock_llm_instance
             mock_llm_settings.assert_called_once_with(
@@ -158,7 +158,7 @@ def test_load_env_with_explicit_path(self, tmp_path):
              patch('libs.base.application_base.AgentFrameworkSettings'), \
              patch('libs.base.application_base.load_dotenv') as mock_load_dotenv:
 
-            app = ConcreteApplication(env_file_path=str(env_file))
+            _app = ConcreteApplication(env_file_path=str(env_file))
 
             # Verify load_dotenv was called at least once
             assert mock_load_dotenv.call_count >= 1
@@ -177,7 +177,7 @@ def test_get_derived_class_location(self, tmp_path):
             test_env = tmp_path / ".env"
             test_env.write_text("APP_LOGGING_ENABLE=false\n")
 
-            app = ConcreteApplication(env_file_path=str(test_env))
+            _app = ConcreteApplication(env_file_path=str(test_env))
 
             location = app._get_derived_class_location()
 
@@ -196,7 +196,7 @@ def test_application_context_credential_set(self, tmp_path):
             mock_cred_instance = Mock()
             mock_cred.return_value = mock_cred_instance
 
-            app = ConcreteApplication(env_file_path=str(env_file))
+            _app = ConcreteApplication(env_file_path=str(env_file))
 
             assert app.application_context.credential == mock_cred_instance
 
@@ -211,7 +211,7 @@ def test_application_context_configuration_set(self, tmp_path, monkeypatch):
              patch('libs.base.application_base.AppConfigurationHelper'), \
              patch('libs.base.application_base.AgentFrameworkSettings'):
 
-            app = ConcreteApplication(env_file_path=str(env_file))
+            _app = ConcreteApplication(env_file_path=str(env_file))
 
             assert app.application_context.configuration is not None
 
@@ -224,7 +224,7 @@ def test_run_method_called(self, tmp_path):
              patch('libs.base.application_base.AppConfigurationHelper'), \
              patch('libs.base.application_base.AgentFrameworkSettings'):
 
-            app = ConcreteApplication(env_file_path=str(env_file))
+            _app = ConcreteApplication(env_file_path=str(env_file))
 
             assert app.running is False
             app.run()
@@ -241,7 +241,7 @@ def test_initialize_method_called_during_init(self, tmp_path):
 
             # initialized flag is set in ConcreteApplication.__init__ which calls super().__init__
             # But the initialize() method sets initialized=True
-            app = ConcreteApplication(env_file_path=str(env_file))
+            _app = ConcreteApplication(env_file_path=str(env_file))
 
             # The initialize() method should have been called in ConcreteApplication.__init__
             assert app.initialized is True
@@ -257,7 +257,7 @@ def test_empty_app_config_endpoint_skipped(self, tmp_path, monkeypatch):
              patch('libs.base.application_base.AppConfigurationHelper') as mock_app_config, \
              patch('libs.base.application_base.AgentFrameworkSettings'):
 
-            app = ConcreteApplication(env_file_path=str(env_file))
+            _app = ConcreteApplication(env_file_path=str(env_file))
 
             # AppConfigurationHelper should not be called with empty endpoint
             mock_app_config.assert_not_called()
@@ -274,7 +274,7 @@ def test_none_app_config_endpoint_skipped(self, tmp_path, monkeypatch):
              patch('libs.base.application_base.AppConfigurationHelper') as mock_app_config, \
              patch('libs.base.application_base.AgentFrameworkSettings'):
 
-            app = ConcreteApplication(env_file_path=str(env_file))
+            _app = ConcreteApplication(env_file_path=str(env_file))
 
             # AppConfigurationHelper should not be called
             mock_app_config.assert_not_called()

src/tests/ContentProcessorWorkflow/libs/test_final_80_percent_push.py

@@ -1,4 +1,5 @@
 """Targeted tests to reach 80% coverage for ContentProcessorWorkflow"""
+import pytest
 from unittest.mock import Mock, patch
 
 
@@ -10,7 +11,7 @@ def test_service_scope_get_service_not_registered(self):
         from libs.application.application_context import AppContext
 
         context = AppContext()
-        _scope = context._scopes.get("default", None)
+
 
         class UnregisteredService:
             pass

src/tests/ContentProcessorWorkflow/libs/test_push_to_80_percent.py

@@ -9,7 +9,6 @@ class TestApplicationBaseComplete:
     def test_application_base_with_explicit_env_path(self):
         """Test ApplicationBase with explicit env file path"""
         from libs.base.application_base import ApplicationBase
-        from libs.application.application_context import AppContext
 
         class TestApp(ApplicationBase):
             def initialize(self):
@@ -27,7 +26,7 @@ def run(self):
             mock_env_config.return_value.app_config_endpoint = ""
 
             # Test with explicit path
-            app = TestApp(env_file_path="/custom/path/.env")
+            _app = TestApp(env_file_path="/custom/path/.env")
 
             # Should have loaded from explicit path
             mock_load_dotenv.assert_called_with(dotenv_path="/custom/path/.env")
@@ -44,7 +43,7 @@ def run(self):
                 pass
 
         with patch('libs.base.application_base.load_dotenv'), \
-             patch('libs.base.application_base.DefaultAzureCredential') as mock_cred, \
+             patch('libs.base.application_base.DefaultAzureCredential'), \\
              patch('libs.base.application_base.Configuration') as mock_config, \
              patch('libs.base.application_base.AgentFrameworkSettings'), \
              patch('libs.base.application_base._envConfiguration') as mock_env_config, \
@@ -54,7 +53,7 @@ def run(self):
             mock_env_config.return_value.app_config_endpoint = "https://myconfig.azconfig.io"
             mock_config.return_value.app_logging_enable = False
 
-            app = TestApp()
+            _app = TestApp()
 
             # Should have created AppConfigurationHelper
             assert mock_app_config.called
@@ -86,7 +85,7 @@ def run(self):
             config_instance.app_logging_level = "DEBUG"
             mock_config.return_value = config_instance
 
-            app = TestApp()
+            _app = TestApp()
 
             # Should have configured logging
             mock_logging.assert_called_once()

src/tests/ContentProcessorWorkflow/libs/test_ultra_focused_80.py

@@ -20,7 +20,7 @@ class TestService:
             cleanup_method=None
         )
 
-        assert descriptor.service_type ==TestService
+        assert descriptor.service_type == TestService
         assert descriptor.lifetime == ServiceLifetime.SINGLETON
         assert descriptor.is_async is False
 
@@ -83,7 +83,7 @@ class TestApplicationBaseMissedLines:
     def test_load_env_returns_path(self):
         """Test that _load_env returns the loaded path"""
         from libs.base.application_base import ApplicationBase
-        import os
+
 
         class TestApp(ApplicationBase):
             def initialize(self):
@@ -102,7 +102,7 @@ def run(self):
             mock_config.return_value.app_logging_enable = False
 
             # Create app with no explicit env path
-            app = TestApp()
+            _app = TestApp()
 
             # Should have called load_dotenv
             assert mock_load.called