From 2850ed087cde978ca14eb99dcb8d2e953a68469c Mon Sep 17 00:00:00 2001 From: "Niraj Chaudhari (Persistent Systems Inc)" Date: Mon, 22 Sep 2025 16:23:52 +0530 Subject: [PATCH 1/4] Remove createdby from pipeline and change logic for createdby tag in bicep --- .github/workflows/deploy.yml | 1 - infra/main.bicep | 4 ++-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml index 36824ccd..a4152fc1 100644 --- a/.github/workflows/deploy.yml +++ b/.github/workflows/deploy.yml @@ -150,7 +150,6 @@ jobs: gptModelVersion="2024-08-06" \ gptDeploymentCapacity="30" \ aiDeploymentsLocation="${{ env.AZURE_LOCATION }}" \ - tags='{"CreatedBy":"Pipeline"}' \ --query "properties.outputs" -o json); then echo "❌ Deployment failed. See logs above." exit 1 diff --git a/infra/main.bicep b/infra/main.bicep index abd6f125..690fdb92 100644 --- a/infra/main.bicep +++ b/infra/main.bicep @@ -418,8 +418,8 @@ module applicationInsights 'br/public:avm/res/insights/component:0.6.0' = { } } -@description('Optional created by user name') -param createdBy string = empty(deployer().userPrincipalName) ? '' : split(deployer().userPrincipalName, '@')[0] +param createdBy string = contains(deployer(), 'userPrincipalName')? split(deployer().userPrincipalName, '@')[0]: deployer().objectId + // ========== Resource Group Tag ========== // resource resourceGroupTags 'Microsoft.Resources/tags@2021-04-01' = { name: 'default' From 839d5cfc7907f3bb6690b8b5455da1472a3d2ee8 Mon Sep 17 00:00:00 2001 From: NirajC-Microsoft Date: Mon, 22 Sep 2025 22:24:46 +0530 Subject: [PATCH 2/4] Fix YAML syntax for deployment tags --- .github/workflows/deploy.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml index a4152fc1..b6d6a501 100644 --- a/.github/workflows/deploy.yml +++ b/.github/workflows/deploy.yml @@ -150,6 +150,7 @@ jobs: gptModelVersion="2024-08-06" \ gptDeploymentCapacity="30" \ aiDeploymentsLocation="${{ env.AZURE_LOCATION }}" \ + tags='{"CreatedBy":"Pipeline"}' \ --query "properties.outputs" -o json); then echo "❌ Deployment failed. See logs above." exit 1 @@ -511,4 +512,4 @@ jobs: curl -X POST "${{ secrets.LOGIC_APP_URL }}" \ -H "Content-Type: application/json" \ - -d "$EMAIL_BODY" || echo "Failed to send notification" \ No newline at end of file + -d "$EMAIL_BODY" || echo "Failed to send notification" From 7bb0ec17fdbed0d3e01a9b95ee011be44d4f323e Mon Sep 17 00:00:00 2001 From: NirajC-Microsoft Date: Mon, 22 Sep 2025 22:25:42 +0530 Subject: [PATCH 3/4] Fix curl command for sending notification From dccf67cd920dabc00ee045f9e2698a68a8d84b13 Mon Sep 17 00:00:00 2001 From: NirajC-Microsoft Date: Tue, 23 Sep 2025 15:46:25 +0530 Subject: [PATCH 4/4] Add parameter for createdBy tag in main.bicep --- infra/main.bicep | 1 + 1 file changed, 1 insertion(+) diff --git a/infra/main.bicep b/infra/main.bicep index 690fdb92..4c971ec5 100644 --- a/infra/main.bicep +++ b/infra/main.bicep @@ -418,6 +418,7 @@ module applicationInsights 'br/public:avm/res/insights/component:0.6.0' = { } } +@description('Tag, Created by user name') param createdBy string = contains(deployer(), 'userPrincipalName')? split(deployer().userPrincipalName, '@')[0]: deployer().objectId // ========== Resource Group Tag ========== //