Skip to content

Commit 25fc4f8

Browse files
author
Milder Hernandez Cagua
committed
Fix redis tests
1 parent 1f92dc4 commit 25fc4f8

3 files changed

Lines changed: 45 additions & 9 deletions

File tree

api-test/integration-tests/src/test/java/com/microsoft/semantickernel/tests/connectors/memory/redis/RedisHashSetVectorStoreRecordCollectionTest.java

Lines changed: 21 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -69,10 +69,28 @@ static void setup() {
6969
.withFieldType(String.class)
7070
.build());
7171
fields.add(VectorStoreRecordVectorField.builder()
72-
.withName("descriptionEmbedding")
73-
.withStorageName("summaryEmbedding")
72+
.withName("euclidean")
73+
.withStorageName("summaryEmbedding1")
7474
.withFieldType(List.class)
75-
.withDimensions(768)
75+
.withDimensions(8)
76+
.build());
77+
fields.add(VectorStoreRecordVectorField.builder()
78+
.withName("cosineDistance")
79+
.withStorageName("summaryEmbedding2")
80+
.withFieldType(List.class)
81+
.withDimensions(8)
82+
.build());
83+
fields.add(VectorStoreRecordVectorField.builder()
84+
.withName("dotProduct")
85+
.withStorageName("summaryEmbedding3")
86+
.withFieldType(List.class)
87+
.withDimensions(8)
88+
.build());
89+
fields.add(VectorStoreRecordVectorField.builder()
90+
.withName("indexedEuclidean")
91+
.withStorageName("indexedSummaryEmbedding")
92+
.withFieldType(List.class)
93+
.withDimensions(8)
7694
.build());
7795
fields.add(VectorStoreRecordDataField.builder()
7896
.withName("rating")

api-test/integration-tests/src/test/java/com/microsoft/semantickernel/tests/connectors/memory/redis/RedisJsonVectorStoreRecordCollectionTest.java

Lines changed: 21 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -70,10 +70,28 @@ static void setup() {
7070
.withFieldType(String.class)
7171
.build());
7272
fields.add(VectorStoreRecordVectorField.builder()
73-
.withName("descriptionEmbedding")
74-
.withStorageName("summaryEmbedding")
73+
.withName("euclidean")
74+
.withStorageName("summaryEmbedding1")
7575
.withFieldType(List.class)
76-
.withDimensions(768)
76+
.withDimensions(8)
77+
.build());
78+
fields.add(VectorStoreRecordVectorField.builder()
79+
.withName("cosineDistance")
80+
.withStorageName("summaryEmbedding2")
81+
.withFieldType(List.class)
82+
.withDimensions(8)
83+
.build());
84+
fields.add(VectorStoreRecordVectorField.builder()
85+
.withName("dotProduct")
86+
.withStorageName("summaryEmbedding3")
87+
.withFieldType(List.class)
88+
.withDimensions(8)
89+
.build());
90+
fields.add(VectorStoreRecordVectorField.builder()
91+
.withName("indexedEuclidean")
92+
.withStorageName("indexedSummaryEmbedding")
93+
.withFieldType(List.class)
94+
.withDimensions(8)
7795
.build());
7896
fields.add(VectorStoreRecordDataField.builder()
7997
.withName("rating")

semantickernel-experimental/src/main/java/com/microsoft/semantickernel/connectors/data/redis/RedisVectorStoreCollectionCreateMapping.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,11 +33,11 @@ public class RedisVectorStoreCollectionCreateMapping {
3333
private static String getAlgorithmMetric(
3434
VectorStoreRecordVectorField vectorField) {
3535
if (vectorField.getDistanceFunction() == null) {
36-
return RedisVectorDistanceMetric.COSINE;
36+
return RedisVectorDistanceMetric.EUCLIDEAN;
3737
}
3838

3939
switch (vectorField.getDistanceFunction()) {
40-
case COSINE_SIMILARITY:
40+
case COSINE_DISTANCE:
4141
return RedisVectorDistanceMetric.COSINE;
4242
case DOT_PRODUCT:
4343
return RedisVectorDistanceMetric.DOT_PRODUCT;
@@ -134,7 +134,7 @@ static class RedisIndexSchemaParams {
134134
static class RedisVectorDistanceMetric {
135135
public static final String EUCLIDEAN = "L2";
136136
public static final String DOT_PRODUCT = "IP";
137-
public static final String COSINE = "COSINE";
137+
public static final String COSINE = "COSINE"; // Cosine distance
138138
}
139139

140140
}

0 commit comments

Comments
 (0)