Skip to content

Commit 3cbee72

Browse files
committed
Missing getter methods and wrong null check
1 parent bc0f640 commit 3cbee72

2 files changed

Lines changed: 32 additions & 4 deletions

File tree

  • data/semantickernel-data-oracle/src/main/java/com/microsoft/semantickernel/data/jdbc/oracle
  • samples/semantickernel-learn-resources/src/main/java/com/microsoft/semantickernel/samples/documentationexamples/data/vectorstores/oracle

data/semantickernel-data-oracle/src/main/java/com/microsoft/semantickernel/data/jdbc/oracle/OracleVectorStoreQueryProvider.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -309,7 +309,7 @@ private void setUpsertStatementValues(PreparedStatement statement, Object record
309309
if (field instanceof VectorStoreRecordVectorField) {
310310
// Convert the vector field to a string
311311
if (!field.getFieldType().equals(String.class)) {
312-
double[] values = valueNode == null ? null : StreamSupport.stream(((ArrayNode)valueNode).spliterator(), false).mapToDouble(d -> d.asDouble()).toArray();
312+
double[] values = valueNode.isNull() ? null : StreamSupport.stream(((ArrayNode)valueNode).spliterator(), false).mapToDouble(d -> d.asDouble()).toArray();
313313
statement.setObject(i + 1, values, OracleType.VECTOR_FLOAT64);
314314
System.out.println("Set values: " + values);
315315
continue;

samples/semantickernel-learn-resources/src/main/java/com/microsoft/semantickernel/samples/documentationexamples/data/vectorstores/oracle/Book.java

Lines changed: 31 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,6 @@
1010

1111
public class Book {
1212

13-
@VectorStoreRecordKey
14-
private final String isbn;
15-
1613
public Book(String isbn, String title, String author, int pages,
1714
List<String> tags, String summary, List<Float> summaryEmbedding) {
1815
this.isbn = isbn;
@@ -24,6 +21,10 @@ public Book(String isbn, String title, String author, int pages,
2421
this.summaryEmbedding = summaryEmbedding;
2522
}
2623

24+
25+
@VectorStoreRecordKey
26+
private final String isbn;
27+
2728
@VectorStoreRecordData(isFilterable = true)
2829
private final String title;
2930

@@ -42,4 +43,31 @@ public Book(String isbn, String title, String author, int pages,
4243
@VectorStoreRecordVector(dimensions = 4, distanceFunction = DistanceFunction.COSINE_DISTANCE, indexKind = IndexKind.HNSW)
4344
private final List<Float> summaryEmbedding;
4445

46+
public String getIsbn() {
47+
return isbn;
48+
}
49+
50+
public String getTitle() {
51+
return title;
52+
}
53+
54+
public String getAuthor() {
55+
return author;
56+
}
57+
58+
public int getPages() {
59+
return pages;
60+
}
61+
62+
public List<String> getTags() {
63+
return tags;
64+
}
65+
66+
public String getSummary() {
67+
return summary;
68+
}
69+
70+
public List<Float> getSummaryEmbedding() {
71+
return summaryEmbedding;
72+
}
4573
}

0 commit comments

Comments
 (0)