Skip to content

Commit 470f6c1

Browse files
author
Milder Hernandez Cagua
committed
Update VectorSearchFilter builder
1 parent c4cab96 commit 470f6c1

6 files changed

Lines changed: 14 additions & 17 deletions

File tree

api-test/integration-tests/src/test/java/com/microsoft/semantickernel/tests/connectors/memory/jdbc/JDBCVectorStoreRecordCollectionTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -406,7 +406,7 @@ public void searchWithFilter(QueryProvider provider, String embeddingName) {
406406
VectorSearchOptions options = VectorSearchOptions.builder()
407407
.withVectorFieldName(embeddingName)
408408
.withLimit(3)
409-
.withBasicVectorSearchFilter(
409+
.withVectorSearchFilter(
410410
VectorSearchFilter.builder().withEqualToFilterClause(new SQLEqualToFilterClause("rating", 4.0)).build())
411411
.build();
412412

semantickernel-experimental/src/main/java/com/microsoft/semantickernel/connectors/data/azureaisearch/AzureAISearchVectorStoreRecordCollection.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@
4141
import java.util.HashSet;
4242
import java.util.Iterator;
4343
import java.util.List;
44-
import java.util.Map;
4544
import java.util.stream.Collectors;
4645
import javax.annotation.Nonnull;
4746
import reactor.core.publisher.Flux;
@@ -337,7 +336,7 @@ public Mono<List<VectorSearchResult<Record>>> searchAsync(VectorSearchQuery quer
337336
}
338337

339338
String filter = AzureAISearchVectorStoreCollectionSearchMapping
340-
.buildFilterString(options.getBasicVectorSearchFilter(), recordDefinition);
339+
.buildFilterString(options.getVectorSearchFilter(), recordDefinition);
341340

342341
SearchOptions searchOptions = new SearchOptions()
343342
.setFilter(filter)

semantickernel-experimental/src/main/java/com/microsoft/semantickernel/connectors/data/jdbc/JDBCVectorStoreQueryProvider.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
import com.fasterxml.jackson.core.JsonProcessingException;
55
import com.fasterxml.jackson.databind.ObjectMapper;
66
import com.fasterxml.jackson.databind.node.ArrayNode;
7-
import com.microsoft.semantickernel.data.filter.FilterClause;
87
import com.microsoft.semantickernel.data.vectorsearch.VectorOperations;
98
import com.microsoft.semantickernel.data.vectorsearch.VectorSearchResult;
109
import com.microsoft.semantickernel.data.vectorsearch.queries.VectorSearchQuery;
@@ -19,7 +18,6 @@
1918
import com.microsoft.semantickernel.data.vectorstorage.options.DeleteRecordOptions;
2019
import com.microsoft.semantickernel.data.vectorstorage.options.GetRecordOptions;
2120
import com.microsoft.semantickernel.data.vectorstorage.options.UpsertRecordOptions;
22-
import com.microsoft.semantickernel.services.OrderedAIServiceSelector;
2321
import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
2422
import org.slf4j.Logger;
2523
import org.slf4j.LoggerFactory;
@@ -502,9 +500,9 @@ public <Record> List<VectorSearchResult<Record>> search(String collectionName,
502500
.getField(options.getVectorFieldName());
503501

504502
String filter = SQLVectorStoreRecordCollectionSearchMapping
505-
.buildFilter(options.getBasicVectorSearchFilter(), recordDefinition);
503+
.buildFilter(options.getVectorSearchFilter(), recordDefinition);
506504
List<Object> parameters = SQLVectorStoreRecordCollectionSearchMapping
507-
.getFilterParameters(options.getBasicVectorSearchFilter());
505+
.getFilterParameters(options.getVectorSearchFilter());
508506

509507
List<Record> records = getRecordsWithFilter(collectionName, recordDefinition, mapper,
510508
new GetRecordOptions(true), filter, parameters);

semantickernel-experimental/src/main/java/com/microsoft/semantickernel/connectors/data/postgres/PostgreSQLVectorStoreQueryProvider.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -371,10 +371,10 @@ public <Record> List<VectorSearchResult<Record>> search(String collectionName,
371371
}
372372

373373
String filter = SQLVectorStoreRecordCollectionSearchMapping.buildFilter(
374-
options.getBasicVectorSearchFilter(),
374+
options.getVectorSearchFilter(),
375375
recordDefinition);
376376
List<Object> parameters = SQLVectorStoreRecordCollectionSearchMapping
377-
.getFilterParameters(options.getBasicVectorSearchFilter());
377+
.getFilterParameters(options.getVectorSearchFilter());
378378

379379
String filterClause = filter.isEmpty() ? "" : "WHERE " + filter;
380380
String searchQuery = formatQuery(

semantickernel-experimental/src/main/java/com/microsoft/semantickernel/data/vectorsearch/VectorSearchFilter.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,9 @@
1212
public class VectorSearchFilter {
1313

1414
/**
15-
* Creates a new instance of the BasicVectorSearchFilter class.
15+
* Creates a new instance of the VectorSearchFilter class.
1616
*
17-
* @return A new instance of the BasicVectorSearchFilter class.
17+
* @return A new instance of the VectorSearchFilter class.
1818
*/
1919
public static VectorSearchFilter createDefault() {
2020
return new VectorSearchFilter();
@@ -23,11 +23,11 @@ public static VectorSearchFilter createDefault() {
2323
private final List<FilterClause> filterClauses;
2424

2525
public VectorSearchFilter() {
26-
this(new ArrayList<>());
26+
this(Collections.emptyList());
2727
}
2828

2929
/**
30-
* Creates a new instance of the BasicVectorSearchFilter class.
30+
* Creates a new instance of the VectorSearchFilter class.
3131
*
3232
* @param filterClauses The filter clauses.
3333
*/

semantickernel-experimental/src/main/java/com/microsoft/semantickernel/data/vectorstorage/options/VectorSearchOptions.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -39,12 +39,12 @@ public VectorSearchOptions(VectorSearchFilter vectorSearchFilter,
3939
}
4040

4141
/**
42-
* Gets the basic vector search filter.
42+
* Gets the vector search filter.
4343
*
44-
* @return The basic vector search filter.
44+
* @return The vector search filter.
4545
*/
4646
@Nullable
47-
public VectorSearchFilter getBasicVectorSearchFilter() {
47+
public VectorSearchFilter getVectorSearchFilter() {
4848
return vectorSearchFilter;
4949
}
5050

@@ -105,7 +105,7 @@ public Builder() {
105105
this.limit = DEFAULT_RESULT_LIMIT;
106106
}
107107

108-
public Builder withBasicVectorSearchFilter(
108+
public Builder withVectorSearchFilter(
109109
VectorSearchFilter vectorSearchFilter) {
110110
this.vectorSearchFilter = vectorSearchFilter;
111111
return this;

0 commit comments

Comments
 (0)