Skip to content

Commit 8d66e48

Browse files
author
Milder Hernandez Cagua
committed
Rename GetRecordOptions.isIncludeVectors
1 parent 7ef3600 commit 8d66e48

8 files changed

Lines changed: 12 additions & 17 deletions

File tree

semantickernel-experimental/src/main/java/com/microsoft/semantickernel/connectors/data/azureaisearch/AzureAISearchVectorStoreRecordCollection.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
import com.azure.search.documents.models.VectorizableTextQuery;
1616
import com.azure.search.documents.models.VectorizedQuery;
1717
import com.microsoft.semantickernel.data.vectorsearch.VectorizableSearch;
18-
import com.microsoft.semantickernel.data.vectorsearch.VectorSearch;
1918
import com.microsoft.semantickernel.data.vectorsearch.VectorSearchResult;
2019
import com.microsoft.semantickernel.data.vectorsearch.VectorizedSearch;
2120
import com.microsoft.semantickernel.data.vectorstorage.VectorStoreRecordCollection;
@@ -194,7 +193,7 @@ public Mono<Record> getAsync(
194193
@Nonnull String key, GetRecordOptions options) {
195194
// If vectors are not requested, only fetch non-vector fields
196195
List<String> selectedFields = null;
197-
if (options == null || !options.includeVectors()) {
196+
if (options == null || !options.isIncludeVectors()) {
198197
selectedFields = Collections.unmodifiableList(nonVectorFields);
199198
}
200199

semantickernel-experimental/src/main/java/com/microsoft/semantickernel/connectors/data/jdbc/JDBCVectorStoreQueryProvider.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -338,7 +338,7 @@ public <Record> List<Record> getRecords(String collectionName, List<String> keys
338338
VectorStoreRecordMapper<Record, ResultSet> mapper,
339339
GetRecordOptions options) {
340340
List<VectorStoreRecordField> fields;
341-
if (options != null && options.includeVectors()) {
341+
if (options != null && options.isIncludeVectors()) {
342342
fields = recordDefinition.getAllFields();
343343
} else {
344344
fields = recordDefinition.getNonVectorFields();

semantickernel-experimental/src/main/java/com/microsoft/semantickernel/connectors/data/jdbc/JDBCVectorStoreRecordMapper.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
import java.sql.ResultSet;
2020
import java.sql.SQLException;
2121
import java.util.function.BiFunction;
22-
import java.util.function.Function;
2322

2423
public class JDBCVectorStoreRecordMapper<Record>
2524
extends VectorStoreRecordMapper<Record, ResultSet> {
@@ -115,7 +114,7 @@ public JDBCVectorStoreRecordMapper<Record> build() {
115114
// Select fields from the record definition.
116115
List<VectorStoreRecordField> fields;
117116
ResultSetMetaData metaData = resultSet.getMetaData();
118-
if (options != null && options.includeVectors()) {
117+
if (options != null && options.isIncludeVectors()) {
119118
fields = vectorStoreRecordDefinition.getAllFields();
120119
} else {
121120
fields = vectorStoreRecordDefinition.getNonVectorFields();

semantickernel-experimental/src/main/java/com/microsoft/semantickernel/connectors/data/postgres/PostgreSQLVectorStoreRecordMapper.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,9 @@
1616
import org.postgresql.util.PGobject;
1717

1818
import java.sql.ResultSet;
19-
import java.sql.ResultSetMetaData;
2019
import java.sql.SQLException;
2120
import java.util.List;
2221
import java.util.function.BiFunction;
23-
import java.util.function.Function;
2422

2523
public class PostgreSQLVectorStoreRecordMapper<Record>
2624
extends VectorStoreRecordMapper<Record, ResultSet> {
@@ -107,7 +105,7 @@ public PostgreSQLVectorStoreRecordMapper<Record> build() {
107105

108106
// Select fields from the record definition.
109107
List<VectorStoreRecordField> fields;
110-
if (options != null && options.includeVectors()) {
108+
if (options != null && options.isIncludeVectors()) {
111109
fields = vectorStoreRecordDefinition.getAllFields();
112110
} else {
113111
fields = vectorStoreRecordDefinition.getNonVectorFields();

semantickernel-experimental/src/main/java/com/microsoft/semantickernel/connectors/data/redis/RedisHashSetVectorStoreRecordCollection.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -231,7 +231,7 @@ public Mono<List<Record>> getBatchAsync(List<String> keys,
231231
keys.forEach(key -> {
232232
String redisKey = getRedisKey(key, collectionName);
233233

234-
if (options != null && options.includeVectors()) {
234+
if (options != null && options.isIncludeVectors()) {
235235
// Returns Map<String, String> with the fields and values
236236
responses.add(new AbstractMap.SimpleEntry<>(key, pipeline.hgetAll(redisKey)));
237237
} else {
@@ -247,7 +247,7 @@ public Mono<List<Record>> getBatchAsync(List<String> keys,
247247
try {
248248
return Mono.just(responses.stream()
249249
.map(entry -> {
250-
if (options != null && options.includeVectors()) {
250+
if (options != null && options.isIncludeVectors()) {
251251
// Results directly in a Map<String, String>
252252
return this.vectorStoreRecordMapper
253253
.mapStorageModeltoRecord(

semantickernel-experimental/src/main/java/com/microsoft/semantickernel/connectors/data/redis/RedisHashSetVectorStoreRecordMapper.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
import java.util.Iterator;
2020
import java.util.Map;
2121
import java.util.Map.Entry;
22-
import java.util.Objects;
2322
import java.util.function.BiFunction;
2423
import java.util.function.Function;
2524

@@ -135,7 +134,7 @@ public RedisHashSetVectorStoreRecordMapper<Record> build() {
135134
storageModel.getValue().get(field.getEffectiveStorageName()));
136135
}
137136

138-
if (options != null && options.includeVectors()) {
137+
if (options != null && options.isIncludeVectors()) {
139138
for (VectorStoreRecordVectorField field : recordDefinition
140139
.getVectorFields()) {
141140
String value = storageModel.getValue()

semantickernel-experimental/src/main/java/com/microsoft/semantickernel/connectors/data/redis/RedisJsonVectorStoreRecordCollection.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -214,7 +214,7 @@ public Mono<Record> getAsync(String key, GetRecordOptions options) {
214214
return Mono.defer(() -> {
215215
try {
216216
Object value;
217-
if (options != null && options.includeVectors()) {
217+
if (options != null && options.isIncludeVectors()) {
218218
value = client.jsonGet(redisKey);
219219
} else {
220220
value = client.jsonGet(redisKey, dataFields);
@@ -225,7 +225,7 @@ public Mono<Record> getAsync(String key, GetRecordOptions options) {
225225
}
226226

227227
JsonNode jsonNode;
228-
if (options != null && options.includeVectors()) {
228+
if (options != null && options.isIncludeVectors()) {
229229
jsonNode = objectMapper.valueToTree(value);
230230
} else {
231231
// Remove the $. prefix from every key in the JSON object
@@ -255,7 +255,7 @@ public Mono<List<Record>> getBatchAsync(List<String> keys,
255255
keys.forEach(key -> {
256256
String redisKey = getRedisKey(key, collectionName);
257257

258-
if (options != null && options.includeVectors()) {
258+
if (options != null && options.isIncludeVectors()) {
259259
responses.add(new SimpleEntry<>(key, pipeline.jsonGet(redisKey)));
260260
} else {
261261
responses.add(new SimpleEntry<>(key, pipeline.jsonGet(redisKey, dataFields)));
@@ -274,7 +274,7 @@ public Mono<List<Record>> getBatchAsync(List<String> keys,
274274
}
275275

276276
JsonNode jsonNode;
277-
if (options != null && options.includeVectors()) {
277+
if (options != null && options.isIncludeVectors()) {
278278
jsonNode = objectMapper.valueToTree(value);
279279
} else {
280280
jsonNode = removeRedisPathPrefix((JSONObject) value);

semantickernel-experimental/src/main/java/com/microsoft/semantickernel/data/vectorstorage/options/GetRecordOptions.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ public GetRecordOptions build() {
5252
*
5353
* @return whether to include vectors
5454
*/
55-
public boolean includeVectors() {
55+
public boolean isIncludeVectors() {
5656
return includeVectors;
5757
}
5858
}

0 commit comments

Comments
 (0)