Fix null check

johnoliver · johnoliver · commit f879a77131d0 · 2026-04-22T16:53:55.000Z
diff --git a/semantickernel-api/src/main/java/com/microsoft/semantickernel/orchestration/PromptExecutionSettings.java b/semantickernel-api/src/main/java/com/microsoft/semantickernel/orchestration/PromptExecutionSettings.java
@@ -384,7 +384,10 @@ public boolean equals(Object obj) {
         if (Double.compare(frequencyPenalty, other.frequencyPenalty) != 0) {
             return false;
         }
-        if (maxTokens != other.maxTokens) {
+        if (!Objects.equals(maxTokens, other.maxTokens)) {
+            return false;
+        }
+        if (!Objects.equals(maxCompletionTokens, other.maxCompletionTokens)) {
             return false;
         }
         if (bestOf != other.bestOf) {

Original file line number	Diff line number	Diff line change
`@@ -384,7 +384,10 @@ public boolean equals(Object obj) {`
`384`	`384`	`if (Double.compare(frequencyPenalty, other.frequencyPenalty) != 0) {`
`385`	`385`	`return false;`
`386`	`386`	`}`
`387`		`- if (maxTokens != other.maxTokens) {`
	`387`	`+ if (!Objects.equals(maxTokens, other.maxTokens)) {`
	`388`	`+ return false;`
	`389`	`+ }`
	`390`	`+ if (!Objects.equals(maxCompletionTokens, other.maxCompletionTokens)) {`
`388`	`391`	`return false;`
`389`	`392`	`}`
`390`	`393`	`if (bestOf != other.bestOf) {`