Guide users to sign in from more extension entry points (#7615)

* Guide users to sign in from more extension entry points
Part of #7614

* Fix yarn.lock

* Fix tests

Author: alexr00

package.json

@@ -4089,7 +4089,7 @@
 		"@types/react-dom": "^16.8.2",
 		"@types/sinon": "7.0.11",
 		"@types/temp": "0.8.34",
-		"@types/vscode": "1.89.0",
+		"@types/vscode": "1.103.0",
 		"@types/webpack-env": "^1.16.0",
 		"@typescript-eslint/eslint-plugin": "6.10.0",
 		"@typescript-eslint/parser": "6.10.0",

src/@types/vscode.proposed.chatParticipantAdditions.d.ts

@@ -273,7 +273,7 @@ declare module 'vscode' {
 		*/
 		progress(value: string, task?: (progress: Progress<ChatResponseWarningPart | ChatResponseReferencePart>) => Thenable<string | void>): void;
 
-		thinkingProgress(value: string, id?: string, metadata?: string): void;
+		thinkingProgress(thinkingDelta: ThinkingDelta): void;
 
 		textEdit(target: Uri, edits: TextEdit | TextEdit[]): void;
 
@@ -327,6 +327,21 @@ declare module 'vscode' {
 		Omitted = 3
 	}
 
+	export type ThinkingDelta = {
+		text?: string;
+		id: string;
+		metadata?: string;
+	} | {
+		text?: string;
+		id?: string;
+		metadata: string;
+	} |
+	{
+		text: string;
+		id?: string;
+		metadata?: string;
+	};
+
 	export enum ChatResponseClearToPreviousToolInvocationReason {
 		NoReason = 0,
 		FilteredContentRetry = 1,
@@ -553,6 +568,8 @@ declare module 'vscode' {
 		kind: 'chatEditingHunkAction';
 		uri: Uri;
 		lineCount: number;
+		linesAdded: number;
+		linesRemoved: number;
 		outcome: ChatEditingSessionActionOutcome;
 		hasRemainingEdits: boolean;
 	}

src/@types/vscode.proposed.chatParticipantPrivate.d.ts

@@ -3,7 +3,7 @@
  *  Licensed under the MIT License. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
 
-// version: 9
+// version: 10
 
 declare module 'vscode' {
 

src/commands.ts

@@ -30,6 +30,7 @@ import { NotificationProvider } from './github/notifications';
 import { GHPRComment, GHPRCommentThread, TemporaryComment } from './github/prComment';
 import { PullRequestModel } from './github/pullRequestModel';
 import { PullRequestOverviewPanel } from './github/pullRequestOverview';
+import { chooseItem } from './github/quickPicks';
 import { RepositoriesManager } from './github/repositoriesManager';
 import { getIssuesUrl, getPullsUrl, isInCodespaces, ISSUE_OR_URL_EXPRESSION, parseIssueExpressionOutput, vscodeDevPrLink } from './github/utils';
 import { CodingAgentContext, OverviewContext } from './github/views';
@@ -173,26 +174,6 @@ export async function openDescription(
 
 }
 
-async function chooseItem<T>(
-	activePullRequests: T[],
-	propertyGetter: (itemValue: T) => string,
-	options?: vscode.QuickPickOptions,
-): Promise<T | undefined> {
-	if (activePullRequests.length === 1) {
-		return activePullRequests[0];
-	}
-	interface Item extends vscode.QuickPickItem {
-		itemValue: T;
-	}
-	const items: Item[] = activePullRequests.map(currentItem => {
-		return {
-			label: propertyGetter(currentItem),
-			itemValue: currentItem,
-		};
-	});
-	return (await vscode.window.showQuickPick(items, options))?.itemValue;
-}
-
 export async function openPullRequestOnGitHub(e: PRNode | RepositoryChangesNode | IssueModel | NotificationTreeItem, telemetry: ITelemetry) {
 	if (e instanceof PRNode || e instanceof RepositoryChangesNode) {
 		vscode.commands.executeCommand('vscode.open', vscode.Uri.parse(e.pullRequestModel.html_url));

src/extension.ts

@@ -393,8 +393,7 @@ async function deferredActivate(context: vscode.ExtensionContext, showPRControll
 	const experimentationService = await createExperimentationService(context, telemetry);
 	await experimentationService.initializePromise;
 	await experimentationService.isCachedFlightEnabled('githubaa');
-	const showBadge = (vscode.env.appHost === 'desktop');
-	await credentialStore.create(showBadge ? undefined : { silent: true });
+	await credentialStore.create();
 
 	const reposManager = new RepositoriesManager(credentialStore, telemetry);
 	context.subscriptions.push(reposManager);

src/github/copilotRemoteAgent.ts

@@ -3,7 +3,7 @@
  *  Licensed under the MIT License. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
 
-import * as nodePath from 'path';
+import * as pathLib from 'path';
 import vscode from 'vscode';
 import { parseSessionLogs, parseToolCallDetails } from '../../common/sessionParsing';
 import { COPILOT_ACCOUNTS } from '../common/comment';
@@ -24,11 +24,12 @@ import { CopilotPRWatcher, CopilotStateModel } from './copilotPrWatcher';
 import { ChatSessionContentBuilder } from './copilotRemoteAgent/chatSessionContentBuilder';
 import { GitOperationsManager } from './copilotRemoteAgent/gitOperationsManager';
 import { CredentialStore } from './credentials';
-import { ReposManagerState } from './folderRepositoryManager';
+import { FolderRepositoryManager, ReposManagerState } from './folderRepositoryManager';
 import { GitHubRepository } from './githubRepository';
 import { GithubItemStateEnum } from './interface';
 import { issueMarkdown } from './markdownUtils';
 import { PullRequestModel } from './pullRequestModel';
+import { chooseItem } from './quickPicks';
 import { RepositoriesManager } from './repositoriesManager';
 
 const LEARN_MORE = vscode.l10n.t('Learn about coding agent');
@@ -166,6 +167,11 @@ export class CopilotRemoteAgentManager extends Disposable {
 			return false;
 		}
 
+		if (!this.credentialStore.isAnyAuthenticated()) {
+			// If not signed in, then we optimistically say it's available.
+			return true;
+		}
+
 		const repoInfo = await this.repoInfo();
 		if (!repoInfo) {
 			return false;
@@ -189,14 +195,18 @@ export class CopilotRemoteAgentManager extends Disposable {
 		}
 	}
 
-	async repoInfo(): Promise<RepoInfo | undefined> {
-		if (!this.repositoriesManager.folderManagers.length) {
-			return;
-		}
-		const fm = this.repositoriesManager.folderManagers[0];
+	private chooseFolderManager(): Promise<FolderRepositoryManager | undefined> {
+		return chooseItem<FolderRepositoryManager>(
+			this.repositoriesManager.folderManagers,
+			itemValue => pathLib.basename(itemValue.repository.rootUri.fsPath),
+		);
+	}
+
+	async repoInfo(fm?: FolderRepositoryManager): Promise<RepoInfo | undefined> {
+		fm = fm || (await this.chooseFolderManager());
 		const repository = fm?.repository;
 		const ghRepository = fm?.gitHubRepositories.find(repo => repo.remote instanceof GitHubRemote) as GitHubRepository | undefined;
-		if (!repository || !ghRepository) {
+		if (!fm || !repository || !ghRepository) {
 			return;
 		}
 
@@ -246,11 +256,37 @@ export class CopilotRemoteAgentManager extends Disposable {
 		}
 	}
 
+	private async tryAcquireAuth(): Promise<FolderRepositoryManager | undefined> {
+		if (this.credentialStore.isAnyAuthenticated()) {
+			return undefined;
+		}
+
+		const result = await this.credentialStore.create({ createIfNone: { detail: vscode.l10n.t('Sign in to start delegating tasks to the GitHub coding agent.') } });
+
+		/* __GDPR__
+			"remoteAgent.command.auth" : {
+				"succeeded" : { "classification": "SystemMetaData", "purpose": "FeatureInsight" }
+			}
+		*/
+		this.telemetry.sendTelemetryEvent('remoteAgent.command.auth', {
+			succeeded: result.canceled ? 'false' : 'true'
+		});
+
+		if (result.canceled) {
+			return undefined;
+		}
+		// Wait for repos to update
+		const fm = await this.chooseFolderManager();
+		await fm?.updateRepositories();
+		return fm;
+	}
+
 	async commandImpl(args?: ICopilotRemoteAgentCommandArgs): Promise<string | ICopilotRemoteAgentCommandResponse | undefined> {
 		if (!args) {
 			return;
 		}
 		const { userPrompt, summary, source, followup, _version } = args;
+		const fm = await this.tryAcquireAuth();
 
 		/* __GDPR__
 			"remoteAgent.command.args" : {
@@ -273,7 +309,7 @@ export class CopilotRemoteAgentManager extends Disposable {
 			return;
 		}
 
-		const repoInfo = await this.repoInfo();
+		const repoInfo = await this.repoInfo(fm);
 		if (!repoInfo) {
 			/* __GDPR__
 				"remoteAgent.command.result" : {
@@ -1062,7 +1098,7 @@ export class CopilotRemoteAgentManager extends Disposable {
 			if (toolDetails.toolSpecificData) {
 				if ('command' in toolDetails.toolSpecificData) {
 					if ((toolDetails.toolSpecificData.command === 'view' || toolDetails.toolSpecificData.command === 'edit') && toolDetails.toolSpecificData.fileLabel) {
-						const uri = vscode.Uri.file(nodePath.join(pullRequest.githubRepository.rootUri.fsPath, toolDetails.toolSpecificData.fileLabel));
+						const uri = vscode.Uri.file(pathLib.join(pullRequest.githubRepository.rootUri.fsPath, toolDetails.toolSpecificData.fileLabel));
 						toolPart.invocationMessage = new vscode.MarkdownString(`${toolPart.toolName} [](${uri.toString()})`);
 						toolPart.invocationMessage.supportHtml = true;
 						toolPart.pastTenseMessage = new vscode.MarkdownString(`${toolPart.toolName} [](${uri.toString()})`);

src/github/quickPicks.ts

@@ -18,6 +18,29 @@ import { AccountType, IAccount, ILabel, IMilestone, IProject, isISuggestedReview
 import { IssueModel } from './issueModel';
 import { DisplayLabel } from './views';
 
+export async function chooseItem<T>(
+	itemsToChooseFrom: T[],
+	propertyGetter: (itemValue: T) => string,
+	options?: vscode.QuickPickOptions,
+): Promise<T | undefined> {
+	if (itemsToChooseFrom.length === 0) {
+		return undefined;
+	}
+	if (itemsToChooseFrom.length === 1) {
+		return itemsToChooseFrom[0];
+	}
+	interface Item extends vscode.QuickPickItem {
+		itemValue: T;
+	}
+	const items: Item[] = itemsToChooseFrom.map(currentItem => {
+		return {
+			label: propertyGetter(currentItem),
+			itemValue: currentItem,
+		};
+	});
+	return (await vscode.window.showQuickPick(items, options))?.itemValue;
+}
+
 async function getItems<T extends IAccount | ITeam | ISuggestedReviewer>(context: vscode.ExtensionContext, skipList: Set<string>, users: T[], picked: boolean, tooManyAssignable: boolean = false): Promise<(vscode.QuickPickItem & { user?: T })[]> {
 	const alreadyAssignedItems: (vscode.QuickPickItem & { user?: T })[] = [];
 	// Address skip list before first await

src/view/treeNodes/categoryNode.ts

@@ -32,7 +32,7 @@ export enum PRCategoryActionType {
 
 export class PRCategoryActionNode extends TreeNode implements vscode.TreeItem {
 	public collapsibleState: vscode.TreeItemCollapsibleState;
-	public iconPath?: { light: string | vscode.Uri; dark: string | vscode.Uri };
+	public iconPath?: { light: vscode.Uri; dark: vscode.Uri };
 	public type: PRCategoryActionType;
 	public command?: vscode.Command;
 

src/view/treeNodes/fileChangeNode.ts

@@ -68,7 +68,7 @@ export class FileChangeNode extends TreeNode implements vscode.TreeItem {
 	public iconPath?:
 		| string
 		| vscode.Uri
-		| { light: string | vscode.Uri; dark: string | vscode.Uri }
+		| { light: vscode.Uri; dark: vscode.Uri }
 		| vscode.ThemeIcon;
 	public fileChangeResourceUri: vscode.Uri;
 	public contextValue: string;

src/view/treeNodes/pullRequestNode.ts

@@ -265,7 +265,7 @@ export class PRNode extends TreeNode implements vscode.CommentingRangeProvider2
 		});
 	}
 
-	private async _getIcon(): Promise<vscode.Uri | vscode.ThemeIcon | { light: string | vscode.Uri; dark: string | vscode.Uri }> {
+	private async _getIcon(): Promise<vscode.Uri | vscode.ThemeIcon | { light: vscode.Uri; dark: vscode.Uri }> {
 		const copilotWorkingStatus = await this.pullRequestModel.copilotWorkingStatus(this.pullRequestModel);
 		const theme = this._folderReposManager.themeWatcher.themeData;
 		if (!theme || copilotWorkingStatus === CopilotWorkingStatus.NotCopilotIssue) {