Fix issues tree view stuck empty until git commit (#8638)

* Initial plan

* Fix race condition in issues tree view where getIssues errors prevent tree refresh

The issues tree view could get permanently stuck empty because:
1. `setIssues()` used the `new Promise(async executor)` anti-pattern and only
   fired `_onDidChangeIssueData` on success. If `getIssues()` threw (e.g. due
   to a transient network error), the promise rejected silently, the event
   never fired, and the tree never learned to refresh.
2. `setIssueData()` didn't fire `_onDidChangeIssueData` after processing all
   queries, so if all queries failed, the tree stayed permanently empty until
   a git commit triggered a new `setIssueData` call.

Fix:
- Refactor `setIssues()` to use async/await properly, catch errors gracefully
  (resolving with undefined instead of rejecting), and fire the change event
  in a `finally` block so it always fires.
- Fire `_onDidChangeIssueData` at the end of `setIssueData()` to guarantee
  the tree always gets a refresh signal after data loading completes.

Agent-Logs-Url: https://github.com/microsoft/vscode-pull-request-github/sessions/42a1cce0-564c-42dd-afc9-909f2730d385

Co-authored-by: alexr00 <38270282+alexr00@users.noreply.github.com>

* Address review feedback: add comment to catch block, tighten test assertion

Agent-Logs-Url: https://github.com/microsoft/vscode-pull-request-github/sessions/42a1cce0-564c-42dd-afc9-909f2730d385

Co-authored-by: alexr00 <38270282+alexr00@users.noreply.github.com>

* Remove "just in case" event firing

* Fix test

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: alexr00 <38270282+alexr00@users.noreply.github.com>

Author: Copilot

src/issues/stateManager.ts

@@ -347,18 +347,21 @@ export class StateManager {
 		singleRepoState.lastBranch = folderManager.repository.state.HEAD?.name;
 	}
 
-	private setIssues(folderManager: FolderRepositoryManager, query: string): Promise<IssueItem[] | undefined> {
-		return new Promise(async resolve => {
+	private async setIssues(folderManager: FolderRepositoryManager, query: string): Promise<IssueItem[] | undefined> {
+		try {
 			const issues = await folderManager.getIssues(query, { fetchNextPage: false, fetchOnePagePerRepo: true });
+			return issues?.items.map(item => {
+				const issueItem: IssueItem = item as IssueItem;
+				issueItem.uri = folderManager.repository.rootUri;
+				return issueItem;
+			});
+		} catch {
+			// Errors from fetching issues are expected (e.g. network failures).
+			// Return undefined so the tree shows an empty state for this query.
+			return undefined;
+		} finally {
 			this._onDidChangeIssueData.fire();
-			resolve(
-				issues?.items.map(item => {
-					const issueItem: IssueItem = item as IssueItem;
-					issueItem.uri = folderManager.repository.rootUri;
-					return issueItem;
-				}),
-			);
-		});
+		}
 	}
 
 	private async setCurrentIssueFromBranch(singleRepoState: SingleRepoState, branchName: string, silent: boolean = false) {

src/test/issues/stateManager.test.ts

@@ -169,4 +169,99 @@ describe('StateManager branch behavior with useBranchForIssues setting', functio
 			vscode.workspace.getConfiguration = originalGetConfiguration;
 		}
 	});
+
+	it('should fire onDidChangeIssueData even when getIssues throws', async function () {
+		const mockUri = vscode.Uri.parse('file:///test');
+		const mockFolderManager = {
+			repository: { rootUri: mockUri, state: { HEAD: { commit: 'abc123' }, remotes: [] } },
+			getIssues: async () => {
+				throw new Error('Network error');
+			},
+			getMaxIssue: async () => 0,
+		};
+
+		const originalGetConfiguration = vscode.workspace.getConfiguration;
+		vscode.workspace.getConfiguration = (section?: string) => {
+			if (section === ISSUES_SETTINGS_NAMESPACE) {
+				return {
+					get: (key: string, defaultValue?: any) => {
+						if (key === 'queries') {
+							return [{ label: 'Test', query: 'is:open assignee:@me repo:owner/repo', groupBy: [] }];
+						}
+						return defaultValue;
+					},
+				} as any;
+			}
+			return originalGetConfiguration(section);
+		};
+
+		try {
+			const sm = new StateManager(undefined as any, {
+				folderManagers: [mockFolderManager],
+				credentialStore: { isAnyAuthenticated: () => true, getCurrentUser: async () => ({ login: 'testuser' }) },
+			} as any, mockContext);
+
+			(sm as any)._queries = [{ label: 'Test', query: 'is:open assignee:@me repo:owner/repo', groupBy: [] }];
+
+			let changeEventCount = 0;
+			sm.onDidChangeIssueData(() => changeEventCount++);
+
+			await (sm as any).setIssueData(mockFolderManager);
+
+			// setIssueData doesn't await setIssues - await the collection promises so the finally block fires
+			const collection = sm.getIssueCollection(mockUri);
+			const queryResult = await collection.get('Test');
+
+			// The event should have fired even though getIssues threw
+			assert.ok(changeEventCount > 0, 'onDidChangeIssueData should fire even when getIssues fails');
+			assert.strictEqual(queryResult?.issues, undefined, 'Issues should be undefined when getIssues fails');
+		} finally {
+			vscode.workspace.getConfiguration = originalGetConfiguration;
+		}
+	});
+
+	it('should not reject promises in issueCollection when getIssues throws', async function () {
+		const mockUri = vscode.Uri.parse('file:///test');
+		const mockFolderManager = {
+			repository: { rootUri: mockUri, state: { HEAD: { commit: 'abc123' }, remotes: [] } },
+			getIssues: async () => {
+				throw new Error('API error');
+			},
+			getMaxIssue: async () => 0,
+		};
+
+		const originalGetConfiguration = vscode.workspace.getConfiguration;
+		vscode.workspace.getConfiguration = (section?: string) => {
+			if (section === ISSUES_SETTINGS_NAMESPACE) {
+				return {
+					get: (key: string, defaultValue?: any) => {
+						if (key === 'queries') {
+							return [{ label: 'Test', query: 'is:open repo:owner/repo', groupBy: [] }];
+						}
+						return defaultValue;
+					},
+				} as any;
+			}
+			return originalGetConfiguration(section);
+		};
+
+		try {
+			const sm = new StateManager(undefined as any, {
+				folderManagers: [mockFolderManager],
+				credentialStore: { isAnyAuthenticated: () => true, getCurrentUser: async () => ({ login: 'testuser' }) },
+			} as any, mockContext);
+
+			await (sm as any).setIssueData(mockFolderManager);
+
+			// Verify that the promises in issueCollection resolve (not reject)
+			const collection = sm.getIssueCollection(mockUri);
+			for (const [, promise] of collection) {
+				const result = await promise;
+				assert.ok(result !== undefined, 'Promise should resolve, not reject');
+				assert.strictEqual(result.issues, undefined, 'Issues should be undefined on error');
+			}
+		} finally {
+			vscode.workspace.getConfiguration = originalGetConfiguration;
+		}
+	});
 });