Skip to content

Commit 866c62b

Browse files
authored
Non GitHub remotes for submodules causes authentication to fail (#6562)
Fixes #6140
1 parent 746aa2a commit 866c62b

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

src/view/prsTreeDataProvider.ts

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -235,23 +235,24 @@ export class PullRequestsTreeDataProvider extends Disposable implements vscode.T
235235
return this.needsRemotes();
236236
}
237237

238+
const gitHubFolderManagers = this._reposManager.folderManagers.filter(manager => manager.gitHubRepositories.length > 0);
238239
if (!element) {
239240
if (this._children && this._children.length) {
240241
this._children.forEach(dispose => dispose.dispose());
241242
}
242243

243244
let result: WorkspaceFolderNode[] | CategoryTreeNode[];
244-
if (this._reposManager.folderManagers.length === 1) {
245+
if (gitHubFolderManagers.length === 1) {
245246
result = WorkspaceFolderNode.getCategoryTreeNodes(
246-
this._reposManager.folderManagers[0],
247+
gitHubFolderManagers[0],
247248
this._telemetry,
248249
this,
249250
this.notificationProvider,
250251
this._context,
251252
this.prsTreeModel
252253
);
253254
} else {
254-
result = this._reposManager.folderManagers.map(
255+
result = gitHubFolderManagers.map(
255256
folderManager =>
256257
new WorkspaceFolderNode(
257258
this,
@@ -270,7 +271,7 @@ export class PullRequestsTreeDataProvider extends Disposable implements vscode.T
270271
}
271272

272273
if (
273-
this._reposManager.folderManagers.filter(manager => manager.repository.state.remotes.length > 0).length === 0
274+
gitHubFolderManagers.filter(manager => manager.repository.state.remotes.length > 0).length === 0
274275
) {
275276
return Promise.resolve([new PRCategoryActionNode(this, PRCategoryActionType.Empty)]);
276277
}

src/view/treeNodes/repositoryChangesNode.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ export class RepositoryChangesNode extends DescriptionNode implements vscode.Tre
2222
public description?: string;
2323
readonly collapsibleState = vscode.TreeItemCollapsibleState.Expanded;
2424

25-
2625
constructor(
2726
public override parent: BaseTreeNode,
2827
pullRequest: PullRequestModel,

0 commit comments

Comments
 (0)