Skip to content

Commit 9c5a98e

Browse files
Copilotalexr00
andcommitted
Remove vscode.dev link option from issue overview context menu
Co-authored-by: alexr00 <38270282+alexr00@users.noreply.github.com>
1 parent 811506f commit 9c5a98e

2 files changed

Lines changed: 6 additions & 10 deletions

File tree

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3556,7 +3556,7 @@
35563556
},
35573557
{
35583558
"command": "pr.copyVscodeDevPrLink",
3559-
"when": "(webviewId == PullRequestOverview || webviewId == IssueOverview) && github:copyMenu"
3559+
"when": "webviewId == PullRequestOverview && github:copyMenu"
35603560
},
35613561
{
35623562
"command": "pr.readyForReviewDescription",

src/commands.ts

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1565,25 +1565,21 @@ ${contents}
15651565

15661566
context.subscriptions.push(
15671567
vscode.commands.registerCommand('pr.copyVscodeDevPrLink', async (params: OverviewContext | undefined) => {
1568-
let item: PullRequestModel | IssueModel | undefined;
1568+
let pr: PullRequestModel | undefined;
15691569
if (params) {
1570-
const folderManager = reposManager.getManagerForRepository(params.owner, params.repo);
1571-
item = await folderManager?.resolvePullRequest(params.owner, params.repo, params.number, true);
1572-
if (!item) {
1573-
item = await folderManager?.resolveIssue(params.owner, params.repo, params.number);
1574-
}
1570+
pr = await reposManager.getManagerForRepository(params.owner, params.repo)?.resolvePullRequest(params.owner, params.repo, params.number, true);
15751571
} else {
15761572
const activePullRequests: PullRequestModel[] = reposManager.folderManagers
15771573
.map(folderManager => folderManager.activePullRequest!)
15781574
.filter(activePR => !!activePR);
1579-
item = await chooseItem<PullRequestModel>(
1575+
pr = await chooseItem<PullRequestModel>(
15801576
activePullRequests,
15811577
itemValue => ({ label: `${itemValue.number}: ${itemValue.title}` }),
15821578
{ placeHolder: vscode.l10n.t('Pull request to create a link for') },
15831579
);
15841580
}
1585-
if (item) {
1586-
return vscode.env.clipboard.writeText(vscodeDevPrLink(item));
1581+
if (pr) {
1582+
return vscode.env.clipboard.writeText(vscodeDevPrLink(pr));
15871583
}
15881584
}));
15891585

0 commit comments

Comments
 (0)