Skip to content

Commit a19b440

Browse files
authored
Fix completing review from the webview view (#6947)
1 parent 1f4d69f commit a19b440

2 files changed

Lines changed: 7 additions & 6 deletions

File tree

src/github/activityBarViewProvider.ts

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ import { PullRequestModel } from './pullRequestModel';
1717
import { getDefaultMergeMethod } from './pullRequestOverview';
1818
import { PullRequestView } from './pullRequestOverviewCommon';
1919
import { isInCodespaces, parseReviewers } from './utils';
20-
import { MergeArguments, PullRequest, ReviewType } from './views';
20+
import { MergeArguments, PullRequest, ReviewType, SubmitReviewReply } from './views';
2121

2222
export class PullRequestViewProvider extends WebviewViewBase implements vscode.WebviewViewProvider {
2323
public override readonly viewType = 'github:activePullRequest';
@@ -362,7 +362,7 @@ export class PullRequestViewProvider extends WebviewViewBase implements vscode.W
362362
try {
363363
const review = await action(context.body);
364364
this.updateReviewers(review);
365-
const reviewMessage = {
365+
const reviewMessage: SubmitReviewReply & { command: string } = {
366366
command: 'pr.append-review',
367367
event: review,
368368
reviewers: this._existingReviewers
@@ -379,10 +379,11 @@ export class PullRequestViewProvider extends WebviewViewBase implements vscode.W
379379
try {
380380
const review = await action(message.args);
381381
this.updateReviewers(review);
382-
this._replyMessage(message, {
383-
review: review,
382+
const reviewMessage: SubmitReviewReply = {
383+
event: review,
384384
reviewers: this._existingReviewers,
385-
});
385+
};
386+
this._replyMessage(message, reviewMessage);
386387
} catch (e) {
387388
vscode.window.showErrorMessage(vscode.l10n.t('Submitting review failed. {0}', formatError(e)));
388389
this._throwError(message, `${formatError(e)}`);

src/github/pullRequestOverview.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -574,7 +574,7 @@ export class PullRequestOverviewPanel extends IssueOverviewPanel<PullRequestMode
574574
try {
575575
const review = await action(context.body);
576576
this.updateReviewers(review);
577-
const reviewMessage = {
577+
const reviewMessage: SubmitReviewReply & { command: string } = {
578578
command: 'pr.append-review',
579579
event: review,
580580
reviewers: this._existingReviewers

0 commit comments

Comments
 (0)