Skip to content

Commit dba37b2

Browse files
Copilotalexr00
andcommitted
Conditionally use href for commit links when PR not checked out
Co-authored-by: alexr00 <38270282+alexr00@users.noreply.github.com>
1 parent 1f793fd commit dba37b2

1 file changed

Lines changed: 20 additions & 4 deletions

File tree

webviews/components/timeline.tsx

Lines changed: 20 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -107,10 +107,14 @@ export default Timeline;
107107

108108
const CommitEventView = (event: CommitEvent) => {
109109
const context = useContext(PullRequestContext);
110+
const pr = context.pr;
110111

111112
const handleCommitClick = (e: React.MouseEvent) => {
112-
e.preventDefault();
113-
context.openCommitChanges(event.sha);
113+
if (pr.isCurrentlyCheckedOut) {
114+
e.preventDefault();
115+
context.openCommitChanges(event.sha);
116+
}
117+
// If not checked out, let the default href behavior proceed
114118
};
115119

116120
return (
@@ -122,13 +126,25 @@ const CommitEventView = (event: CommitEvent) => {
122126
<Avatar for={event.author} />
123127
</div>
124128
<div className="message-container">
125-
<a className="message" onClick={handleCommitClick} style={{ cursor: 'pointer' }} title={event.htmlUrl}>
129+
<a
130+
className="message"
131+
onClick={handleCommitClick}
132+
href={pr.isCurrentlyCheckedOut ? undefined : event.htmlUrl}
133+
style={{ cursor: 'pointer' }}
134+
title={event.htmlUrl}
135+
>
126136
{event.message.substr(0, event.message.indexOf('\n') > -1 ? event.message.indexOf('\n') : event.message.length)}
127137
</a>
128138
</div>
129139
</div>
130140
<div className="timeline-detail">
131-
<a className="sha" onClick={handleCommitClick} style={{ cursor: 'pointer' }} title={event.htmlUrl}>
141+
<a
142+
className="sha"
143+
onClick={handleCommitClick}
144+
href={pr.isCurrentlyCheckedOut ? undefined : event.htmlUrl}
145+
style={{ cursor: 'pointer' }}
146+
title={event.htmlUrl}
147+
>
132148
{event.sha.slice(0, 7)}
133149
</a>
134150
<Timestamp date={event.committedDate} />

0 commit comments

Comments
 (0)