Remove some anys, add a rule disallowing some anys, and use a const string for swe agent (#7533)

Author: alexr00

.eslintrc.js

@@ -24,6 +24,12 @@ module.exports = {
 			rules: {
 				'rulesdir/public-methods-well-defined-types': 'error'
 			}
+		},
+		{
+			files: ['**/*.ts', '**/*.tsx'],
+			rules: {
+				'rulesdir/no-any-except-union-method-signature': 'error'
+			}
 		}
 	]
 };

.vscode/settings.json

@@ -4,6 +4,14 @@
 		".eslintrc.json": "jsonc",
 		".eslintrc.*.json": "jsonc"
 	},
+	"json.schemas": [
+		{
+			"fileMatch": [
+				"**/.eslintrc.*.json"
+			],
+			"url": "https://json.schemastore.org/eslintrc"
+		}
+	],
 	"files.trimTrailingWhitespace": true,
 	"gitlens.advanced.blame.customArguments": ["--ignore-revs-file", ".gitignore-revs"]
 }

build/eslint-rules/index.js

@@ -7,4 +7,5 @@
 
 module.exports = {
 	'public-methods-well-defined-types': require('./public-methods-well-defined-types'),
+	'no-any-except-union-method-signature': require('./no-any-except-union-method-signature'),
 };

build/eslint-rules/no-any-except-union-method-signature.js

@@ -0,0 +1,66 @@
+/*---------------------------------------------------------------------------------------------
+ *  Copyright (c) Microsoft Corporation. All rights reserved.
+ *  Licensed under the MIT License. See License.txt in the project root for license information.
+ *--------------------------------------------------------------------------------------------*/
+
+'use strict';
+
+module.exports = {
+	meta: {
+		type: 'suggestion',
+		docs: {
+			description: 'Disallow the use of any except in union types within method signatures',
+			category: 'Best Practices',
+			recommended: true,
+		},
+		fixable: null,
+		schema: [],
+		messages: {
+			unexpectedAny: 'Unexpected any. Use a more specific type instead.',
+		},
+	},
+
+	create(context) {
+		return {
+			// Target the 'any' type annotation
+			TSAnyKeyword(node) {
+				// Get the parent nodes to determine context
+				const parent = node.parent;
+
+				if (parent) {
+					// Check if this type is part of a method signature
+					let currentNode = parent;
+					let isMethodSignature = false;
+
+					while (currentNode) {
+						// Check if we're in a method signature or function type
+						if (
+							currentNode.type === 'TSMethodSignature' ||
+							currentNode.type === 'TSFunctionType' ||
+							currentNode.type === 'FunctionDeclaration' ||
+							currentNode.type === 'FunctionExpression' ||
+							currentNode.type === 'ArrowFunctionExpression' ||
+							currentNode.type === 'MethodDefinition'
+						) {
+							isMethodSignature = true;
+							break;
+						}
+
+						currentNode = currentNode.parent;
+					}
+
+					// If it's part of a method signature, it's allowed
+					if (isMethodSignature) {
+						return;
+					}
+				}
+
+				// Report any other use of 'any'
+				context.report({
+					node,
+					messageId: 'unexpectedAny',
+				});
+			}
+		};
+	}
+};

common/sessionParsing.ts

@@ -5,10 +5,10 @@
 
 export interface SessionResponseLogChunk {
 	choices: Array<{
-		finish_reason: string;
+		finish_reason?: 'tool_calls' | 'null' | (string & {});
 		delta: {
 			content?: string;
-			role: string;
+			role: 'assistant' | (string & {});
 			tool_calls?: Array<{
 				function: {
 					arguments: string;
@@ -37,7 +37,7 @@ export interface SessionResponseLogChunk {
 export interface ParsedToolCall {
 	type: 'str_replace_editor' | 'think' | 'bash' | 'report_progress' | 'unknown';
 	name: string;
-	args: any;
+	// args: any;
 	content: string;
 	command?: string; // For str_replace_editor
 }
@@ -127,7 +127,7 @@ export function parseToolCallDetails(
 	},
 	content: string
 ): ParsedToolCallDetails {
-	let args: any = {};
+	let args: { command?: string, path?: string, prDescription?: string, commitMessage?: string } = {};
 	try {
 		args = toolCall.function.arguments ? JSON.parse(toolCall.function.arguments) : {};
 	} catch {

src/@types/vscode.proposed.chatParticipantAdditions.d.ts

@@ -149,7 +149,7 @@ declare module 'vscode' {
 		constructor(value: ChatResponseDiffEntry[], title: string);
 	}
 
-	export type ExtendedChatResponsePart = ChatResponsePart | ChatResponseTextEditPart | ChatResponseNotebookEditPart | ChatResponseConfirmationPart | ChatResponseCodeCitationPart | ChatResponseReferencePart2 | ChatResponseMovePart | ChatResponseExtensionsPart | ChatResponsePullRequestPart | ChatPrepareToolInvocationPart | ChatToolInvocationPart | ChatResponseMultiDiffPart;
+	export type ExtendedChatResponsePart = ChatResponsePart | ChatResponseTextEditPart | ChatResponseNotebookEditPart | ChatResponseConfirmationPart | ChatResponseCodeCitationPart | ChatResponseReferencePart2 | ChatResponseMovePart | ChatResponseExtensionsPart | ChatResponsePullRequestPart | ChatPrepareToolInvocationPart | ChatToolInvocationPart | ChatResponseMultiDiffPart | ChatResponseThinkingProgressPart;
 	export class ChatResponseWarningPart {
 		value: MarkdownString;
 		constructor(value: string | MarkdownString);
@@ -161,6 +161,23 @@ declare module 'vscode' {
 		constructor(value: string, task?: (progress: Progress<ChatResponseWarningPart | ChatResponseReferencePart>) => Thenable<string | void>);
 	}
 
+	/**
+	 * A specialized progress part for displaying thinking/reasoning steps.
+	 */
+	export class ChatResponseThinkingProgressPart extends ChatResponseProgressPart {
+		value: string;
+		id?: string;
+		metadata?: string;
+		task?: (progress: Progress<LanguageModelThinkingPart>) => Thenable<string | void>;
+
+		/**
+		 * Creates a new thinking progress part.
+		 * @param value An initial progress message
+		 * @param task A task that will emit thinking parts during its execution
+		 */
+		constructor(value: string, id?: string, metadata?: string, task?: (progress: Progress<LanguageModelThinkingPart>) => Thenable<string | void>);
+	}
+
 	export class ChatResponseReferencePart2 {
 		/**
 		 * The reference target.
@@ -256,6 +273,8 @@ declare module 'vscode' {
 		*/
 		progress(value: string, task?: (progress: Progress<ChatResponseWarningPart | ChatResponseReferencePart>) => Thenable<string | void>): void;
 
+		thinkingProgress(value: string, id?: string, metadata?: string): void;
+
 		textEdit(target: Uri, edits: TextEdit | TextEdit[]): void;
 
 		textEdit(target: Uri, isDone: true): void;

src/common/copilot.ts

@@ -5,9 +5,11 @@
 
 import { EventType, TimelineEvent } from './timelineEvent';
 
+export const COPILOT_SWE_AGENT = 'copilot-swe-agent';
+
 export const COPILOT_LOGINS = [
 	'copilot-pull-request-reviewer',
-	'copilot-swe-agent',
+	COPILOT_SWE_AGENT,
 	'Copilot'
 ];
 

src/common/resources.ts

@@ -7,7 +7,18 @@ import * as path from 'path';
 import * as vscode from 'vscode';
 
 export class Resource {
-	static icons: any;
+	static icons: {
+		reactions: {
+			THUMBS_UP: string;
+			THUMBS_DOWN: string;
+			CONFUSED: string;
+			EYES: string;
+			HEART: string;
+			HOORAY: string;
+			LAUGH: string;
+			ROCKET: string;
+		};
+	};
 
 	static initialize(context: vscode.ExtensionContext) {
 		Resource.icons = {

src/common/utils.ts

@@ -135,11 +135,11 @@ export class UnreachableCaseError extends Error {
 }
 
 interface HookError extends Error {
-	errors: any;
+	errors: (string | { message: string })[];
 }
 
 function isHookError(e: Error): e is HookError {
-	return !!(e as any).errors;
+	return !!(e as Partial<HookError>).errors;
 }
 
 function hasFieldErrors(e: any): e is Error & { errors: { value: string; field: string; status: string }[] } {
@@ -184,7 +184,7 @@ export function formatError(e: HookError | any): string {
 		return e.message;
 	} else if (isHookError(e) && e.errors) {
 		return e.errors
-			.map((error: any) => {
+			.map((error) => {
 				if (typeof error === 'string') {
 					return error;
 				} else {
@@ -200,10 +200,6 @@ export function formatError(e: HookError | any): string {
 	return errorMessage;
 }
 
-export interface PromiseAdapter<T, U> {
-	(value: T, resolve: (value?: U | PromiseLike<U>) => void, reject: (reason: any) => void): any;
-}
-
 // Copied from https://github.com/microsoft/vscode/blob/cfd9d25826b5b5bc3b06677521660b4f1ba6639a/extensions/vscode-api-tests/src/utils.ts#L135-L136
 export async function asPromise<T>(event: Event<T>): Promise<T> {
 	return new Promise<T>((resolve) => {

src/common/webview.ts

@@ -17,7 +17,8 @@ export interface IRequestMessage<T> {
 
 export interface IReplyMessage {
 	seq?: string;
-	err?: any;
+	err?: string;
+	// eslint-disable-next-line rulesdir/no-any-except-union-method-signature
 	res?: any;
 }
 
@@ -85,7 +86,7 @@ export class WebviewBase extends Disposable {
 		this._webview?.postMessage(reply);
 	}
 
-	protected async _throwError(originalMessage: IRequestMessage<any> | undefined, error: any) {
+	protected async _throwError(originalMessage: IRequestMessage<any> | undefined, error: string) {
 		const reply: IReplyMessage = {
 			seq: originalMessage?.req,
 			err: error,