Revert "Move command registrations from pullRequestOverview.ts to commands.ts"

This reverts commit c01c824.

Author: alexr00

src/commands.ts

@@ -22,7 +22,7 @@ import { ChatSessionWithPR, CrossChatSessionWithPR } from './github/copilotApi';
 import { CopilotRemoteAgentManager } from './github/copilotRemoteAgent';
 import { FolderRepositoryManager } from './github/folderRepositoryManager';
 import { GitHubRepository } from './github/githubRepository';
-import { Issue, MergeMethod } from './github/interface';
+import { Issue } from './github/interface';
 import { IssueModel } from './github/issueModel';
 import { IssueOverviewPanel } from './github/issueOverview';
 import { GHPRComment, GHPRCommentThread, TemporaryComment } from './github/prComment';
@@ -815,14 +815,6 @@ export function registerCommands(
 
 	context.subscriptions.push(
 		vscode.commands.registerCommand('pr.readyForReview', async (pr?: PRNode) => {
-			// When called from webview context menu (no PRNode), trigger the webview action
-			if (!pr && PullRequestOverviewPanel.currentPanel) {
-				PullRequestOverviewPanel.currentPanel['_postMessage']({
-					command: 'pr.readyForReview-trigger'
-				});
-				return;
-			}
-
 			const folderManager = reposManager.getManagerForIssueModel(pr?.pullRequestModel);
 			if (!folderManager) {
 				return;
@@ -852,17 +844,6 @@ export function registerCommands(
 		}),
 	);
 
-	context.subscriptions.push(
-		vscode.commands.registerCommand('pr.readyForReviewAndMerge', async (_context?: { mergeMethod: MergeMethod }) => {
-			// This command is only called from webview context menu
-			if (PullRequestOverviewPanel.currentPanel) {
-				PullRequestOverviewPanel.currentPanel['_postMessage']({
-					command: 'pr.readyForReviewAndMerge-trigger'
-				});
-			}
-		}),
-	);
-
 	context.subscriptions.push(
 		vscode.commands.registerCommand('pr.dismissNotification', node => {
 			if (node instanceof PRNode) {

src/github/pullRequestOverview.ts

@@ -142,6 +142,12 @@ export class PullRequestOverviewPanel extends IssueOverviewPanel<PullRequestMode
 
 		this.setVisibilityContext();
 
+		this._register(vscode.commands.registerCommand('pr.readyForReview', async () => {
+			return this.readyForReviewCommand();
+		}));
+		this._register(vscode.commands.registerCommand('pr.readyForReviewAndMerge', async (context?: { mergeMethod: MergeMethod }) => {
+			return this.readyForReviewAndMergeCommand(context);
+		}));
 		this._register(vscode.commands.registerCommand('review.approveDescription', (e) => this.approvePullRequestCommand(e)));
 		this._register(vscode.commands.registerCommand('review.commentDescription', (e) => this.submitReviewCommand(e)));
 		this._register(vscode.commands.registerCommand('review.requestChangesDescription', (e) => this.requestChangesCommand(e)));
@@ -678,6 +684,22 @@ export class PullRequestOverviewPanel extends IssueOverviewPanel<PullRequestMode
 		}
 	}
 
+	private async readyForReviewCommand(): Promise<void> {
+		// Trigger the webview action by posting a message
+		// This will use the existing webview logic which handles busy state
+		this._postMessage({
+			command: 'pr.readyForReview-trigger'
+		});
+	}
+
+	private async readyForReviewAndMergeCommand(_context?: { mergeMethod: MergeMethod }): Promise<void> {
+		// Trigger the webview action by posting a message
+		// This will use the existing webview logic which handles busy state
+		this._postMessage({
+			command: 'pr.readyForReviewAndMerge-trigger'
+		});
+	}
+
 	private async checkoutDefaultBranch(message: IRequestMessage<string>): Promise<void> {
 		try {
 			const prBranch = this._folderRepositoryManager.repository.state.HEAD?.name;