Skip to content

Commit 3d09875

Browse files
committed
fix: add webpack build step to CI test jobs
The extension's main entry point is dist/extension.js which requires webpack to build. The test CI jobs were only running tsc (compile-tests) but not webpack (compile), so the extension code wasn't being built and tests were running against stale/missing code. Also simplified the useEnvironmentsExtension check to only skip activation when explicitly set to false by the user.
1 parent a2f18cf commit 3d09875

2 files changed

Lines changed: 9 additions & 5 deletions

File tree

.github/workflows/pr-check.yml

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -102,6 +102,9 @@ jobs:
102102
- name: Install Dependencies
103103
run: npm ci
104104

105+
- name: Compile Extension
106+
run: npm run compile
107+
105108
- name: Compile Tests
106109
run: npm run compile-tests
107110

@@ -148,6 +151,9 @@ jobs:
148151
- name: Install Dependencies
149152
run: npm ci
150153

154+
- name: Compile Extension
155+
run: npm run compile
156+
151157
- name: Compile Tests
152158
run: npm run compile-tests
153159

@@ -194,6 +200,9 @@ jobs:
194200
- name: Install Dependencies
195201
run: npm ci
196202

203+
- name: Compile Extension
204+
run: npm run compile
205+
197206
- name: Compile Tests
198207
run: npm run compile-tests
199208

src/extension.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -99,11 +99,6 @@ export async function activate(context: ExtensionContext): Promise<PythonEnviron
9999
inspection?.workspaceValue === false ||
100100
inspection?.workspaceFolderValue === false;
101101

102-
// DEBUG: Log to stdout which will appear in CI logs
103-
console.log('[python-envs] activate() called');
104-
console.log('[python-envs] inspection:', JSON.stringify(inspection));
105-
console.log('[python-envs] explicitlyDisabled:', explicitlyDisabled);
106-
107102
const useEnvironmentsExtension = !explicitlyDisabled;
108103
traceInfo(`Experiment Status: useEnvironmentsExtension setting set to ${useEnvironmentsExtension}`);
109104
if (!useEnvironmentsExtension) {

0 commit comments

Comments
 (0)