Skip to content

Commit c8ab37c

Browse files
authored
Revert VS Code engine to 1.106, hold task proposed api (#1260)
We dont want to block env extension rollout with dc50906 Revert dc50906
1 parent ded5557 commit c8ab37c

5 files changed

Lines changed: 6 additions & 80 deletions

File tree

package-lock.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,15 +6,14 @@
66
"publisher": "ms-python",
77
"preview": true,
88
"engines": {
9-
"vscode": "^1.110.0-20260204"
9+
"vscode": "^1.106.0"
1010
},
1111
"categories": [
1212
"Other"
1313
],
1414
"enabledApiProposals": [
1515
"terminalShellEnv",
16-
"terminalDataWriteEvent",
17-
"taskExecutionTerminal"
16+
"terminalDataWriteEvent"
1817
],
1918
"capabilities": {
2019
"untrustedWorkspaces": {

src/features/terminal/utils.ts

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import * as path from 'path';
2-
import { Disposable, env, tasks, Terminal, TerminalOptions, Uri } from 'vscode';
2+
import { Disposable, env, Terminal, TerminalOptions, Uri } from 'vscode';
33
import { PythonEnvironment, PythonProject, PythonProjectEnvironmentApi, PythonProjectGetterApi } from '../../api';
44
import { timeout } from '../../common/utils/asyncUtils';
55
import { createSimpleDebounce } from '../../common/utils/debounce';
@@ -129,9 +129,8 @@ function detectsCommonPromptPattern(terminalData: string): boolean {
129129
}
130130

131131
export function isTaskTerminal(terminal: Terminal): boolean {
132-
// Use tasks.taskExecutions API to check if terminal is associated with a task
133-
// See: https://github.com/microsoft/vscode/issues/234440
134-
return tasks.taskExecutions.some((execution) => execution.terminal === terminal);
132+
// TODO: Need API for core for this https://github.com/microsoft/vscode/issues/234440
133+
return terminal.name.toLowerCase().includes('task');
135134
}
136135

137136
export function getTerminalCwd(terminal: Terminal): string | undefined {

src/test/features/terminal/activateMenuButton.unit.test.ts

Lines changed: 0 additions & 57 deletions
This file was deleted.

src/vscode.proposed.taskExecutionTerminal.d.ts

Lines changed: 0 additions & 15 deletions
This file was deleted.

0 commit comments

Comments
 (0)