Same logic for stable and beta (#4964)

Author: DonJayamanne

news/1 Enhancements/4960.md

@@ -0,0 +1 @@
+Use the download same logic for `stable` channel of the `Language Server` as that in `beta`.

src/client/activation/languageServer/downloadChannelRules.ts

@@ -33,7 +33,7 @@ export class DownloadBetaChannelRule implements IDownloadChannelRule {
             true,
             frequencyForBetalLSDownloadCheck);
 
-        // If we haven't checked it in the last 24 hours, then ensure we don't do it again.
+        // If we have checked it in the last 24 hours, then ensure we don't do it again.
         if (globalState.value) {
             await globalState.updateValue(false);
             return true;

src/client/activation/serviceRegistry.ts

@@ -15,7 +15,7 @@ import { LanguageServerExtensionActivationService } from './activationService';
 import { JediExtensionActivator } from './jedi';
 import { LanguageServerExtensionActivator } from './languageServer/activator';
 import { LanguageServerAnalysisOptions } from './languageServer/analysisOptions';
-import { DownloadBetaChannelRule, DownloadDailyChannelRule, DownloadStableChannelRule } from './languageServer/downloadChannelRules';
+import { DownloadBetaChannelRule, DownloadDailyChannelRule } from './languageServer/downloadChannelRules';
 import { LanguageServerDownloader } from './languageServer/downloader';
 import { InterpreterDataService } from './languageServer/interpreterDataService';
 import { BaseLanguageClientFactory, DownloadedLanguageClientFactory, SimpleLanguageClientFactory } from './languageServer/languageClientFactory';
@@ -46,7 +46,7 @@ export function registerTypes(serviceManager: IServiceManager) {
     serviceManager.addSingleton<INugetRepository>(INugetRepository, DailyLanguageServerPackageRepository, LanguageServerDownloadChannel.daily);
     serviceManager.addSingleton<IDownloadChannelRule>(IDownloadChannelRule, DownloadDailyChannelRule, LanguageServerDownloadChannel.daily);
     serviceManager.addSingleton<IDownloadChannelRule>(IDownloadChannelRule, DownloadBetaChannelRule, LanguageServerDownloadChannel.beta);
-    serviceManager.addSingleton<IDownloadChannelRule>(IDownloadChannelRule, DownloadStableChannelRule, LanguageServerDownloadChannel.stable);
+    serviceManager.addSingleton<IDownloadChannelRule>(IDownloadChannelRule, DownloadBetaChannelRule, LanguageServerDownloadChannel.stable);
     serviceManager.addSingleton<ILanagueServerCompatibilityService>(ILanagueServerCompatibilityService, LanguageServerCompatibilityService);
     serviceManager.addSingleton<ILanguageClientFactory>(ILanguageClientFactory, BaseLanguageClientFactory, LanguageClientFactory.base);
     serviceManager.addSingleton<ILanguageClientFactory>(ILanguageClientFactory, DownloadedLanguageClientFactory, LanguageClientFactory.downloaded);