Execute conda related installation commands using shell (#18768)

* Run conda related installation commands using shell

* Update tests

Author: Kartik Raj

src/client/common/installer/condaInstaller.ts

@@ -117,6 +117,8 @@ export class CondaInstaller extends ModuleInstaller {
         return {
             args,
             execPath: condaFile,
+            // Execute in a shell as `conda` on windows refers to `conda.bat`, which requires a shell to work.
+            useShell: true,
         };
     }
 

src/client/common/installer/moduleInstaller.ts

@@ -66,17 +66,38 @@ export abstract class ModuleInstaller implements IModuleInstaller {
                 const pythonPath = isResource(resource) ? interpreterPath : resource.path;
                 const args = internalPython.execModule(executionInfo.moduleName, executionInfoArgs);
                 if (!interpreter || interpreter.envType !== EnvironmentType.Unknown) {
-                    await this.executeCommand(shouldExecuteInTerminal, resource, pythonPath, args, token);
+                    await this.executeCommand(
+                        shouldExecuteInTerminal,
+                        resource,
+                        pythonPath,
+                        args,
+                        token,
+                        executionInfo.useShell,
+                    );
                 } else if (settings.globalModuleInstallation) {
                     const fs = this.serviceContainer.get<IFileSystem>(IFileSystem);
                     if (await fs.isDirReadonly(path.dirname(pythonPath)).catch((_err) => true)) {
                         this.elevatedInstall(pythonPath, args);
                     } else {
-                        await this.executeCommand(shouldExecuteInTerminal, resource, pythonPath, args, token);
+                        await this.executeCommand(
+                            shouldExecuteInTerminal,
+                            resource,
+                            pythonPath,
+                            args,
+                            token,
+                            executionInfo.useShell,
+                        );
                     }
                 } else if (name === translateProductToModule(Product.pip)) {
                     // Pip should always be installed into the specified environment.
-                    await this.executeCommand(shouldExecuteInTerminal, resource, pythonPath, args, token);
+                    await this.executeCommand(
+                        shouldExecuteInTerminal,
+                        resource,
+                        pythonPath,
+                        args,
+                        token,
+                        executionInfo.useShell,
+                    );
                 } else {
                     await this.executeCommand(
                         shouldExecuteInTerminal,
@@ -173,6 +194,7 @@ export abstract class ModuleInstaller implements IModuleInstaller {
         command: string,
         args: string[],
         token?: CancellationToken,
+        useShell?: boolean,
     ) {
         const options: TerminalCreationOptions = {};
         if (isResource(resource)) {
@@ -189,7 +211,17 @@ export abstract class ModuleInstaller implements IModuleInstaller {
         } else {
             const processServiceFactory = this.serviceContainer.get<IProcessServiceFactory>(IProcessServiceFactory);
             const processService = await processServiceFactory.create(options.resource);
-            await processService.exec(command, args);
+            if (useShell) {
+                const argv = [command, ...args];
+                // Concat these together to make a set of quoted strings
+                const quoted = argv.reduce(
+                    (p, c) => (p ? `${p} ${c.toCommandArgument()}` : `${c.toCommandArgument()}`),
+                    '',
+                );
+                await processService.shellExec(quoted);
+            } else {
+                await processService.exec(command, args);
+            }
         }
     }
 }

src/client/common/types.ts

@@ -56,6 +56,7 @@ export type ExecutionInfo = {
     moduleName?: string;
     args: string[];
     product?: Product;
+    useShell?: boolean;
 };
 
 export enum InstallerResponse {

src/test/common/installer/condaInstaller.unit.test.ts

@@ -104,7 +104,11 @@ suite('Common - Conda Installer', () => {
 
         const execInfo = await installer.getExecutionInfo('abc', uri);
 
-        assert.deepEqual(execInfo, { args: ['install', '--name', condaEnv.name, 'abc', '-y'], execPath: condaPath });
+        assert.deepEqual(execInfo, {
+            args: ['install', '--name', condaEnv.name, 'abc', '-y'],
+            execPath: condaPath,
+            useShell: true,
+        });
     });
     test('Include path of environment', async () => {
         const uri = Uri.file(__filename);
@@ -126,6 +130,7 @@ suite('Common - Conda Installer', () => {
         assert.deepEqual(execInfo, {
             args: ['install', '--prefix', condaEnv.path.fileToCommandArgument(), 'abc', '-y'],
             execPath: condaPath,
+            useShell: true,
         });
     });
 });