Explicitly add "justMyCode": "true" to all launch.json configurations (#18471)

posita · kimadeline · web-flow · commit 51f5a3a28b93 · 2022-02-10T13:57:43.000-08:00
* Explicitly add `"justMyCode": "true"` to all `launch.json` configurations Fixes #18389. * Respond to maintainer feedback * Update news/2 Fixes/18471.md Co-authored-by: Kim-Adeline Miguel <51720070+kimadeline@users.noreply.github.com> Co-authored-by: Kim-Adeline Miguel <51720070+kimadeline@users.noreply.github.com>
diff --git a/news/2 Fixes/18471.md b/news/2 Fixes/18471.md
@@ -0,0 +1 @@
+Explicitly add `"justMyCode": "true"` to all `launch.json` configurations. (Thanks [Matt Bogosian](https://github.com/posita))
diff --git a/package.json b/package.json
@@ -1210,7 +1210,7 @@
                             },
                             "justMyCode": {
                                 "default": true,
-                                "description": "Debug only user-written code.",
+                                "description": "If true, show and debug only user-written code. If false, show and debug all code, including library calls.",
                                 "type": "boolean"
                             },
                             "listen": {
diff --git a/src/client/debugger/extension/configuration/providers/djangoLaunch.ts b/src/client/debugger/extension/configuration/providers/djangoLaunch.ts
@@ -38,6 +38,7 @@ export class DjangoLaunchDebugConfigurationProvider implements IDebugConfigurati
             program: program || defaultProgram,
             args: ['runserver'],
             django: true,
+            justMyCode: true,
         };
         if (!program) {
             const selectedProgram = await input.showInputBox({
diff --git a/src/client/debugger/extension/configuration/providers/fastapiLaunch.ts b/src/client/debugger/extension/configuration/providers/fastapiLaunch.ts
@@ -31,6 +31,7 @@ export class FastAPILaunchDebugConfigurationProvider implements IDebugConfigurat
             module: 'uvicorn',
             args: ['main:app'],
             jinja: true,
+            justMyCode: true,
         };
 
         if (!application) {
diff --git a/src/client/debugger/extension/configuration/providers/fileLaunch.ts b/src/client/debugger/extension/configuration/providers/fileLaunch.ts
@@ -24,9 +24,9 @@ export class FileLaunchDebugConfigurationProvider implements IDebugConfiguration
             name: DebugConfigStrings.file.snippet.name(),
             type: DebuggerTypeName,
             request: 'launch',
-
             program: '${file}',
             console: 'integratedTerminal',
+            justMyCode: true,
         };
         Object.assign(state.config, config);
     }
diff --git a/src/client/debugger/extension/configuration/providers/flaskLaunch.ts b/src/client/debugger/extension/configuration/providers/flaskLaunch.ts
@@ -35,6 +35,7 @@ export class FlaskLaunchDebugConfigurationProvider implements IDebugConfiguratio
             },
             args: ['run', '--no-debugger'],
             jinja: true,
+            justMyCode: true,
         };
 
         if (!application) {
diff --git a/src/client/debugger/extension/configuration/providers/moduleLaunch.ts b/src/client/debugger/extension/configuration/providers/moduleLaunch.ts
@@ -21,6 +21,7 @@ export class ModuleLaunchDebugConfigurationProvider implements IDebugConfigurati
             type: DebuggerTypeName,
             request: 'launch',
             module: DebugConfigStrings.module.snippet.default(),
+            justMyCode: true,
         };
         const selectedModule = await input.showInputBox({
             title: DebugConfigStrings.module.enterModule.title(),
diff --git a/src/client/debugger/extension/configuration/providers/pidAttach.ts b/src/client/debugger/extension/configuration/providers/pidAttach.ts
@@ -24,8 +24,8 @@ export class PidAttachDebugConfigurationProvider implements IDebugConfigurationP
             name: DebugConfigStrings.attachPid.snippet.name(),
             type: DebuggerTypeName,
             request: 'attach',
-
             processId: '${command:pickProcess}',
+            justMyCode: true,
         };
         Object.assign(state.config, config);
     }
diff --git a/src/client/debugger/extension/configuration/providers/pyramidLaunch.ts b/src/client/debugger/extension/configuration/providers/pyramidLaunch.ts
@@ -40,6 +40,7 @@ export class PyramidLaunchDebugConfigurationProvider implements IDebugConfigurat
             args: [iniPath || defaultIni],
             pyramid: true,
             jinja: true,
+            justMyCode: true,
         };
 
         if (!iniPath) {
diff --git a/src/client/debugger/extension/configuration/providers/remoteAttach.ts b/src/client/debugger/extension/configuration/providers/remoteAttach.ts
@@ -35,6 +35,7 @@ export class RemoteAttachDebugConfigurationProvider implements IDebugConfigurati
                     remoteRoot: '.',
                 },
             ],
+            justMyCode: true,
         };
 
         const connect = config.connect!;
diff --git a/src/test/debugger/extension/configuration/providers/djangoLaunch.unit.test.ts b/src/test/debugger/extension/configuration/providers/djangoLaunch.unit.test.ts
@@ -137,6 +137,7 @@ suite('Debugging - Configuration Provider Django', () => {
             program: 'xyz.py',
             args: ['runserver'],
             django: true,
+            justMyCode: true,
         };
 
         expect(state.config).to.be.deep.equal(config);
@@ -157,6 +158,7 @@ suite('Debugging - Configuration Provider Django', () => {
             program: 'hello',
             args: ['runserver'],
             django: true,
+            justMyCode: true,
         };
 
         expect(state.config).to.be.deep.equal(config);
@@ -180,6 +182,7 @@ suite('Debugging - Configuration Provider Django', () => {
             program: defaultProgram,
             args: ['runserver'],
             django: true,
+            justMyCode: true,
         };
 
         expect(state.config).to.be.deep.equal(config);
diff --git a/src/test/debugger/extension/configuration/providers/fastapiLaunch.unit.test.ts b/src/test/debugger/extension/configuration/providers/fastapiLaunch.unit.test.ts
@@ -62,6 +62,7 @@ suite('Debugging - Configuration Provider FastAPI', () => {
             module: 'uvicorn',
             args: ['main:app'],
             jinja: true,
+            justMyCode: true,
         };
 
         expect(state.config).to.be.deep.equal(config);
@@ -82,6 +83,7 @@ suite('Debugging - Configuration Provider FastAPI', () => {
             module: 'uvicorn',
             args: ['main:app'],
             jinja: true,
+            justMyCode: true,
         };
 
         expect(state.config).to.be.deep.equal(config);
diff --git a/src/test/debugger/extension/configuration/providers/fileLaunch.unit.test.ts b/src/test/debugger/extension/configuration/providers/fileLaunch.unit.test.ts
@@ -25,9 +25,9 @@ suite('Debugging - Configuration Provider File', () => {
             name: DebugConfigStrings.file.snippet.name(),
             type: DebuggerTypeName,
             request: 'launch',
-
             program: '${file}',
             console: 'integratedTerminal',
+            justMyCode: true,
         };
 
         expect(state.config).to.be.deep.equal(config);
diff --git a/src/test/debugger/extension/configuration/providers/flaskLaunch.unit.test.ts b/src/test/debugger/extension/configuration/providers/flaskLaunch.unit.test.ts
@@ -66,6 +66,7 @@ suite('Debugging - Configuration Provider Flask', () => {
             },
             args: ['run', '--no-debugger'],
             jinja: true,
+            justMyCode: true,
         };
 
         expect(state.config).to.be.deep.equal(config);
@@ -90,6 +91,7 @@ suite('Debugging - Configuration Provider Flask', () => {
             },
             args: ['run', '--no-debugger'],
             jinja: true,
+            justMyCode: true,
         };
 
         expect(state.config).to.be.deep.equal(config);
@@ -114,6 +116,7 @@ suite('Debugging - Configuration Provider Flask', () => {
             },
             args: ['run', '--no-debugger'],
             jinja: true,
+            justMyCode: true,
         };
 
         expect(state.config).to.be.deep.equal(config);
diff --git a/src/test/debugger/extension/configuration/providers/moduleLaunch.unit.test.ts b/src/test/debugger/extension/configuration/providers/moduleLaunch.unit.test.ts
@@ -32,6 +32,7 @@ suite('Debugging - Configuration Provider Module', () => {
             type: DebuggerTypeName,
             request: 'launch',
             module: DebugConfigStrings.module.snippet.default(),
+            justMyCode: true,
         };
 
         expect(state.config).to.be.deep.equal(config);
@@ -50,6 +51,7 @@ suite('Debugging - Configuration Provider Module', () => {
             type: DebuggerTypeName,
             request: 'launch',
             module: 'hello',
+            justMyCode: true,
         };
 
         expect(state.config).to.be.deep.equal(config);
diff --git a/src/test/debugger/extension/configuration/providers/pidAttach.unit.test.ts b/src/test/debugger/extension/configuration/providers/pidAttach.unit.test.ts
@@ -25,8 +25,8 @@ suite('Debugging - Configuration Provider File', () => {
             name: DebugConfigStrings.attachPid.snippet.name(),
             type: DebuggerTypeName,
             request: 'attach',
-
             processId: '${command:pickProcess}',
+            justMyCode: true,
         };
 
         expect(state.config).to.be.deep.equal(config);
diff --git a/src/test/debugger/extension/configuration/providers/pyramidLaunch.unit.test.ts b/src/test/debugger/extension/configuration/providers/pyramidLaunch.unit.test.ts
@@ -138,6 +138,7 @@ suite('Debugging - Configuration Provider Pyramid', () => {
             args: ['xyz.ini'],
             pyramid: true,
             jinja: true,
+            justMyCode: true,
         };
 
         expect(state.config).to.be.deep.equal(config);
@@ -159,6 +160,7 @@ suite('Debugging - Configuration Provider Pyramid', () => {
             args: ['hello'],
             pyramid: true,
             jinja: true,
+            justMyCode: true,
         };
 
         expect(state.config).to.be.deep.equal(config);
@@ -183,6 +185,7 @@ suite('Debugging - Configuration Provider Pyramid', () => {
             args: [defaultIni],
             pyramid: true,
             jinja: true,
+            justMyCode: true,
         };
 
         expect(state.config).to.be.deep.equal(config);
diff --git a/src/test/debugger/extension/configuration/providers/remoteAttach.unit.test.ts b/src/test/debugger/extension/configuration/providers/remoteAttach.unit.test.ts
@@ -92,6 +92,7 @@ suite('Debugging - Configuration Provider Remote Attach', () => {
                     remoteRoot: '.',
                 },
             ],
+            justMyCode: true,
         };
 
         expect(state.config).to.be.deep.equal(config);
@@ -127,6 +128,7 @@ suite('Debugging - Configuration Provider Remote Attach', () => {
                     remoteRoot: '.',
                 },
             ],
+            justMyCode: true,
         };
 
         expect(state.config).to.be.deep.equal(config);

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	+Explicitly add `"justMyCode": "true"` to all `launch.json` configurations. (Thanks [Matt Bogosian](https://github.com/posita))