Change how we offer to install/disable linters (#973)

* Basic tokenizer

* Fixed property names

* Tests, round I

* Tests, round II

* tokenizer test

* Remove temorary change

* Fix merge issue

* Merge conflict

* Merge conflict

* Completion test

* Fix last line

* Fix javascript math

* Make test await for results

* Add license headers

* Rename definitions to types

* License headers

* Fix typo in completion details (typo)

* Fix hover test

* Russian translations

* Update to better translation

* Fix typo

*  #70 How to get all parameter info when filling in a function param list

* Fix #70 How to get all parameter info when filling in a function param list

* Clean up

* Clean imports

* CR feedback

* Trim whitespace for test stability

* More tests

* Better handle no-parameters documentation

* Better handle ellipsis and Python3

* #385 Auto-Indentation doesn't work after comment

* #141 Auto indentation broken when return keyword involved

* Undo changes

* #627 Docstrings for builtin methods are not parsed correctly

* reStructuredText converter

* Fix: period is not an operator

* Minor fixes

* Restructure

* Tests

* Tests

* Code heuristics

* Baselines

* HTML handling

* Lists

* State machine

* Baselines

* Squash

* no message

* Whitespace difference

* Update Jedi to 0.11.1

* Enable Travis

* Test fixes

* Undo change

* Jedi 0.11 with parser

* Undo changes

* Undo changes

* Test fixes

* More tests

* Tests

* Fix pylint search

* Handle quote escapes in strings

* Escapes in strings

* CR feedback

* Discover pylintrc better + tests

* Fix .pyenv/versions search

* Fix multiple linters output

* Better handle markdown underscore

* Test

* Fix 916: PyLint checks wrong files

* Test stability

* Try increase timeout

* Make sure linting is enabled in tests

* Try another way of waiting

* Simplify

* Fix clear diags on close tests

* Try writing settings directly

* Increase timeout

* Measure test time

* Measure time

* Simplify

* Set timeout

* Better venv detection

* Add test

* More reliable check

* Fix pylint switch key

* Remove incorrect flag

* Disable print

* Require pylint 1.8 on CI

* Fix working directory for standalone files

* Use an 'elif'

* Separate file for pylint root config

* Remove double event listening

* Remove test

* Revert "Remove test"

This reverts commit e240c3f.

* Revert "Remove double event listening"

This reverts commit af573be.

* Explicitly disable linter

* New buttons

* PR feedback

* Revert "PR feedback"

This reverts commit d0c7ab5.

* PR feedback

Author: Mikhail Arkhipov

src/client/common/installer/productInstaller.ts

@@ -154,18 +154,21 @@ class LinterInstaller extends BaseInstaller {
     public async promptToInstall(product: Product, resource?: Uri): Promise<InstallerResponse> {
         const productName = ProductNames.get(product)!;
         const install = 'Install';
-        const disable = 'Disable linting';
+        const disableAllLinting = 'Disable linting';
+        const disableThisLinter = `Disable ${productName}`;
 
         const response = await this.appShell
-            .showErrorMessage(`Linter ${productName} is not installed.`, install, disable);
+            .showErrorMessage(`Linter ${productName} is not installed.`, install, disableThisLinter, disableAllLinting);
         if (response === install) {
             return this.install(product, resource);
         }
         const lm = this.serviceContainer.get<ILinterManager>(ILinterManager);
-        if (response === disable) {
+        if (response === disableAllLinting) {
             await lm.enableLintingAsync(false);
-        } else {
-            lm.disableSessionLinting();
+            return InstallerResponse.Disabled;
+        } else if (response === disableThisLinter) {
+            await lm.getLinterInfo(product).enableAsync(false);
+            return InstallerResponse.Disabled;
         }
         return InstallerResponse.Ignore;
     }

src/client/linters/linterManager.ts

@@ -30,7 +30,6 @@ export class LinterManager implements ILinterManager {
     private lintingEnabledSettingName = 'enabled';
     private linters: ILinterInfo[];
     private configService: IConfigurationService;
-    private disabledForCurrentSession = false;
 
     constructor(@inject(IServiceContainer) serviceContainer: IServiceContainer) {
         this.configService = serviceContainer.get<IConfigurationService>(IConfigurationService);
@@ -58,18 +57,11 @@ export class LinterManager implements ILinterManager {
     }
 
     public isLintingEnabled(resource?: Uri): boolean {
-        if (this.disabledForCurrentSession) {
-            return false;
-        }
         const settings = this.configService.getSettings(resource);
         return (settings.linting[this.lintingEnabledSettingName] as boolean) && this.getActiveLinters(resource).length > 0;
     }
 
     public async enableLintingAsync(enable: boolean, resource?: Uri): Promise<void> {
-        if (enable) {
-            this.disabledForCurrentSession = false;
-        }
-
         await this.configService.updateSettingAsync(`linting.${this.lintingEnabledSettingName}`, enable, resource);
 
         // If nothing is enabled, fix it up to PyLint (default).
@@ -78,10 +70,6 @@ export class LinterManager implements ILinterManager {
         }
     }
 
-    public disableSessionLinting(): void {
-        this.disabledForCurrentSession = true;
-    }
-
     public getActiveLinters(resource?: Uri): ILinterInfo[] {
         return this.linters.filter(x => x.isEnabled(resource));
     }

src/client/linters/types.ts

@@ -38,7 +38,6 @@ export interface ILinterManager {
     getActiveLinters(resource?: vscode.Uri): ILinterInfo[];
     isLintingEnabled(resource?: vscode.Uri): boolean;
     enableLintingAsync(enable: boolean, resource?: vscode.Uri): Promise<void>;
-    disableSessionLinting(): void;
     setActiveLintersAsync(products: Product[], resource?: vscode.Uri): Promise<void>;
     createLinter(product: Product, outputChannel: vscode.OutputChannel, serviceContainer: IServiceContainer, resource?: vscode.Uri): ILinter;
 }