Ensure we do not update the cache unnecessarily while getting env details if it already has latest info (#18766)

Kartik Raj · web-flow · commit 5db5d7bef846 · 2022-03-23T23:23:59.000+05:30
diff --git a/src/client/pythonEnvironments/base/locators/composite/envsCollectionCache.ts b/src/client/pythonEnvironments/base/locators/composite/envsCollectionCache.ts
@@ -112,8 +112,6 @@ export class PythonEnvInfoCache extends PythonEnvsWatcher<PythonEnvCollectionCha
             this.envs.push(env);
             this.fire({ new: env });
             reportInterpretersChanged([{ path: getEnvPath(env.executable.filename, env.location).path, type: 'add' }]);
-        } else if (hasCompleteInfo) {
-            this.updateEnv(found, env);
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -112,8 +112,6 @@ export class PythonEnvInfoCache extends PythonEnvsWatcher<PythonEnvCollectionCha`
`112`	`112`	`this.envs.push(env);`
`113`	`113`	`this.fire({ new: env });`
`114`	`114`	`reportInterpretersChanged([{ path: getEnvPath(env.executable.filename, env.location).path, type: 'add' }]);`
`115`		`- } else if (hasCompleteInfo) {`
`116`		`- this.updateEnv(found, env);`
`117`	`115`	`}`
`118`	`116`	`}`
`119`	`117`