Fix hyperlinks (#5766)

Author: rchiodo

news/2 Fixes/5630.md

@@ -0,0 +1 @@
+Add support for opening hyperlinks from the interactive window.

package-lock.json

@@ -53,6 +53,7 @@ export namespace HistoryMessages {
     export const LoadOnigasmAssemblyResponse = 'load_onigasm_assembly_response';
     export const LoadTmLanguageRequest = 'load_tmlanguage_request';
     export const LoadTmLanguageResponse = 'load_tmlanguage_response';
+    export const OpenLink = 'open_link';
 }
 
 // These are the messages that will mirror'd to guest/hosts in
@@ -198,4 +199,5 @@ export class IHistoryMapping {
     public [HistoryMessages.LoadOnigasmAssemblyResponse]: Buffer;
     public [HistoryMessages.LoadTmLanguageRequest]: never | undefined;
     public [HistoryMessages.LoadTmLanguageResponse]: string | undefined;
+    public [HistoryMessages.OpenLink]: string | undefined;
 }

src/client/datascience/history/historyTypes.ts

@@ -0,0 +1,40 @@
+// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT License.
+'use strict';
+import '../../common/extensions';
+
+import { inject, injectable } from 'inversify';
+import { Event, EventEmitter } from 'vscode';
+
+import { IApplicationShell } from '../../common/application/types';
+import { noop } from '../../common/utils/misc';
+import { IHistoryListener } from '../types';
+import { HistoryMessages } from './historyTypes';
+
+// tslint:disable: no-any
+@injectable()
+export class LinkProvider implements IHistoryListener {
+    private postEmitter: EventEmitter<{message: string; payload: any}> = new EventEmitter<{message: string; payload: any}>();
+    constructor(@inject(IApplicationShell) private applicationShell: IApplicationShell) {
+        noop();
+    }
+
+    public get postMessage(): Event<{ message: string; payload: any }> {
+        return this.postEmitter.event;
+    }
+
+    public onMessage(message: string, payload?: any): void {
+        switch (message) {
+            case HistoryMessages.OpenLink:
+                if (payload) {
+                    this.applicationShell.openUrl(payload.toString());
+                }
+                break;
+            default:
+                break;
+        }
+    }
+    public dispose(): void | undefined {
+        noop();
+    }
+}

src/client/datascience/history/linkProvider.ts

@@ -15,6 +15,7 @@ import { HistoryCommandListener } from './history/historycommandlistener';
 import { HistoryProvider } from './history/historyProvider';
 import { DotNetIntellisenseProvider } from './history/intellisense/dotNetIntellisenseProvider';
 import { JediIntellisenseProvider } from './history/intellisense/jediIntellisenseProvider';
+import { LinkProvider } from './history/linkProvider';
 import { JupyterCommandFactory } from './jupyter/jupyterCommand';
 import { JupyterExecutionFactory } from './jupyter/jupyterExecutionFactory';
 import { JupyterExporter } from './jupyter/jupyterExporter';
@@ -68,4 +69,5 @@ export function registerTypes(serviceManager: IServiceManager) {
     serviceManager.addSingleton<IExtensionActivationService>(IExtensionActivationService, Decorator);
     serviceManager.add<IHistoryListener>(IHistoryListener, DotNetIntellisenseProvider);
     serviceManager.add<IHistoryListener>(IHistoryListener, JediIntellisenseProvider);
+    serviceManager.add<IHistoryListener>(IHistoryListener, LinkProvider);
 }

src/client/datascience/serviceRegistry.ts

@@ -314,6 +314,7 @@ export class MainPanel extends React.Component<IMainPanelProps, IMainPanelState>
                         onCodeCreated={this.editableCodeCreated}
                         onCodeChange={this.codeChange}
                         monacoTheme={this.state.monacoTheme}
+                        openLink={this.openLink}
                     />
                 </ErrorBoundary>
             </div>
@@ -400,7 +401,8 @@ export class MainPanel extends React.Component<IMainPanelProps, IMainPanelState>
             skipNextScroll: this.state.skipNextScroll ? true : false,
             monacoTheme: this.state.monacoTheme,
             onCodeCreated: this.readOnlyCodeCreated,
-            onCodeChange: this.codeChange
+            onCodeChange: this.codeChange,
+            openLink: this.openLink
         };
     }
     private getToolbarProps = (baseTheme: string): IToolbarPanelProps => {
@@ -481,6 +483,10 @@ export class MainPanel extends React.Component<IMainPanelProps, IMainPanelState>
         this.postOffice.sendMessage<M, T>(type, payload);
     }
 
+    private openLink = (uri: monacoEditor.Uri) => {
+        this.sendMessage(HistoryMessages.OpenLink, uri.toString());
+    }
+
     private getAllCells = () => {
         // Send all of our cells back to the other side
         const cells = this.state.cellVMs.map((cellVM : ICellViewModel) => {

src/datascience-ui/history-react/MainPanel.tsx

@@ -46,6 +46,7 @@ interface ICellProps {
     submitNewCode(code: string): void;
     onCodeChange(changes: monacoEditor.editor.IModelContentChange[], cellId: string, modelId: string): void;
     onCodeCreated(code: string, file: string, cellId: string, modelId: string): void;
+    openLink(uri: monacoEditor.Uri): void;
 }
 
 export interface ICellViewModel {
@@ -228,6 +229,7 @@ export class Cell extends React.Component<ICellProps> {
                         onCreated={this.onCodeCreated}
                         outermostParentClass='cell-wrapper'
                         monacoTheme={this.props.monacoTheme}
+                        openLink={this.props.openLink}
                         />
                 </div>
             );

src/datascience-ui/history-react/cell.tsx

@@ -26,6 +26,7 @@ export interface ICodeProps {
     onSubmit(code: string): void;
     onCreated(code: string, modelId: string): void;
     onChange(changes: monacoEditor.editor.IModelContentChange[], modelId: string): void;
+    openLink(uri: monacoEditor.Uri): void;
 }
 
 interface ICodeState {
@@ -100,6 +101,7 @@ export class Code extends React.Component<ICodeProps, ICodeState> {
                     language='python'
                     editorMounted={this.editorDidMount}
                     options={options}
+                    openLink={this.props.openLink}
                 />
                 <div className={waterMarkClass}>{this.getWatermarkString()}</div>
             </div>