Bug: Fix python.execInREPL stealing shift+enter (#23526)

anthonykim1 · web-flow · commit f001597604cd · 2024-05-29T18:17:44.000-07:00
Stop stealing shift+enter if editor is not focused and language is not python. Resolves: #23525
diff --git a/package.json b/package.json
@@ -1118,12 +1118,12 @@
             {
                 "command": "python.execInREPL",
                 "key": "shift+enter",
-                "when": "config.python.REPL.sendToNativeREPL && activeEditor != 'workbench.editor.interactive'"
+                "when": "config.python.REPL.sendToNativeREPL && activeEditor != 'workbench.editor.interactive'&& editorLangId == python && editorTextFocus && !jupyter.ownsSelection"
             },
             {
                 "command": "python.execREPLShiftEnter",
                 "key": "shift+enter",
-                "when": "activeEditor == 'workbench.editor.interactive' && config.interactiveWindow.executeWithShiftEnter"
+                "when": "activeEditor == 'workbench.editor.interactive' && config.interactiveWindow.executeWithShiftEnter && editorLangId == python"
             },
             {
                 "command": "python.execInREPLEnter",

Original file line number	Diff line number	Diff line change
`@@ -1118,12 +1118,12 @@`
`1118`	`1118`	`{`
`1119`	`1119`	`"command": "python.execInREPL",`
`1120`	`1120`	`"key": "shift+enter",`
`1121`		`- "when": "config.python.REPL.sendToNativeREPL && activeEditor != 'workbench.editor.interactive'"`
	`1121`	`+ "when": "config.python.REPL.sendToNativeREPL && activeEditor != 'workbench.editor.interactive'&& editorLangId == python && editorTextFocus && !jupyter.ownsSelection"`
`1122`	`1122`	`},`
`1123`	`1123`	`{`
`1124`	`1124`	`"command": "python.execREPLShiftEnter",`
`1125`	`1125`	`"key": "shift+enter",`
`1126`		`- "when": "activeEditor == 'workbench.editor.interactive' && config.interactiveWindow.executeWithShiftEnter"`
	`1126`	`+ "when": "activeEditor == 'workbench.editor.interactive' && config.interactiveWindow.executeWithShiftEnter && editorLangId == python"`
`1127`	`1127`	`},`
`1128`	`1128`	`{`
`1129`	`1129`	`"command": "python.execInREPLEnter",`