Allow any x.x.100 build of Jupyter to use notebooks experiment (#19170)

debonte · web-flow · commit f37690eaa17e · 2022-05-19T15:33:14.000-07:00
diff --git a/src/client/activation/node/lspNotebooksExperiment.ts b/src/client/activation/node/lspNotebooksExperiment.ts
@@ -100,8 +100,7 @@ export class LspNotebooksExperiment implements IExtensionSingleActivationService
     private static jupyterSupportsNotebooksExperiment(): boolean {
         const jupyterVersion = extensions.getExtension(JUPYTER_EXTENSION_ID)?.packageJSON.version;
         return (
-            jupyterVersion &&
-            (semver.gt(jupyterVersion, '2022.5.1001391015') || semver.eq(jupyterVersion, '2022.4.100'))
+            jupyterVersion && (semver.gt(jupyterVersion, '2022.5.1001411044') || semver.patch(jupyterVersion) === 100)
         );
     }
 

Original file line number	Diff line number	Diff line change
`@@ -100,8 +100,7 @@ export class LspNotebooksExperiment implements IExtensionSingleActivationService`
`100`	`100`	`private static jupyterSupportsNotebooksExperiment(): boolean {`
`101`	`101`	`const jupyterVersion = extensions.getExtension(JUPYTER_EXTENSION_ID)?.packageJSON.version;`
`102`	`102`	`return (`
`103`		`- jupyterVersion &&`
`104`		`- (semver.gt(jupyterVersion, '2022.5.1001391015') \|\| semver.eq(jupyterVersion, '2022.4.100'))`
	`103`	`+ jupyterVersion && (semver.gt(jupyterVersion, '2022.5.1001411044') \|\| semver.patch(jupyterVersion) === 100)`
`105`	`104`	`);`
`106`	`105`	`}`
`107`	`106`