Skip to content

Commit 889abdd

Browse files
author
jsinghmokha
committed
Address PR review feedback and fix API Doctor validation
- Replace inline permission tables with include file references using blockType permissions - Add permission include files for all 5 section management APIs - Fix @odata.type syntax in list sections response - Remove "currently" from OData query params text - Remove sectionType and sectionSortType from enums.md (kept in resource topic) - Move Sections (preview) under Messaging in TOC
1 parent 4ab1f36 commit 889abdd

12 files changed

Lines changed: 48 additions & 64 deletions

api-reference/beta/api/teamworksection-delete.md

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -22,13 +22,8 @@ Delete a user-defined [section](../resources/teamworksection.md) from a user's [
2222

2323
Choose the permission or permissions marked as least privileged for this API. Use a higher privileged permission or permissions [only if your app requires it](/graph/permissions-overview#best-practices-for-using-microsoft-graph-permissions). For details about delegated and application permissions, see [Permission types](/graph/permissions-overview#permission-types). To learn more about these permissions, see the [permissions reference](/graph/permissions-reference).
2424

25-
<!-- { "blockType": "ignored" } -->
26-
27-
| Permission type | Least privileged permissions | Higher privileged permissions |
28-
|:----------------|:-----------------------------|:-----------------------------|
29-
| Delegated (work or school account) | TeamworkSection.ReadWrite | Not available. |
30-
| Delegated (personal Microsoft account) | Not supported. | Not supported. |
31-
| Application | TeamworkSection.ReadWrite.All | Not available. |
25+
<!-- { "blockType": "permissions", "name": "teamworksection_delete" } -->
26+
[!INCLUDE [permissions-table](../includes/permissions/teamworksection-delete-permissions.md)]
3227

3328
## HTTP request
3429

api-reference/beta/api/teamworksection-get.md

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -22,13 +22,8 @@ Read the properties of a [section](../resources/teamworksection.md) in a user's
2222

2323
Choose the permission or permissions marked as least privileged for this API. Use a higher privileged permission or permissions [only if your app requires it](/graph/permissions-overview#best-practices-for-using-microsoft-graph-permissions). For details about delegated and application permissions, see [Permission types](/graph/permissions-overview#permission-types). To learn more about these permissions, see the [permissions reference](/graph/permissions-reference).
2424

25-
<!-- { "blockType": "ignored" } -->
26-
27-
| Permission type | Least privileged permissions | Higher privileged permissions |
28-
|:----------------|:-----------------------------|:-----------------------------|
29-
| Delegated (work or school account) | TeamworkSection.Read | TeamworkSection.ReadWrite |
30-
| Delegated (personal Microsoft account) | Not supported. | Not supported. |
31-
| Application | TeamworkSection.Read.All | TeamworkSection.ReadWrite.All |
25+
<!-- { "blockType": "permissions", "name": "teamworksection_get" } -->
26+
[!INCLUDE [permissions-table](../includes/permissions/teamworksection-get-permissions.md)]
3227

3328
## HTTP request
3429

@@ -39,7 +34,7 @@ GET /users/{user-id}/teamwork/sections/{teamworkSection-id}
3934

4035
## Optional query parameters
4136

42-
This method doesn't currently support [OData query parameters](/graph/query-parameters) to customize the response.
37+
This method doesn't support [OData query parameters](/graph/query-parameters) to customize the response.
4338

4439
## Request headers
4540

api-reference/beta/api/teamworksection-update.md

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -22,13 +22,8 @@ Update the properties of a [section](../resources/teamworksection.md) in a user'
2222

2323
Choose the permission or permissions marked as least privileged for this API. Use a higher privileged permission or permissions [only if your app requires it](/graph/permissions-overview#best-practices-for-using-microsoft-graph-permissions). For details about delegated and application permissions, see [Permission types](/graph/permissions-overview#permission-types). To learn more about these permissions, see the [permissions reference](/graph/permissions-reference).
2424

25-
<!-- { "blockType": "ignored" } -->
26-
27-
| Permission type | Least privileged permissions | Higher privileged permissions |
28-
|:----------------|:-----------------------------|:-----------------------------|
29-
| Delegated (work or school account) | TeamworkSection.ReadWrite | Not available. |
30-
| Delegated (personal Microsoft account) | Not supported. | Not supported. |
31-
| Application | TeamworkSection.ReadWrite.All | Not available. |
25+
<!-- { "blockType": "permissions", "name": "teamworksection_update" } -->
26+
[!INCLUDE [permissions-table](../includes/permissions/teamworksection-update-permissions.md)]
3227

3328
## HTTP request
3429

api-reference/beta/api/userteamwork-list-sections.md

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -22,13 +22,8 @@ Get the list of [sections](../resources/teamworksection.md) in a user's [teamwor
2222

2323
Choose the permission or permissions marked as least privileged for this API. Use a higher privileged permission or permissions [only if your app requires it](/graph/permissions-overview#best-practices-for-using-microsoft-graph-permissions). For details about delegated and application permissions, see [Permission types](/graph/permissions-overview#permission-types). To learn more about these permissions, see the [permissions reference](/graph/permissions-reference).
2424

25-
<!-- { "blockType": "ignored" } -->
26-
27-
| Permission type | Least privileged permissions | Higher privileged permissions |
28-
|:----------------|:-----------------------------|:-----------------------------|
29-
| Delegated (work or school account) | TeamworkSection.Read | TeamworkSection.ReadWrite |
30-
| Delegated (personal Microsoft account) | Not supported. | Not supported. |
31-
| Application | TeamworkSection.Read.All | TeamworkSection.ReadWrite.All |
25+
<!-- { "blockType": "permissions", "name": "userteamwork_list_sections" } -->
26+
[!INCLUDE [permissions-table](../includes/permissions/userteamwork-list-sections-permissions.md)]
3227

3328
## HTTP request
3429

@@ -39,7 +34,7 @@ GET /users/{user-id}/teamwork/sections
3934

4035
## Optional query parameters
4136

42-
This method doesn't currently support [OData query parameters](/graph/query-parameters) to customize the response.
37+
This method doesn't support [OData query parameters](/graph/query-parameters) to customize the response.
4338

4439
## Request headers
4540

@@ -79,7 +74,7 @@ The following example shows the response.
7974
<!-- {
8075
"blockType": "response",
8176
"truncated": true,
82-
"@odata.type": "Collection(microsoft.graph.teamworkSection")
77+
"@odata.type": "Collection(microsoft.graph.teamworkSection)"
8378
}-->
8479
```http
8580
HTTP/1.1 200 OK

api-reference/beta/api/userteamwork-post-sections.md

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -22,13 +22,8 @@ Create a new [section](../resources/teamworksection.md) in a user's [teamwork](.
2222

2323
Choose the permission or permissions marked as least privileged for this API. Use a higher privileged permission or permissions [only if your app requires it](/graph/permissions-overview#best-practices-for-using-microsoft-graph-permissions). For details about delegated and application permissions, see [Permission types](/graph/permissions-overview#permission-types). To learn more about these permissions, see the [permissions reference](/graph/permissions-reference).
2424

25-
<!-- { "blockType": "ignored" } -->
26-
27-
| Permission type | Least privileged permissions | Higher privileged permissions |
28-
|:----------------|:-----------------------------|:-----------------------------|
29-
| Delegated (work or school account) | TeamworkSection.ReadWrite | Not available. |
30-
| Delegated (personal Microsoft account) | Not supported. | Not supported. |
31-
| Application | TeamworkSection.ReadWrite.All | Not available. |
25+
<!-- { "blockType": "permissions", "name": "userteamwork_post_sections" } -->
26+
[!INCLUDE [permissions-table](../includes/permissions/userteamwork-post-sections-permissions.md)]
3227

3328
## HTTP request
3429

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
|Permission type|Least privileged permissions|Higher privileged permissions|
2+
|:---|:---|:---|
3+
|Delegated (work or school account)|TeamworkSection.ReadWrite|Not available.|
4+
|Delegated (personal Microsoft account)|Not supported.|Not supported.|
5+
|Application|TeamworkSection.ReadWrite.All|Not available.|
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
|Permission type|Least privileged permissions|Higher privileged permissions|
2+
|:---|:---|:---|
3+
|Delegated (work or school account)|TeamworkSection.Read|TeamworkSection.ReadWrite|
4+
|Delegated (personal Microsoft account)|Not supported.|Not supported.|
5+
|Application|TeamworkSection.Read.All|TeamworkSection.ReadWrite.All|
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
|Permission type|Least privileged permissions|Higher privileged permissions|
2+
|:---|:---|:---|
3+
|Delegated (work or school account)|TeamworkSection.ReadWrite|Not available.|
4+
|Delegated (personal Microsoft account)|Not supported.|Not supported.|
5+
|Application|TeamworkSection.ReadWrite.All|Not available.|
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
|Permission type|Least privileged permissions|Higher privileged permissions|
2+
|:---|:---|:---|
3+
|Delegated (work or school account)|TeamworkSection.Read|TeamworkSection.ReadWrite|
4+
|Delegated (personal Microsoft account)|Not supported.|Not supported.|
5+
|Application|TeamworkSection.Read.All|TeamworkSection.ReadWrite.All|
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
|Permission type|Least privileged permissions|Higher privileged permissions|
2+
|:---|:---|:---|
3+
|Delegated (work or school account)|TeamworkSection.ReadWrite|Not available.|
4+
|Delegated (personal Microsoft account)|Not supported.|Not supported.|
5+
|Application|TeamworkSection.ReadWrite.All|Not available.|

0 commit comments

Comments
 (0)