ent/admin/handler.go

[Jimmy99]

I added an entity in my schema which is just a history table to record which "reporting entity" a user has accessed over time, so the only field is a date stamp.

func (ReportingEntitySelection) Fields() []ent.Field {
return []ent.Field{
field.Time("selected_at").
Default(time.Now).
Immutable().
Comment("When this selection was made"),

	//field.String("comment"),
}

}

When I go generate ./ent I get an error: declared and not used: entity
The error occurs in this function:
func (h *Handler) ReportingEntitySelectionGet(ctx echo.Context, id int) (url.Values, error) {
entity, err := h.client.ReportingEntitySelection.Get(ctx.Request().Context(), id)
if err != nil {
return nil, err
}

v := url.Values{}
return v, err

}

If I add a field (commented out above field.String("comment"), then the generated function works fine because entity is used in the v.Set statement.

func (h *Handler) ReportingEntitySelectionGet(ctx echo.Context, id int) (url.Values, error) {
entity, err := h.client.ReportingEntitySelection.Get(ctx.Request().Context(), id)
if err != nil {
return nil, err
}

v := url.Values{}
v.Set("comment", entity.Comment)
return v, err

}

Is anyone able to recreate this issue?

[mikestefanello]

Interesting case. There's only 1 field and since it's immutable, it won't be included. I'd expect this on the setter, not the getter, but there is a check for immutable on the latter; I just can't remember why I included that. Either way, you'll hit this issue one way or another.

It's a bit tricky to fix across both the ent handler plugin and the web handler, but it's certainly doable. A quick fix for you, if you want, is to modify the code-gen template to adjust whichever methods need to be. You can either target the specific type, or count the amount of fields that will be rendered - either way, don't assign the variable entity if it won't be used. Let me know if that works.

A better fix, which I'll work on, is to exclude these methods if they are pointless - and make sure the web side of it is doing the same.

[Jimmy99]

I would imagine that there would be other circumstances in which one would want to exclude an entity from the admin dashboard. Perhaps some "exclude" marker in the schema which would tell the code-gen template to not generate the entity for the admin template? That way you could explicitly include or exclude entities