Remove unstable feature flag

Author: khvzak

.github/workflows/main.yml

@@ -27,7 +27,8 @@ jobs:
       - name: Build ${{ matrix.lua }} vendored
         run: |
           cargo build --features "${{ matrix.lua }},vendored"
-          cargo build --features "${{ matrix.lua }},vendored,async,send,serialize,macros,unstable"
+          cargo build --features "${{ matrix.lua }},vendored,async,serialize,macros"
+          cargo build --features "${{ matrix.lua }},vendored,async,serialize,macros,send"
         shell: bash
       - name: Build ${{ matrix.lua }} pkg-config
         if: ${{ matrix.os == 'ubuntu-22.04' }}
@@ -50,7 +51,7 @@ jobs:
           toolchain: stable
           target: aarch64-apple-darwin
       - name: Cross-compile
-        run: cargo build --target aarch64-apple-darwin --features "${{ matrix.lua }},vendored,async,send,serialize,macros,unstable"
+        run: cargo build --target aarch64-apple-darwin --features "${{ matrix.lua }},vendored,async,send,serialize,macros"
 
   build_aarch64_cross_ubuntu:
     name: Cross-compile to aarch64-unknown-linux-gnu
@@ -71,7 +72,7 @@ jobs:
           sudo apt-get install -y --no-install-recommends gcc-aarch64-linux-gnu libc6-dev-arm64-cross
         shell: bash
       - name: Cross-compile
-        run: cargo build --target aarch64-unknown-linux-gnu --features "${{ matrix.lua }},vendored,async,send,serialize,macros,unstable"
+        run: cargo build --target aarch64-unknown-linux-gnu --features "${{ matrix.lua }},vendored,async,send,serialize,macros"
         shell: bash
 
   build_armv7_cross_ubuntu:
@@ -93,7 +94,7 @@ jobs:
           sudo apt-get install -y --no-install-recommends gcc-arm-linux-gnueabihf libc-dev-armhf-cross
         shell: bash
       - name: Cross-compile
-        run: cargo build --target armv7-unknown-linux-gnueabihf --features "${{ matrix.lua }},vendored,async,send,serialize,macros,unstable"
+        run: cargo build --target armv7-unknown-linux-gnueabihf --features "${{ matrix.lua }},vendored,async,send,serialize,macros"
         shell: bash
 
   test:
@@ -122,14 +123,14 @@ jobs:
       - name: Run ${{ matrix.lua }} tests
         run: |
           cargo test --features "${{ matrix.lua }},vendored"
-          cargo test --features "${{ matrix.lua }},vendored,async,send,serialize,macros"
-          cargo test --features "${{ matrix.lua }},vendored,async,serialize,macros,unstable"
+          cargo test --features "${{ matrix.lua }},vendored,async,serialize,macros"
+          cargo test --features "${{ matrix.lua }},vendored,async,serialize,macros,send"
         shell: bash
       - name: Run compile tests (macos lua54)
         if: ${{ matrix.os == 'macos-latest' && matrix.lua == 'lua54' }}
         run: |
           TRYBUILD=overwrite cargo test --features "${{ matrix.lua }},vendored" -- --ignored
-          TRYBUILD=overwrite cargo test --features "${{ matrix.lua }},vendored,async,send,serialize,macros,unstable" -- --ignored
+          TRYBUILD=overwrite cargo test --features "${{ matrix.lua }},vendored,async,send,serialize,macros" -- --ignored
         shell: bash
 
   test_with_sanitizer:
@@ -153,7 +154,8 @@ jobs:
       - uses: Swatinem/rust-cache@v2
       - name: Run ${{ matrix.lua }} tests with address sanitizer
         run: |
-            cargo test --tests --features "${{ matrix.lua }},vendored,async,send,serialize,macros,unstable" --target x86_64-unknown-linux-gnu -- --skip test_too_many_recursions
+          cargo test --tests --features "${{ matrix.lua }},vendored,async,serialize,macros" --target x86_64-unknown-linux-gnu -- --skip test_too_many_recursions
+          cargo test --tests --features "${{ matrix.lua }},vendored,async,serialize,macros,send" --target x86_64-unknown-linux-gnu -- --skip test_too_many_recursions
         shell: bash
         env:
           RUSTFLAGS: -Z sanitizer=address
@@ -226,8 +228,7 @@ jobs:
       - name: Run ${{ matrix.lua }} tests
         run: |
           cargo test --tests --features "${{ matrix.lua }},vendored"
-          cargo test --tests --features "${{ matrix.lua }},vendored,async,send,serialize,macros"
-          cargo test --tests --features "${{ matrix.lua }},vendored,async,serialize,macros,unstable"
+          cargo test --tests --features "${{ matrix.lua }},vendored,async,serialize,macros"
 
   rustfmt:
     name: Rustfmt
@@ -254,4 +255,4 @@ jobs:
       - uses: giraffate/clippy-action@v1
         with:
           reporter: 'github-pr-review'
-          clippy_flags: --features "${{ matrix.lua }},vendored,async,send,serialize,macros,unstable"
+          clippy_flags: --features "${{ matrix.lua }},vendored,async,send,serialize,macros"

Cargo.toml

@@ -16,7 +16,7 @@ with async/await features and support of writing native Lua modules in Rust.
 """
 
 [package.metadata.docs.rs]
-features = ["lua54", "vendored", "async", "send", "serialize", "macros", "unstable"]
+features = ["lua54", "vendored", "async", "send", "serialize", "macros"]
 rustdoc-args = ["--cfg", "docsrs"]
 
 [workspace]
@@ -41,7 +41,6 @@ async = ["dep:futures-util"]
 send = ["parking_lot/send_guard"]
 serialize = ["dep:serde", "dep:erased-serde", "dep:serde-value"]
 macros = ["mlua_derive/macros"]
-unstable = []
 
 [dependencies]
 mlua_derive = { version = "=0.9.3", optional = true, path = "mlua_derive" }

README.md

@@ -54,7 +54,6 @@ Below is a list of the available feature flags. By default `mlua` does not enabl
 * `serialize`: add serialization and deserialization support to `mlua` types using [serde] framework
 * `macros`: enable procedural macros (such as `chunk!`)
 * `parking_lot`: support UserData types wrapped in [parking_lot]'s primitives (`Arc<Mutex>` and `Arc<RwLock>`)
-* `unstable`: enable **unstable** features. The public API of these features may break between releases.
 
 [5.4]: https://www.lua.org/manual/5.4/manual.html
 [5.3]: https://www.lua.org/manual/5.3/manual.html

src/state.rs

@@ -1292,12 +1292,12 @@ impl Lua {
     }
 
     /// Sets the metatable for a Luau builtin vector type.
-    #[cfg(any(all(feature = "luau", feature = "unstable"), doc))]
-    #[cfg_attr(docsrs, doc(cfg(all(feature = "luau", feature = "unstable"))))]
+    #[cfg(any(feature = "luau", doc))]
+    #[cfg_attr(docsrs, doc(cfg(feature = "luau")))]
     pub fn set_vector_metatable(&self, metatable: Option<Table>) {
         let lua = self.lock();
+        let state = lua.state();
         unsafe {
-            let state = lua.state();
             let _sg = StackGuard::new(state);
             assert_stack(state, 2);
 

tarpaulin.toml

@@ -1,8 +1,8 @@
 [lua54_coverage]
-features = "lua54,vendored,async,serialize,macros,unstable"
+features = "lua54,vendored,async,serialize,macros"
 
 [lua51_coverage]
-features = "lua51,vendored,async,serialize,macros,unstable"
+features = "lua51,vendored,async,serialize,macros"
 
 [luau_coverage]
-features = "luau,async,serialize,macros,unstable"
+features = "luau,async,serialize,macros"

tests/luau.rs

@@ -173,7 +173,7 @@ fn test_vectors() -> Result<()> {
     Ok(())
 }
 
-#[cfg(all(not(feature = "luau-vector4"), feature = "unstable"))]
+#[cfg(not(feature = "luau-vector4"))]
 #[test]
 fn test_vector_metatable() -> Result<()> {
     let lua = Lua::new();