Use "create" prefix consistently.

Author: vbabanin

driver-core/src/test/functional/com/mongodb/ClusterFixture.java

@@ -193,12 +193,12 @@ public static ServerVersion getServerVersion() {
         if (serverVersion == null) {
             serverVersion = getVersion(new CommandReadOperation<>("admin",
                     new BsonDocument("buildInfo", new BsonInt32(1)), new BsonDocumentCodec())
-                    .execute(new ClusterBinding(getCluster(), ReadPreference.nearest()), getOperationContext()));
+                    .execute(new ClusterBinding(getCluster(), ReadPreference.nearest()), createOperationContext()));
         }
         return serverVersion;
     }
 
-    public static OperationContext getOperationContext() {
+    public static OperationContext createOperationContext() {
         return new OperationContext(
                 IgnorableRequestContext.INSTANCE,
                 new ReadConcernAwareNoOpSessionContext(ReadConcern.DEFAULT),
@@ -257,7 +257,7 @@ public static boolean hasEncryptionTestsEnabled() {
     public static Document getServerStatus() {
         return new CommandReadOperation<>("admin", new BsonDocument("serverStatus", new BsonInt32(1)),
                 new DocumentCodec())
-                .execute(getBinding(), getOperationContext());
+                .execute(getBinding(), createOperationContext());
     }
 
     public static boolean supportsFsync() {
@@ -272,7 +272,7 @@ static class ShutdownHook extends Thread {
         public void run() {
             if (cluster != null) {
                 try {
-                    new DropDatabaseOperation(getDefaultDatabaseName(), WriteConcern.ACKNOWLEDGED).execute(getBinding(), getOperationContext());
+                    new DropDatabaseOperation(getDefaultDatabaseName(), WriteConcern.ACKNOWLEDGED).execute(getBinding(), createOperationContext());
                 } catch (MongoCommandException e) {
                     // if we do not have permission to drop the database, assume it is cleaned up in some other way
                     if (!e.getMessage().contains("Command dropDatabase requires authentication")) {
@@ -324,7 +324,7 @@ public static synchronized ConnectionString getConnectionString() {
         try {
             BsonDocument helloResult = new CommandReadOperation<>("admin",
                     new BsonDocument(LEGACY_HELLO, new BsonInt32(1)), new BsonDocumentCodec())
-                    .execute(new ClusterBinding(cluster, ReadPreference.nearest()), getOperationContext());
+                    .execute(new ClusterBinding(cluster, ReadPreference.nearest()), createOperationContext());
             if (helloResult.containsKey("setName")) {
                 connectionString = new ConnectionString(DEFAULT_URI + "/?replicaSet="
                         + helloResult.getString("setName").getValue());
@@ -384,11 +384,11 @@ public static ReadWriteBinding getBinding(final OperationContext operationContex
     }
 
     public static ReadWriteBinding getBinding(final ReadPreference readPreference) {
-        return getBinding(getCluster(), readPreference, getOperationContext());
+        return getBinding(getCluster(), readPreference, createOperationContext());
     }
 
     public static OperationContext createNewOperationContext(final TimeoutSettings timeoutSettings) {
-        return getOperationContext().withTimeoutContext(new TimeoutContext(timeoutSettings));
+        return createOperationContext().withTimeoutContext(new TimeoutContext(timeoutSettings));
     }
 
     private static ReadWriteBinding getBinding(final Cluster cluster,
@@ -405,23 +405,23 @@ private static ReadWriteBinding getBinding(final Cluster cluster,
     }
 
     public static SingleConnectionBinding getSingleConnectionBinding() {
-        return new SingleConnectionBinding(getCluster(), ReadPreference.primary(), getOperationContext());
+        return new SingleConnectionBinding(getCluster(), ReadPreference.primary(), createOperationContext());
     }
 
     public static AsyncSingleConnectionBinding getAsyncSingleConnectionBinding() {
         return getAsyncSingleConnectionBinding(getAsyncCluster());
     }
 
     public static AsyncSingleConnectionBinding getAsyncSingleConnectionBinding(final Cluster cluster) {
-        return new AsyncSingleConnectionBinding(cluster,  ReadPreference.primary(), getOperationContext());
+        return new AsyncSingleConnectionBinding(cluster,  ReadPreference.primary(), createOperationContext());
     }
 
     public static AsyncReadWriteBinding getAsyncBinding(final Cluster cluster) {
         return new AsyncClusterBinding(cluster, ReadPreference.primary());
     }
 
     public static AsyncReadWriteBinding getAsyncBinding() {
-        return getAsyncBinding(getAsyncCluster(), ReadPreference.primary(), getOperationContext());
+        return getAsyncBinding(getAsyncCluster(), ReadPreference.primary(), createOperationContext());
     }
 
     public static AsyncReadWriteBinding getAsyncBinding(final TimeoutSettings timeoutSettings) {
@@ -433,7 +433,7 @@ public static AsyncReadWriteBinding getAsyncBinding(final OperationContext opera
     }
 
     public static AsyncReadWriteBinding getAsyncBinding(final ReadPreference readPreference) {
-        return getAsyncBinding(getAsyncCluster(), readPreference, getOperationContext());
+        return getAsyncBinding(getAsyncCluster(), readPreference, createOperationContext());
     }
 
     public static AsyncReadWriteBinding getAsyncBinding(
@@ -607,7 +607,7 @@ public static BsonDocument getServerParameters() {
         if (serverParameters == null) {
             serverParameters = new CommandReadOperation<>("admin",
                     new BsonDocument("getParameter", new BsonString("*")), new BsonDocumentCodec())
-                    .execute(getBinding(), getOperationContext());
+                    .execute(getBinding(), createOperationContext());
         }
         return serverParameters;
     }
@@ -675,7 +675,7 @@ public static void configureFailPoint(final BsonDocument failPointDocument) {
         if (!isSharded()) {
             try {
                 new CommandReadOperation<>("admin", failPointDocument, new BsonDocumentCodec())
-                        .execute(getBinding(), getOperationContext());
+                        .execute(getBinding(), createOperationContext());
             } catch (MongoCommandException e) {
                 if (e.getErrorCode() == COMMAND_NOT_FOUND_ERROR_CODE) {
                     failsPointsSupported = false;
@@ -691,7 +691,7 @@ public static void disableFailPoint(final String failPoint) {
                     .append("mode", new BsonString("off"));
             try {
                 new CommandReadOperation<>("admin", failPointDocument, new BsonDocumentCodec())
-                        .execute(getBinding(), getOperationContext());
+                        .execute(getBinding(), createOperationContext());
             } catch (MongoCommandException e) {
                 // ignore
             }
@@ -705,7 +705,7 @@ public static <T> T executeSync(final WriteOperation<T> op) {
 
     @SuppressWarnings("overloads")
     public static <T> T executeSync(final WriteOperation<T> op, final ReadWriteBinding binding) {
-        return op.execute(binding, applySessionContext(getOperationContext(), binding.getReadPreference()));
+        return op.execute(binding, applySessionContext(createOperationContext(), binding.getReadPreference()));
     }
 
     @SuppressWarnings("overloads")
@@ -715,7 +715,7 @@ public static <T> T executeSync(final ReadOperation<T, ?> op) {
 
     @SuppressWarnings("overloads")
     public static <T> T executeSync(final ReadOperation<T, ?> op, final ReadWriteBinding binding) {
-        return op.execute(binding, getOperationContext());
+        return op.execute(binding, createOperationContext());
     }
 
     @SuppressWarnings("overloads")
@@ -731,7 +731,7 @@ public static <T> T executeAsync(final WriteOperation<T> op) throws Throwable {
     @SuppressWarnings("overloads")
     public static <T> T executeAsync(final WriteOperation<T> op, final AsyncReadWriteBinding binding) throws Throwable {
         FutureResultCallback<T> futureResultCallback = new FutureResultCallback<>();
-        op.executeAsync(binding, applySessionContext(getOperationContext(), binding.getReadPreference()), futureResultCallback);
+        op.executeAsync(binding, applySessionContext(createOperationContext(), binding.getReadPreference()), futureResultCallback);
         return futureResultCallback.get(TIMEOUT, SECONDS);
     }
 
@@ -743,7 +743,7 @@ public static <T> T executeAsync(final ReadOperation<?, T> op) throws Throwable
     @SuppressWarnings("overloads")
     public static <T> T executeAsync(final ReadOperation<?, T> op, final AsyncReadBinding binding) throws Throwable {
         FutureResultCallback<T> futureResultCallback = new FutureResultCallback<>();
-        op.executeAsync(binding, getOperationContext(), futureResultCallback);
+        op.executeAsync(binding, createOperationContext(), futureResultCallback);
         return futureResultCallback.get(TIMEOUT, SECONDS);
     }
 
@@ -813,19 +813,19 @@ public static <T> List<T> collectCursorResults(final BatchCursor<T> batchCursor)
 
     public static AsyncConnectionSource getWriteConnectionSource(final AsyncReadWriteBinding binding) throws Throwable {
         FutureResultCallback<AsyncConnectionSource> futureResultCallback = new FutureResultCallback<>();
-        binding.getWriteConnectionSource(getOperationContext(), futureResultCallback);
+        binding.getWriteConnectionSource(createOperationContext(), futureResultCallback);
         return futureResultCallback.get(TIMEOUT, SECONDS);
     }
 
     public static AsyncConnectionSource getReadConnectionSource(final AsyncReadWriteBinding binding) throws Throwable {
         FutureResultCallback<AsyncConnectionSource> futureResultCallback = new FutureResultCallback<>();
-        binding.getReadConnectionSource(getOperationContext(), futureResultCallback);
+        binding.getReadConnectionSource(createOperationContext(), futureResultCallback);
         return futureResultCallback.get(TIMEOUT, SECONDS);
     }
 
     public static AsyncConnection getConnection(final AsyncConnectionSource source) throws Throwable {
         FutureResultCallback<AsyncConnection> futureResultCallback = new FutureResultCallback<>();
-        source.getConnection(getOperationContext(), futureResultCallback);
+        source.getConnection(createOperationContext(), futureResultCallback);
         return futureResultCallback.get(TIMEOUT, SECONDS);
     }
 
@@ -868,7 +868,7 @@ private static OperationContext applySessionContext(final OperationContext opera
         return operationContext.withSessionContext(simpleSessionContext);
     }
 
-    public static OperationContext getOperationContext(final ReadPreference readPreference) {
-        return applySessionContext(getOperationContext(), readPreference);
+    public static OperationContext createOperationContext(final ReadPreference readPreference) {
+        return applySessionContext(createOperationContext(), readPreference);
     }
 }

driver-core/src/test/functional/com/mongodb/OperationFunctionalSpecification.groovy

@@ -61,7 +61,7 @@ import spock.lang.Specification
 
 import java.util.concurrent.TimeUnit
 
-import static com.mongodb.ClusterFixture.getOperationContext
+import static com.mongodb.ClusterFixture.createOperationContext
 import static com.mongodb.ClusterFixture.TIMEOUT
 import static com.mongodb.ClusterFixture.checkReferenceCountReachesTarget
 import static com.mongodb.ClusterFixture.executeAsync
@@ -108,7 +108,7 @@ class OperationFunctionalSpecification extends Specification {
 
     void acknowledgeWrite(final SingleConnectionBinding binding) {
         new MixedBulkWriteOperation(getNamespace(), [new InsertRequest(new BsonDocument())], true,
-                ACKNOWLEDGED, false).execute(binding, getOperationContext())
+                ACKNOWLEDGED, false).execute(binding, createOperationContext())
         binding.release()
     }
 
@@ -279,7 +279,7 @@ class OperationFunctionalSpecification extends Specification {
                           BsonDocument expectedCommand=null, Boolean checkSecondaryOk=false,
                           ReadPreference readPreference=ReadPreference.primary(), Boolean retryable = false,
                           ServerType serverType = ServerType.STANDALONE, Boolean activeTransaction = false) {
-        def operationContext = getOperationContext()
+        def operationContext = createOperationContext()
                 .withSessionContext(Stub(SessionContext) {
                     hasActiveTransaction() >> activeTransaction
                     getReadConcern() >> readConcern
@@ -353,7 +353,7 @@ class OperationFunctionalSpecification extends Specification {
                            Boolean checkCommand = true, BsonDocument expectedCommand = null, Boolean checkSecondaryOk = false,
                            ReadPreference readPreference = ReadPreference.primary(), Boolean retryable = false,
                            ServerType serverType = ServerType.STANDALONE, Boolean activeTransaction = false) {
-        def operationContext = getOperationContext()
+        def operationContext = createOperationContext()
                 .withSessionContext(Stub(SessionContext) {
                     hasActiveTransaction() >> activeTransaction
                     getReadConcern() >> readConcern
@@ -447,7 +447,7 @@ class OperationFunctionalSpecification extends Specification {
             }
         }
 
-        def operationContext = getOperationContext().withSessionContext(
+        def operationContext = createOperationContext().withSessionContext(
                 Stub(SessionContext) {
                     hasSession() >> true
                     hasActiveTransaction() >> false
@@ -488,7 +488,7 @@ class OperationFunctionalSpecification extends Specification {
             }
         }
 
-        def operationContext = getOperationContext().withSessionContext(
+        def operationContext = createOperationContext().withSessionContext(
                 Stub(SessionContext) {
                     hasSession() >> true
                     hasActiveTransaction() >> false