Skip to content

Commit aea251f

Browse files
authored
Update Junit 5 to latest (#1909)
Test Scala 3 on Java 8 JAVA-6125
1 parent 2e24eb6 commit aea251f

6 files changed

Lines changed: 22 additions & 27 deletions

File tree

.evergreen/.evg.yml

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -2507,23 +2507,14 @@ buildvariants:
25072507
tasks:
25082508
- name: ".ocsp"
25092509

2510-
- matrix_name: "scala-tests-2"
2510+
- matrix_name: "scala-tests"
25112511
matrix_spec: { auth: "noauth", ssl: "nossl", jdk: [ "jdk8", "jdk17", "jdk21" ], version: [ "7.0" ], topology: "replicaset",
2512-
scala: ["2.11", "2.12", "2.13"] , os: "ubuntu" }
2512+
scala: "*" , os: "ubuntu" }
25132513
display_name: "${scala} ${jdk} ${version} ${topology} ${os}"
25142514
tags: [ "test-scala-variant" ]
25152515
tasks:
25162516
- name: "scala-test-task"
25172517

2518-
- matrix_name: "scala-tests-3"
2519-
matrix_spec: { auth: "noauth", ssl: "nossl", jdk: [ "jdk17", "jdk21" ], version: [ "8.0" ], topology: "replicaset",
2520-
scala: "3", os: "ubuntu" }
2521-
display_name: "${scala} ${jdk} ${version} ${topology} ${os}"
2522-
tags: [ "test-scala-variant" ]
2523-
tasks:
2524-
- name: "scala-test-task"
2525-
2526-
25272518
- matrix_name: "kotlin-tests"
25282519
matrix_spec: { auth: "noauth", ssl: "nossl", jdk: [ "jdk8", "jdk17", "jdk21" ], version: [ "7.0" ], topology: "replicaset", os: "ubuntu" }
25292520
display_name: "Kotlin: ${jdk} ${version} ${topology} ${os}"

driver-core/src/test/functional/com/mongodb/test/AfterBeforeParameterResolver.java

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -71,11 +71,16 @@ public class AfterBeforeParameterResolver implements BeforeEachMethodAdapter, Pa
7171
public void invokeBeforeEachMethod(final ExtensionContext context, final ExtensionRegistry registry) {
7272
Optional<ParameterResolver> resolverOptional = registry.getExtensions(ParameterResolver.class)
7373
.stream()
74-
.filter(parameterResolver -> parameterResolver.getClass().getName().contains("ParameterizedTestParameterResolver"))
74+
.filter(parameterResolver -> {
75+
String name = parameterResolver.getClass().getName();
76+
// JUnit 5.14+: ParameterizedInvocationParameterResolver, ParameterizedTestMethodParameterResolver
77+
return name.contains("ParameterizedInvocationParameterResolver")
78+
|| name.contains("ParameterizedTestMethodParameterResolver");
79+
})
7580
.findFirst();
7681
if (!resolverOptional.isPresent()) {
77-
throw new IllegalStateException("ParameterizedTestParameterResolver missed in the registry. "
78-
+ "Probably it's not a Parameterized Test");
82+
throw new IllegalStateException("ParameterResolver not found. Confirm the test is a Parameterized test. "
83+
+ "See `com.mongodb.test.AfterBeforeParameterResolver` for more details.");
7984
} else {
8085
parameterisedTestParameterResolver = resolverOptional.get();
8186
}

driver-scala/src/integrationTest/scala/org/mongodb/scala/unified/ClientEncryptionTest.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,6 @@
1616

1717
package org.mongodb.scala.unified
1818

19-
object ClientEncryptionTest extends UnifiedTest {
19+
class ClientEncryptionTest extends UnifiedTest {
2020
val directory = "client-side-encryption/tests/unified"
2121
}

driver-scala/src/integrationTest/scala/org/mongodb/scala/unified/UnifiedCrudTest.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,6 @@
1616

1717
package org.mongodb.scala.unified
1818

19-
object UnifiedCrudTest extends UnifiedTest {
19+
class UnifiedCrudTest extends UnifiedTest {
2020
val directory = "crud"
2121
}

driver-scala/src/integrationTest/scala/org/mongodb/scala/unified/UnifiedTest.scala

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -49,15 +49,13 @@ abstract class UnifiedTest extends JUnifiedTest {
4949
override def createClientEncryption(
5050
keyVaultClient: JMongoClient,
5151
clientEncryptionSettings: JClientEncryptionSettings
52-
): JClientEncryption = {
53-
keyVaultClient match {
54-
case client: SyncMongoClient =>
55-
SyncClientEncryption(ClientEncryption(new ClientEncryptionImpl(
56-
client.wrapped.wrapped,
57-
clientEncryptionSettings
58-
)))
59-
case _ => throw new IllegalArgumentException(s"Invalid keyVaultClient type: ${keyVaultClient.getClass}")
60-
}
52+
): JClientEncryption = keyVaultClient match {
53+
case client: SyncMongoClient =>
54+
SyncClientEncryption(ClientEncryption(new ClientEncryptionImpl(
55+
client.wrapped.wrapped,
56+
clientEncryptionSettings
57+
)))
58+
case _ => throw new IllegalArgumentException(s"Invalid keyVaultClient type: ${keyVaultClient.getClass}")
6159
}
6260

6361
override protected def isReactive: Boolean = true

gradle/libs.versions.toml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ findbugs-jsr = "1.3.9"
4747
groovy = "3.0.9"
4848
hamcrest = "1.3"
4949
jmh = "1.37"
50-
junit-bom = "5.10.2"
50+
junit-bom = "5.14.3"
5151
logback = "1.3.14"
5252
mockito = "5.11.0"
5353
mockito-java8 = "4.6.1"
@@ -131,6 +131,7 @@ jmh-generator-annprocess = { module = "org.openjdk.jmh:jmh-generator-annprocess"
131131
junit-bom = { module = "org.junit:junit-bom", version.ref = "junit-bom" }
132132
junit-jupiter = { module = "org.junit.jupiter:junit-jupiter" }
133133
junit-jupiter-params = { module = "org.junit.jupiter:junit-jupiter-params" }
134+
junit-jupiter-platform-launcher = { module = "org.junit.platform:junit-platform-launcher" }
134135
junit-jupiter-engine = { module = "org.junit.jupiter:junit-jupiter-engine" }
135136
junit-vintage-engine = { module = "org.junit.vintage:junit-vintage-engine" }
136137
junit-kotlin = { module = "org.jetbrains.kotlin:kotlin-test-junit5" }
@@ -197,7 +198,7 @@ scala-v2-v12 = ["scala-library-v2-v12", "scala-reflect-v2-v12"]
197198
scala-v2-v11 = ["scala-library-v2-v11", "scala-reflect-v2-v11"]
198199

199200
# Test
200-
junit = ["junit-jupiter", "junit-jupiter-params", "junit-jupiter-engine", "logback-classic", "hamcrest-all"]
201+
junit = ["junit-jupiter", "junit-jupiter-params", "junit-jupiter-engine", "junit-jupiter-platform-launcher", "logback-classic", "hamcrest-all"]
201202
junit-vintage = ["junit-vintage-engine", "junit-jupiter-params", "junit-jupiter-engine", "logback-classic", "hamcrest-all"]
202203
spock = ["spock-core", "spock-junit4"]
203204

0 commit comments

Comments
 (0)