Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

Commit c5f7378

Browse files
committed
Bug 1735396 - Update test_archive.py expected file hashes when running on Python 3.9 or newer r=jmaher
Differential Revision: https://phabricator.services.mozilla.com/D128294
1 parent 4725f91 commit c5f7378

1 file changed

Lines changed: 36 additions & 5 deletions

File tree

python/mozbuild/mozpack/test/test_archive.py

Lines changed: 36 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,8 @@
1414

1515
import pytest
1616

17+
import sys
18+
1719
from mozpack.archive import (
1820
DEFAULT_MTIME,
1921
create_tar_from_files,
@@ -115,8 +117,16 @@ def test_create_tar_basic(self):
115117
with open(tp, "wb") as fh:
116118
create_tar_from_files(fh, files)
117119

118-
# Output should be deterministic.
119-
self.assertEqual(file_hash(tp), "01cd314e277f060e98c7de6c8ea57f96b3a2065c")
120+
# Output should be deterministic. Checking for Python version because of Bug 1735396.
121+
if sys.version_info.major == 3 and sys.version_info.minor <= 8:
122+
self.assertEqual(
123+
file_hash(tp), "01cd314e277f060e98c7de6c8ea57f96b3a2065c"
124+
)
125+
# The else statement below assumes Python 3.9 and newer.
126+
else:
127+
self.assertEqual(
128+
file_hash(tp), "50fe1aaadf0d44abb69bdea174b4dd6cdb4f4898"
129+
)
120130

121131
with tarfile.open(tp, "r") as tf:
122132
self._verify_basic_tarfile(tf)
@@ -155,7 +165,14 @@ def test_create_tar_gz_basic(self):
155165
with open(gp, "wb") as fh:
156166
create_tar_gz_from_files(fh, files)
157167

158-
self.assertEqual(file_hash(gp), "7c4da5adc5088cdf00911d5daf9a67b15de714b7")
168+
if sys.version_info.major == 3 and sys.version_info.minor <= 8:
169+
self.assertEqual(
170+
file_hash(gp), "7c4da5adc5088cdf00911d5daf9a67b15de714b7"
171+
)
172+
else:
173+
self.assertEqual(
174+
file_hash(gp), "766117873af9754915ee93c56243616d000d7e5e"
175+
)
159176

160177
with tarfile.open(gp, "r:gz") as tf:
161178
self._verify_basic_tarfile(tf)
@@ -172,7 +189,14 @@ def test_tar_gz_name(self):
172189
with open(gp, "wb") as fh:
173190
create_tar_gz_from_files(fh, files, filename="foobar")
174191

175-
self.assertEqual(file_hash(gp), "721e00083c17d16df2edbddf40136298c06d0c49")
192+
if sys.version_info.major == 3 and sys.version_info.minor <= 8:
193+
self.assertEqual(
194+
file_hash(gp), "721e00083c17d16df2edbddf40136298c06d0c49"
195+
)
196+
else:
197+
self.assertEqual(
198+
file_hash(gp), "059916c8e6b6f22be774dc56aabb3819460fee53"
199+
)
176200

177201
with tarfile.open(gp, "r:gz") as tf:
178202
self._verify_basic_tarfile(tf)
@@ -189,7 +213,14 @@ def test_create_tar_bz2_basic(self):
189213
with open(bp, "wb") as fh:
190214
create_tar_bz2_from_files(fh, files)
191215

192-
self.assertEqual(file_hash(bp), "eb5096d2fbb71df7b3d690001a6f2e82a5aad6a7")
216+
if sys.version_info.major == 3 and sys.version_info.minor <= 8:
217+
self.assertEqual(
218+
file_hash(bp), "eb5096d2fbb71df7b3d690001a6f2e82a5aad6a7"
219+
)
220+
else:
221+
self.assertEqual(
222+
file_hash(bp), "600883e25722fdde5eb78c6c40955ab80b7ac114"
223+
)
193224

194225
with tarfile.open(bp, "r:bz2") as tf:
195226
self._verify_basic_tarfile(tf)

0 commit comments

Comments
 (0)