Merge pull request #61 from mrikirill/feature/release-action-install-update

GitHub Actions workflow for release process

Author: mrikirill

.github/workflows/release.yml

@@ -0,0 +1,53 @@
+name: Release
+
+on:
+  workflow_dispatch:
+    inputs:
+      version:
+        description: 'Release version (e.g. 1.0.0)'
+        required: true
+
+permissions:
+  contents: write
+
+jobs:
+  test:
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v4
+
+    - name: Validate composer.json
+      run: composer validate
+
+    - name: Cache Composer packages
+      id: composer-cache
+      uses: actions/cache@v3
+      with:
+        path: vendor
+        key: ${{ runner.os }}-php-${{ hashFiles('**/composer.lock') }}
+        restore-keys: |
+          ${{ runner.os }}-php-
+
+    - name: Install dependencies
+      run: composer install --prefer-dist --no-progress
+
+    - name: Run test suite
+      run: vendor/bin/phpunit tests
+
+  release:
+    needs: test
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v4
+
+      - name: Update version in cloudflare.php
+        run: sed -i "s/@version .*/@version ${{ github.event.inputs.version }}/" cloudflare.php
+
+      - name: Create Release
+        uses: softprops/action-gh-release@v1
+        with:
+          tag_name: v${{ github.event.inputs.version }}
+          name: Release v${{ github.event.inputs.version }}
+          files: cloudflare.php
+          generate_release_notes: true

README.md

@@ -6,8 +6,8 @@
 > Documentation website: https://mrikirill.github.io/SynologyDDNSCloudflareMultidomain/
 > 
 > [![Sponsor](https://img.shields.io/badge/sponsor-GitHub%20Sponsors-brightgreen)](https://github.com/sponsors/mrikirill)
-
-📢 *Check out the new native version of this agent, written in Kotlin -> [KTSynologyDDNSCloudflareMultidomain](https://github.com/mrikirill/KTSynologyDDNSCloudflareMultidomain)* 
+>
+> 📢 **Check out the new native version of this agent, written in Kotlin -> [KTSynologyDDNSCloudflareMultidomain](https://github.com/mrikirill/KTSynologyDDNSCloudflareMultidomain)** 
 
 ## Table of contents
 
@@ -81,7 +81,24 @@ For assistance with vi commands, see:
 
 ## How to install
 
-### Method 1: via SSH
+### Method 1: via Task Scheduler (Recommended - No SSH required)
+
+1. Open **Control Panel** > **Task Scheduler**.
+2. Click **Create** > **Scheduled Task** > **User-defined script**.
+3. In the **General** tab:
+    *   **Task**: Install Cloudflare DDNS
+    *   **User**: `root` **(Important!)**
+    *   Uncheck "Enabled" (we only need to run this once).
+4. In the **Task Settings** tab:
+    *   **Run command**:
+        ```bash
+        wget https://raw.githubusercontent.com/mrikirill/SynologyDDNSCloudflareMultidomain/master/install.sh -O /tmp/install.sh && bash /tmp/install.sh
+        ```
+5. Click **OK**.
+6. Select the newly created task and click **Run**.
+7. Once the task has finished (you can check via Action > View Result), you can delete the task.
+
+### Method 2: via SSH
 
 1. **SSH with root privileges on your supported device:**
 
@@ -109,8 +126,11 @@ For assistance with vi commands, see:
   ```
 
 	**Note:** For SRM users, you must connect to your device as root. No other username will allow these commands to run.
+    **Don't forget to deactivate SSH (step 1) if you don't need it.** Leaving it active can be a security risk.
 
-3. **Update your DDNS settings:** 
+### Configure DDNS (Required for both methods)
+
+**Update your DDNS settings:** 
 
 	 a. *For DSM Users:* Navigate to __Control Panel > External Access > DDNS__ then add new DDNS
 	 
@@ -132,26 +152,7 @@ For multiple domains: __subdomain.mydomain.com|vpn.mydomain.com__
 
 	Finally, press the test connection button to confirm all information is correctly entered, before pressing Ok to save and confirm your details.
 
-4. Don't forget to deactivate SSH (step 1) if you don't need it. Leaving it active can be a security risk.
-5. You're done! Optional, if you're happy with this script you could buy me ☕ or 🍺 here -> [![Sponsor](https://img.shields.io/badge/sponsor-GitHub%20Sponsors-brightgreen)](https://github.com/sponsors/mrikirill)
-
-### Method 2: via Task Scheduler (No SSH required)
-
-1. Open **Control Panel** > **Task Scheduler**.
-2. Click **Create** > **Scheduled Task** > **User-defined script**.
-3. In the **General** tab:
-    *   **Task**: Install Cloudflare DDNS
-    *   **User**: `root` **(Important!)**
-    *   Uncheck "Enabled" (we only need to run this once).
-4. In the **Task Settings** tab:
-    *   **Run command**:
-        ```bash
-        wget https://raw.githubusercontent.com/mrikirill/SynologyDDNSCloudflareMultidomain/master/install.sh -O /tmp/install.sh && bash /tmp/install.sh
-        ```
-5. Click **OK**.
-6. Select the newly created task and click **Run**.
-7. Once the task has finished (you can check via Action > View Result), you can delete the task.
-8. Proceed to **Step 3** in Method 1 above to configure the DDNS settings in Control Panel.
+4. You're done! Optional, if you're happy with this script you could buy me ☕ or 🍺 here -> [![Sponsor](https://img.shields.io/badge/sponsor-GitHub%20Sponsors-brightgreen)](https://github.com/sponsors/mrikirill)
 
 ## Troubleshooting and known issues
 

install.sh

@@ -1,7 +1,7 @@
 #!/bin/bash
 
 # Define constants
-PHP_FILE_URL="https://raw.githubusercontent.com/mrikirill/SynologyDDNSCloudflareMultidomain/master/cloudflare.php"
+PHP_FILE_URL="https://github.com/mrikirill/SynologyDDNSCloudflareMultidomain/releases/latest/download/cloudflare.php"
 PHP_FILE_DEST="/usr/syno/bin/ddns/cloudflare.php"
 TEMP_FILE="/tmp/cloudflare.php"
 DDNS_PROVIDER_CONF="/etc.defaults/ddns_provider.conf"
@@ -24,14 +24,16 @@ print_message "Changing permissions of cloudflare.php..."
 sudo chmod 755 $PHP_FILE_DEST
 
 # Step 4: Insert Cloudflare configuration into ddns_provider.conf
-print_message "Adding Cloudflare configuration to ddns_provider.conf..."
+print_message "Updating Cloudflare configuration in ddns_provider.conf..."
 if grep -q "\[Cloudflare\]" $DDNS_PROVIDER_CONF; then
-    print_message "Cloudflare configuration already exists in ddns_provider.conf. Skipping..."
-else
-    sudo bash -c "echo -e \"$CLOUDFLARE_ENTRY\" >> $DDNS_PROVIDER_CONF"
-    print_message "Cloudflare configuration added successfully."
+    print_message "Removing old Cloudflare configuration..."
+    sudo sed -i '/^\[Cloudflare\]/,/^\[/ { /^\[Cloudflare\]/d; /^\[/!d; }' "$DDNS_PROVIDER_CONF"
 fi
 
+print_message "Adding new Cloudflare configuration..."
+sudo bash -c "echo -e \"$CLOUDFLARE_ENTRY\" >> $DDNS_PROVIDER_CONF"
+print_message "Cloudflare configuration updated successfully."
+
 # Clean up temporary file
 rm $TEMP_FILE