Skip to content

Commit 998c38f

Browse files
committed
Fix multiEditCore.php: align isOrdeable → isOrderable with JS return value
The rename of the elementOptions key from "ordeable" to "orderable" (part of #1584) updated handleElementOptions() in settings_utils.js to return the property as isOrderable. However, multiEditCore.php still destructured the old name isOrdeable from that return value (line 139). Because JavaScript object destructuring resolves properties by name, isOrdeable would silently evaluate to undefined — no runtime error, just a broken binding. The bug was masked because isOrdeable is not referenced after destructuring in the current code of multiEditCore.php. The incorrect binding would become a functional regression as soon as that code path is extended to actually consume the orderable flag (e.g. to conditionally apply select2 sorting in the multi-edit form). Changes: - front/multiEditCore.php:139 — isOrdeable → isOrderable Aligns the destructured property name with the renamed return key of handleElementOptions() so the binding resolves to the correct boolean value instead of undefined. All 35 previously updated files already use the correct spelling; this was the single remaining inconsistency. After this commit, grep for "isOrdeable" and "ordeable" across front/ and server/ returns zero results.
1 parent 4c117db commit 998c38f

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

front/multiEditCore.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,7 @@ function getData(){
136136
inputType,
137137
readOnly,
138138
isMultiSelect,
139-
isOrdeable,
139+
isOrderable,
140140
cssClasses,
141141
placeholder,
142142
suffix,

0 commit comments

Comments
 (0)