Merge branch 'main' of github.com:netalertx/NetAlertX

Author: jokob-sk

.github/skills/code-standards/SKILL.md

@@ -5,12 +5,12 @@ description: NetAlertX coding standards and conventions. Use this when writing c
 
 # Code Standards
 
-- ask me to review before going to each next step (mention n step out of x)
-- before starting, prepare implementation plan
+- ask me to review before going to each next step (mention n step out of x)  (AI only)
+- before starting, prepare implementation plan  (AI only)
 - ask me to review it and ask any clarifying questions first
 - add test creation as last step - follow repo architecture patterns - do not place in the root of /test
 - code has to be maintainable, no duplicate code
-- follow DRY principle
+- follow DRY principle - maintainability of code is more important than speed of implementation
 - code files should be less than 500 LOC for better maintainability
 
 ## File Length

.github/workflows/run-all-tests.yml

@@ -3,6 +3,10 @@ name: 🧪 Manual Test Suite Selector
 on:
   workflow_dispatch:
     inputs:
+      run_all:
+        description: '✅ Run ALL tests (overrides individual selectors)'
+        type: boolean
+        default: false
       run_scan:
         description: '📂 scan/ (Scan, Logic, Locks, IPs)'
         type: boolean
@@ -23,6 +27,10 @@ on:
         description: '📂 ui/ (Selenium & Dashboard)'
         type: boolean
         default: false
+      run_plugins:
+        description: '📂 plugins/ (Sync insert schema-aware logic)'
+        type: boolean
+        default: false
       run_root_files:
         description: '📄 Root Test Files (WOL, Atomicity, etc.)'
         type: boolean
@@ -42,12 +50,20 @@ jobs:
         id: builder
         run: |
           PATHS=""
+
+          # run_all overrides everything
+          if [ "${{ github.event.inputs.run_all }}" == "true" ]; then
+            echo "final_paths=test/" >> $GITHUB_OUTPUT
+            exit 0
+          fi
+
           # Folder Mapping with 'test/' prefix
           if [ "${{ github.event.inputs.run_scan }}" == "true" ]; then PATHS="$PATHS test/scan/"; fi
           if [ "${{ github.event.inputs.run_api }}" == "true" ]; then PATHS="$PATHS test/api_endpoints/ test/server/"; fi
           if [ "${{ github.event.inputs.run_backend }}" == "true" ]; then PATHS="$PATHS test/backend/ test/db/"; fi
           if [ "${{ github.event.inputs.run_docker_env }}" == "true" ]; then PATHS="$PATHS test/docker_tests/"; fi
           if [ "${{ github.event.inputs.run_ui }}" == "true" ]; then PATHS="$PATHS test/ui/"; fi
+          if [ "${{ github.event.inputs.run_plugins }}" == "true" ]; then PATHS="$PATHS test/plugins/"; fi
 
           # Root Files Mapping (files sitting directly in /test/)
           if [ "${{ github.event.inputs.run_root_files }}" == "true" ]; then

CONTRIBUTING.md

@@ -1,23 +1,23 @@
-# 🤝 Contributing to NetAlertX
+# Contributing to NetAlertX
 
 First off, **thank you** for taking the time to contribute! NetAlertX is built and improved with the help of passionate people like you.
 
 ---
 
-## 📂 Issues, Bugs, and Feature Requests
+## Issues, Bugs, and Feature Requests
 
 Please use the [GitHub Issue Tracker](https://github.com/netalertx/NetAlertX/issues) for:
-- Bug reports 🐞
-- Feature requests 💡
-- Documentation feedback 📖
+- Bug reports
+- Feature requests
+- Documentation feedback
 
 Before opening a new issue:
-- 🛑 [Check Common Issues & Debug Tips](https://docs.netalertx.com/DEBUG_TIPS#common-issues)
-- 🔍 [Search Closed Issues](https://github.com/netalertx/NetAlertX/issues?q=is%3Aissue+is%3Aclosed)
+- [Check Common Issues & Debug Tips](https://docs.netalertx.com/DEBUG_TIPS#common-issues)
+- [Search Closed Issues](https://github.com/netalertx/NetAlertX/issues?q=is%3Aissue+is%3Aclosed)
 
 ---
 
-## 🚀 Submitting Pull Requests (PRs)
+## Submitting Pull Requests (PRs)
 
 We welcome PRs to improve the code, docs, or UI!
 
@@ -29,25 +29,30 @@ Please:
 - If relevant, add or update tests and documentation
 - For plugins, refer to the [Plugin Dev Guide](https://docs.netalertx.com/PLUGINS_DEV)
 
+
+## Code quality
+
+- read and follow the [code-standards](/.github/skills/code-standards/SKILL.md)
+
 ---
 
-## 🌟 First-Time Contributors
+## First-Time Contributors
 
 New to open source? Check out these resources:
 - [How to Fork and Submit a PR](https://opensource.guide/how-to-contribute/)
 - Ask questions or get support in our [Discord](https://discord.gg/NczTUTWyRr)
 
 ---
 
-## 🔐 Code of Conduct
+## Code of Conduct
 
 By participating, you agree to follow our [Code of Conduct](./CODE_OF_CONDUCT.md), which ensures a respectful and welcoming community.
 
 ---
 
-## 📬 Contact
+## Contact
 
 If you have more in-depth questions or want to discuss contributing in other ways, feel free to reach out at:
-📧 [jokob@duck.com](mailto:jokob@duck.com?subject=NetAlertX%20Contribution)
+[jokob.sk@gmail.com](mailto:jokob.sk@gmail.com?subject=NetAlertX%20Contribution)
 
 We appreciate every contribution, big or small! 💙

front/devices.php

@@ -624,6 +624,10 @@ function hasEnabledDeviceScanners() {
 // Update the title-bar ETA subtitle and the DataTables empty-state message.
 // Called on every nax:scanEtaUpdate; the inner ticker keeps the title bar live between events.
 function updateScanEtaDisplay(nextScanTime, currentState) {
+  // Detect scan-finished transition BEFORE updating _currentStateAnchor.
+  // justFinishedScanning is true only when the backend transitions scanning → idle.
+  var justFinishedScanning = (currentState === 'Process: Idle') && isScanningState(_currentStateAnchor);
+
   // Prefer the backend-computed values; keep previous anchors if not yet received.
   _nextScanTimeAnchor = nextScanTime || _nextScanTimeAnchor;
   _currentStateAnchor = currentState || _currentStateAnchor;
@@ -670,6 +674,13 @@ function tickTitleBar() {
       // Patch the visible cell text without triggering a server-side AJAX reload.
       $('#tableDevices tbody .dataTables_empty').html(newEmptyMsg);
     }
+
+    // When scanning just finished and the table is still empty, reload data so
+    // newly discovered devices appear automatically. Skip reload if there are
+    // already rows — no need to disturb the user's current view.
+    if (justFinishedScanning && dt.page.info().recordsTotal === 0) {
+      dt.ajax.reload(null, false); // false = keep current page position
+    }
   }
 
   tickTitleBar();

front/php/templates/language/fr_fr.json

@@ -139,7 +139,7 @@
     "DevDetail_SessionTable_Duration": "Durée",
     "DevDetail_SessionTable_IP": "IP",
     "DevDetail_SessionTable_Order": "Ordre",
-    "DevDetail_Shortcut_CurrentStatus": "État actuel",
+    "DevDetail_Shortcut_CurrentStatus": "État",
     "DevDetail_Shortcut_DownAlerts": "Alertes de panne",
     "DevDetail_Shortcut_Presence": "Présence",
     "DevDetail_Shortcut_Sessions": "Sessions",
@@ -203,16 +203,16 @@
     "Device_MultiEdit_MassActions": "Actions en masse :",
     "Device_MultiEdit_No_Devices": "Aucun appareil sélectionné.",
     "Device_MultiEdit_Tooltip": "Attention. Ceci va appliquer la valeur de gauche à tous les appareils sélectionnés au-dessus.",
-    "Device_NextScan_Imminent": "",
-    "Device_NextScan_In": "",
-    "Device_NoData_Help": "",
-    "Device_NoData_Scanning": "",
-    "Device_NoData_Title": "",
+    "Device_NextScan_Imminent": "Imminent...",
+    "Device_NextScan_In": "Prochain scan dans ",
+    "Device_NoData_Help": "Si les appareils n'apparaissent pas après le scan, vérifiez vos paramètres SCAN_SUBNETS et la <a href=\"https://docs.netalertx.com/SUBNETS\" target=\"_blank\">documentation</a>.",
+    "Device_NoData_Scanning": "En attente du premier scan - cela peut prendre quelques minutes après le premier paramétrage.",
+    "Device_NoData_Title": "Aucun appareil trouvé pour le moment",
     "Device_Save_Failed": "Erreur à l'enregistrement de l'appareil",
     "Device_Save_Unauthorized": "Non autorisé - Jeton d'API invalide",
     "Device_Saved_Success": "Appareil enregistré avec succès",
     "Device_Saved_Unexpected": "La mise à jour de l'appareil a renvoyé une réponse inattendue",
-    "Device_Scanning": "",
+    "Device_Scanning": "Scan en cours...",
     "Device_Searchbox": "Rechercher",
     "Device_Shortcut_AllDevices": "Mes appareils",
     "Device_Shortcut_AllNodes": "Tous les nœuds",
@@ -322,7 +322,7 @@
     "Gen_AddDevice": "Ajouter un appareil",
     "Gen_Add_All": "Ajouter tous",
     "Gen_All_Devices": "Tous les appareils",
-    "Gen_Archived": "",
+    "Gen_Archived": "Archivés",
     "Gen_AreYouSure": "Êtes-vous sûr ?",
     "Gen_Backup": "Lancer la sauvegarde",
     "Gen_Cancel": "Annuler",
@@ -333,7 +333,7 @@
     "Gen_Delete": "Supprimer",
     "Gen_DeleteAll": "Supprimer tous",
     "Gen_Description": "Description",
-    "Gen_Down": "",
+    "Gen_Down": "Bas",
     "Gen_Error": "Erreur",
     "Gen_Filter": "Filtrer",
     "Gen_Flapping": "",
@@ -342,7 +342,7 @@
     "Gen_Invalid_Value": "Une valeur invalide a été renseignée",
     "Gen_LockedDB": "Erreur - La base de données est peut-être verrouillée - Vérifier avec les outils de dév via F12 -> Console ou essayer plus tard.",
     "Gen_NetworkMask": "Masque réseau",
-    "Gen_New": "",
+    "Gen_New": "Nouveau",
     "Gen_Offline": "Hors ligne",
     "Gen_Okay": "OK",
     "Gen_Online": "En ligne",
@@ -360,7 +360,7 @@
     "Gen_SelectIcon": "<i class=\"fa-solid fa-chevron-down fa-fade\"></i>",
     "Gen_SelectToPreview": "Sélectionnez pour prévisualiser",
     "Gen_Selected_Devices": "Appareils sélectionnés :",
-    "Gen_Sleeping": "",
+    "Gen_Sleeping": "Inactif",
     "Gen_Subnet": "Sous-réseau",
     "Gen_Switch": "Basculer",
     "Gen_Upd": "Mise à jour réussie",
@@ -804,4 +804,4 @@
     "settings_system_label": "Système",
     "settings_update_item_warning": "Mettre à jour la valeur ci-dessous. Veillez à bien suivre le même format qu'auparavant. <b>Il n'y a pas de pas de contrôle.</b>",
     "test_event_tooltip": "Enregistrer d'abord vos modifications avant de tester vôtre paramétrage."
-}
+}

front/php/templates/language/ru_ru.json

@@ -203,7 +203,7 @@
     "Device_MultiEdit_MassActions": "Массовые действия:",
     "Device_MultiEdit_No_Devices": "Устройства не выбраны.",
     "Device_MultiEdit_Tooltip": "Осторожно. При нажатии на эту кнопку значение слева будет применено ко всем устройствам, выбранным выше.",
-    "Device_NextScan_Imminent": "Предстоящий...",
+    "Device_NextScan_Imminent": "Скоро...",
     "Device_NextScan_In": "Следующее сканирование примерно через· ",
     "Device_NoData_Help": "Если устройства не отображаются после сканирования, проверьте настройку SCAN_SUBNETS и <a href=\"https://docs.netalertx.com/SUBNETS\" target=\"_blank\">документацию</a>.",
     "Device_NoData_Scanning": "Ожидание первого сканирования — это может занять несколько минут после первоначальной настройки.",
@@ -231,7 +231,7 @@
     "Device_TableHead_FQDN": "FQDN",
     "Device_TableHead_Favorite": "Избранное",
     "Device_TableHead_FirstSession": "Первый сеанс",
-    "Device_TableHead_Flapping": "",
+    "Device_TableHead_Flapping": "Нестабильный",
     "Device_TableHead_GUID": "GUID",
     "Device_TableHead_Group": "Группа",
     "Device_TableHead_IPv4": "IPv4",
@@ -322,7 +322,7 @@
     "Gen_AddDevice": "Добавить устройство",
     "Gen_Add_All": "Добавить все",
     "Gen_All_Devices": "Все устройства",
-    "Gen_Archived": "",
+    "Gen_Archived": "Архивировано",
     "Gen_AreYouSure": "Вы уверены?",
     "Gen_Backup": "Запустить резервное копирование",
     "Gen_Cancel": "Отмена",
@@ -333,16 +333,16 @@
     "Gen_Delete": "Удалить",
     "Gen_DeleteAll": "Удалить все",
     "Gen_Description": "Описание",
-    "Gen_Down": "",
+    "Gen_Down": "Лежит",
     "Gen_Error": "Ошибка",
     "Gen_Filter": "Фильтр",
-    "Gen_Flapping": "",
+    "Gen_Flapping": "Нестабильный",
     "Gen_Generate": "Генерировать",
     "Gen_InvalidMac": "Неверный Mac-адрес.",
     "Gen_Invalid_Value": "Введено некорректное значение",
     "Gen_LockedDB": "ОШИБКА - Возможно, база данных заблокирована. Проверьте инструменты разработчика F12 -> Консоль или повторите попытку позже.",
     "Gen_NetworkMask": "Маска сети",
-    "Gen_New": "",
+    "Gen_New": "Новый",
     "Gen_Offline": "Оффлайн",
     "Gen_Okay": "OK",
     "Gen_Online": "Онлайн",
@@ -360,7 +360,7 @@
     "Gen_SelectIcon": "<i class=\"fa-solid fa-chevron-down fa-fade\"></i>",
     "Gen_SelectToPreview": "Выберите для предварительного просмотра",
     "Gen_Selected_Devices": "Выбранные устройства:",
-    "Gen_Sleeping": "",
+    "Gen_Sleeping": "Спящий",
     "Gen_Subnet": "Подсеть",
     "Gen_Switch": "Переключить",
     "Gen_Upd": "Успешное обновление",
@@ -590,8 +590,8 @@
     "PIALERT_WEB_PROTECTION_name": "Включить вход",
     "PLUGINS_KEEP_HIST_description": "Сколько записей результатов сканирования истории плагинов следует хранить (для каждого плагина, а не для конкретного устройства).",
     "PLUGINS_KEEP_HIST_name": "История плагинов",
-    "PRAGMA_JOURNAL_SIZE_LIMIT_description": "",
-    "PRAGMA_JOURNAL_SIZE_LIMIT_name": "",
+    "PRAGMA_JOURNAL_SIZE_LIMIT_description": "Максимальный размер SQLite WAL (журнал упреждающей записи) в МБ перед запуском автоматических контрольных точек. Более низкие значения (10–20 МБ) уменьшают использование диска/хранилища, но увеличивают загрузку ЦП во время сканирования. Более высокие значения (50–100 МБ) уменьшают нагрузку на процессор во время операций, но могут использовать больше оперативной памяти и дискового пространства. Значение по умолчанию <code>50 МБ</code> компенсирует и то, и другое. Полезно для систем с ограниченными ресурсами, таких как устройства NAS с SD-картами. Перезапустите сервер, чтобы изменения вступили в силу после сохранения настроек.",
+    "PRAGMA_JOURNAL_SIZE_LIMIT_name": "Ограничение размера WAL (МБ)",
     "Plugins_DeleteAll": "Удалить все (фильтры игнорируются)",
     "Plugins_Filters_Mac": "Фильтр MAC-адреса",
     "Plugins_History": "История событий",

front/plugins/sync/sync.py

@@ -222,27 +222,30 @@ def main():
                         extra       = '',
                         foreignKey  = device['devGUID'])
 
+            # Resolve the actual columns that exist in the Devices table once.
+            # This automatically excludes computed/virtual fields (e.g. devStatus,
+            # devIsSleeping) and 'rowid' without needing a maintained exclusion list.
+            cursor.execute("PRAGMA table_info(Devices)")
+            db_columns = {row[1] for row in cursor.fetchall()}
+
             # Filter out existing devices
             new_devices = [device for device in device_data if device['devMac'] not in existing_mac_addresses]
 
-            #  Remove 'rowid' key if it exists
-            for device in new_devices:
-                device.pop('rowid', None)
-                device.pop('devStatus', None)
-
             mylog('verbose', [f'[{pluginName}] All devices: "{len(device_data)}"'])
             mylog('verbose', [f'[{pluginName}] New devices: "{len(new_devices)}"'])
 
             # Prepare the insert statement
             if new_devices:
 
-                # creating insert statement, removing 'rowid', 'devStatus' as handled on the target and devStatus is resolved on the fly
-                columns = ', '.join(k for k in new_devices[0].keys() if k not in ['rowid', 'devStatus'])
-                placeholders = ', '.join('?' for k in new_devices[0] if k not in ['rowid', 'devStatus'])
+                # Only keep keys that are real columns in the target DB; computed
+                # or unknown fields are silently dropped regardless of source schema.
+                insert_cols = [k for k in new_devices[0].keys() if k in db_columns]
+                columns = ', '.join(insert_cols)
+                placeholders = ', '.join('?' for _ in insert_cols)
                 sql = f'INSERT INTO Devices ({columns}) VALUES ({placeholders})'
 
-                # Extract values for the new devices
-                values = [tuple(device.values()) for device in new_devices]
+                # Extract only the whitelisted column values for each device
+                values = [tuple(device.get(col) for col in insert_cols) for device in new_devices]
 
                 mylog('verbose', [f'[{pluginName}] Inserting Devices SQL   : "{sql}"'])
                 mylog('verbose', [f'[{pluginName}] Inserting Devices VALUES: "{values}"'])

server/api_server/graphql_endpoint.py

@@ -563,7 +563,7 @@ def resolve_langStrings(self, info, langCode=None, langStringKey=None, fallback_
         langStrings = []
 
         # --- CORE JSON FILES ---
-        language_folder = '/app/front/php/templates/language/language_definitions/'
+        language_folder = '/app/front/php/templates/language/'
         if os.path.exists(language_folder):
             for filename in os.listdir(language_folder):
                 if filename.endswith('.json') and filename != 'languages.json':