Merge branch 'main' into feat/port-test-exception

Author: bavulapati

PORTING.md

@@ -51,7 +51,7 @@ Tests covering the engine-specific part of Node-API, defined in `js_native_api.h
 | `test_bigint`                | Ported ✅  | Easy       |
 | `test_cannot_run_js`         | Not ported | Medium     |
 | `test_constructor`           | Ported ✅  | Medium     |
-| `test_conversions`           | Not ported | Medium     |
+| `test_conversions`           | Ported ✅  | Medium     |
 | `test_dataview`              | Not ported | Medium     |
 | `test_date`                  | Ported ✅  | Easy       |
 | `test_error`                 | Ported ✅  | Medium     |
@@ -69,7 +69,7 @@ Tests covering the engine-specific part of Node-API, defined in `js_native_api.h
 | `test_reference`             | Not ported | Medium     |
 | `test_reference_double_free` | Ported ✅  | Easy       |
 | `test_sharedarraybuffer`     | Not ported | Medium     |
-| `test_string`                | Not ported | Medium     |
+| `test_string`                | Ported ✅  | Medium     |
 | `test_symbol`                | Ported ✅  | Easy       |
 | `test_typedarray`            | Ported ✅  | Medium     |
 

eslint.config.js

@@ -1,10 +1,16 @@
 import { defineConfig, globalIgnores } from "eslint/config";
 import globals from "globals";
+import eslint from '@eslint/js';
+import tseslint from 'typescript-eslint';
 
 export default defineConfig([
-  globalIgnores(["node"]),
+  globalIgnores(["**/CMakeFiles/**"]),
+  eslint.configs.recommended,
+  tseslint.configs.recommended,
   {
-    files: ["tests/**/*.js"],
+    files: [
+      "tests/**/*.js",
+    ],
     languageOptions: {
       // Only allow ECMAScript built-ins and CTS harness globals.
       // This causes no-undef to flag any runtime-specific API (setTimeout, process, Buffer, etc.).
@@ -18,6 +24,8 @@ export default defineConfig([
         gcUntil: "readonly",
         spawnTest: "readonly",
         experimentalFeatures: "readonly",
+        napiVersion: "readonly",
+        skipTest: "readonly",
       },
     },
     rules: {
@@ -31,4 +39,16 @@ export default defineConfig([
       ],
     },
   },
+  {
+    files: [
+      "implementors/**/*.{js,ts}",
+      "scripts/**/*.{js,mjs}",
+    ],
+    languageOptions: {
+      globals: {
+        ...globals.es2025,
+        ...globals.node,
+      },
+    },
+  },
 ]);

implementors/node/features.js

@@ -7,3 +7,9 @@ globalThis.experimentalFeatures = {
   setPrototype: true,
   postFinalizer: true,
 };
+
+globalThis.napiVersion = Number(process.versions.napi);
+
+globalThis.skipTest = () => {
+  process.exit(0);
+};

implementors/node/run-tests.ts

@@ -6,19 +6,6 @@ import { listDirectoryEntries, runFileInSubprocess } from "./tests.ts";
 const ROOT_PATH = path.resolve(import.meta.dirname, "..", "..");
 const TESTS_ROOT_PATH = path.join(ROOT_PATH, "tests");
 
-const ASSERT_MODULE_PATH = path.join(
-  ROOT_PATH,
-  "implementors",
-  "node",
-  "assert.js"
-);
-const LOAD_ADDON_MODULE_PATH = path.join(
-  ROOT_PATH,
-  "implementors",
-  "node",
-  "load-addon.js"
-);
-
 async function populateSuite(
   testContext: TestContext,
   dir: string