don't try to cast tracked constant when constant is of composite type - simple IO conversions doesn't work due possibly different number of attributes, dropped attributes and etc - real constant conversions is possible, but requires lot of code

Author: okbob

expected/plpgsql_check_active_4.out

@@ -9693,3 +9693,23 @@ select * from plpgsql_check_function('volatility_check()');
 (3 rows)
 
 drop function volatility_check();
+-- issue #201 - should not to raise false error, when composite
+-- constant is used and assigned to composite with more fields
+create type t_retcode as (retcode varchar, errmsg varchar, id int);
+create or replace function test_retcode_bad()
+returns void as $$
+declare
+  rc t_retcode := row('MO_REG_ERROR');
+begin
+  raise notice '%', rc.retcode;
+end;
+$$ language plpgsql;
+select * from plpgsql_check_function('test_retcode_bad');
+                            plpgsql_check_function                            
+------------------------------------------------------------------------------
+ warning:00000:4:statement block:too few attributes for composite variable
+ Context: during statement block local variable "rc" initialization on line 3
+(2 rows)
+
+drop function test_retcode_bad;
+drop type t_retcode;

sql/plpgsql_check_active.sql

@@ -5793,3 +5793,22 @@ $$ language plpgsql stable;
 select * from plpgsql_check_function('volatility_check()');
 
 drop function volatility_check();
+
+-- issue #201 - should not to raise false error, when composite
+-- constant is used and assigned to composite with more fields
+create type t_retcode as (retcode varchar, errmsg varchar, id int);
+
+create or replace function test_retcode_bad()
+returns void as $$
+declare
+  rc t_retcode := row('MO_REG_ERROR');
+begin
+  raise notice '%', rc.retcode;
+end;
+$$ language plpgsql;
+
+select * from plpgsql_check_function('test_retcode_bad');
+
+drop function test_retcode_bad;
+drop type t_retcode;
+

src/check_expr.c

@@ -1308,7 +1308,6 @@ free_string_constant(PLpgSQL_checkstate *cstate, PLpgSQL_row *row)
 	}
 }
 
-
 /*
  * Check expression as rvalue - on right in assign statement. It is used for
  * only expression check too - when target is unknown.
@@ -1406,17 +1405,21 @@ plpgsql_check_expr_as_rvalue(PLpgSQL_checkstate *cstate, PLpgSQL_expr *expr,
 
 				/* When expr is constant string, try it cast to target type */
 				str = plpgsql_check_get_const_string(cstate, node, NULL);
-
 				if (str)
 				{
-					Oid		infunc;
-					Oid		intypeioparam;
-					Oid		typeid;
+					Oid			expr_typoid = exprType((Node *) node);
 
-					typeid = use_element_type ? get_array_type(expected_typoid) : expected_typoid;
+					if (!type_is_rowtype(expr_typoid) && !type_is_rowtype(expected_typoid))
+					{
+						Oid		infunc;
+						Oid		intypeioparam;
+						Oid		typeid;
 
-					getTypeInputInfo(typeid, &infunc, &intypeioparam);
-					(void) OidInputFunctionCall(infunc, str, intypeioparam, -1);
+						typeid = use_element_type ? get_array_type(expected_typoid) : expected_typoid;
+
+						getTypeInputInfo(typeid, &infunc, &intypeioparam);
+						(void) OidInputFunctionCall(infunc, str, intypeioparam, -1);
+					}
 				}
 			}