Resolved/suppressed compiler warnings in JUCE OS X code

Author: cstawarz

JuceLibraryCode/modules/juce_graphics/native/juce_mac_CoreGraphicsContext.mm

@@ -507,7 +507,7 @@ static CGBitmapInfo getCGImageFlags (const Image::PixelFormat& format)
        #if MAC_OS_X_VERSION_MAX_ALLOWED >= MAC_OS_X_VERSION_10_5
         // There's a bug in CGContextDrawTiledImage that makes it incredibly slow
         // if it's doing a transformation - it's quicker to just draw lots of images manually
-        if (CGContextDrawTiledImage != 0 && transform.isOnlyTranslation())
+        if (&CGContextDrawTiledImage != 0 && transform.isOnlyTranslation())
             CGContextDrawTiledImage (context, imageRect, image);
         else
        #endif

JuceLibraryCode/modules/juce_gui_basics/native/juce_mac_FileChooser.mm

@@ -172,7 +172,10 @@ static BOOL shouldShowFilename (id self, SEL, id /*sender*/, NSString* filename)
         [panel setDirectoryURL: [NSURL fileURLWithPath: juceStringToNS (directory)]];
         [panel setNameFieldStringValue: juceStringToNS (filename)];
 
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
         if ([panel runModal] == NSOKButton)
+#pragma GCC diagnostic pop
        #else
         if ([panel runModalForDirectory: juceStringToNS (directory)
                                    file: juceStringToNS (filename)] == NSOKButton)

JuceLibraryCode/modules/juce_gui_basics/native/juce_mac_NSViewComponentPeer.mm

@@ -555,7 +555,10 @@ void redirectMouseMove (NSEvent* ev)
 
        #if defined (MAC_OS_X_VERSION_10_6) && MAC_OS_X_VERSION_MAX_ALLOWED >= MAC_OS_X_VERSION_10_6
         if ([NSWindow respondsToSelector: @selector (windowNumberAtPoint:belowWindowWithWindowNumber:)]
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
              && [NSWindow windowNumberAtPoint: [[ev window] convertBaseToScreen: [ev locationInWindow]]
+#pragma GCC diagnostic pop
                   belowWindowWithWindowNumber: 0] != [window windowNumber])
         {
             // moved into another window which overlaps this one, so trigger an exit

JuceLibraryCode/modules/juce_gui_basics/native/juce_mac_Windowing.mm

@@ -45,8 +45,11 @@ int getResult() const
     {
         switch (getRawResult())
         {
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
             case NSAlertDefaultReturn:  return 1;
             case NSAlertOtherReturn:    return 2;
+#pragma GCC diagnostic pop
             default:                    return 0;
         }
     }
@@ -97,9 +100,12 @@ NSInteger getRawResult() const
 
         switch (iconType)
         {
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
             case AlertWindow::InfoIcon:     return NSRunInformationalAlertPanel (ttl, msg, b1, b2, b3);
             case AlertWindow::WarningIcon:  return NSRunCriticalAlertPanel      (ttl, msg, b1, b2, b3);
             default:                        return NSRunAlertPanel              (ttl, msg, b1, b2, b3);
+#pragma GCC diagnostic pop
         }
     }
 };
@@ -185,13 +191,16 @@ NSInteger getRawResult() const
         dragPosition.x -= 16;
         dragPosition.y -= 16;
 
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
         [view dragImage: [[NSWorkspace sharedWorkspace] iconForFile: juceStringToNS (files[0])]
                      at: dragPosition
                  offset: NSMakeSize (0, 0)
                   event: [[view window] currentEvent]
              pasteboard: pboard
                  source: view
               slideBack: YES];
+#pragma GCC diagnostic pop
     }
 
     return true;

JuceLibraryCode/modules/juce_opengl/native/juce_OpenGL_osx.h

@@ -40,7 +40,10 @@ class OpenGLContext::NativeContext
             NSOpenGLPFAOpenGLProfile, version >= openGL3_2 ? NSOpenGLProfileVersion3_2Core : NSOpenGLProfileVersionLegacy,
            #endif
             NSOpenGLPFADoubleBuffer,
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
             NSOpenGLPFAMPSafe,
+#pragma GCC diagnostic pop
             NSOpenGLPFAClosestPolicy,
             NSOpenGLPFANoRecovery,
             NSOpenGLPFAColorSize,   (NSOpenGLPixelFormatAttribute) (pixFormat.redBits + pixFormat.greenBits + pixFormat.blueBits),