Refactor plugin update/uninstall process

When updating a plugin, the plugin is now uninstalled and then new version is installed. This is to ensure that the plugin metadata is properly updated.
When uninstalling a plugin, the plugin library is now unloaded by the plugin manager.

Author: anjaldoshi

Source/Processors/PluginManager/PluginManager.cpp

@@ -106,7 +106,7 @@ PluginManager::PluginManager()
 
 	if(appDir.contains("plugin-GUI\\Build\\"))
 	{
-		SetDllDirectory(sharedPath.getFullPathName().toUTF8());
+		SetDllDirectory(sharedPath.getFullPathName().toRawUTF8());
 	}
 	else
     {
@@ -115,7 +115,7 @@ PluginManager::PluginManager()
 			LOGD("Copying shared dependencies to ", installSharedPath.getFullPathName());
             sharedPath.copyDirectoryTo(installSharedPath);
         }
-        SetDllDirectory(installSharedPath.getFullPathName().toUTF8());
+        SetDllDirectory(installSharedPath.getFullPathName().toRawUTF8());
     }
 
 #elif __linux__
@@ -238,7 +238,8 @@ int PluginManager::loadPlugin(const String& pluginLoc) {
 
 #ifdef _WIN32
 	HINSTANCE handle;
-	handle = LoadLibrary(processorLocCString);
+	const wchar_t* processorLocLPCWSTR = pluginLoc.toWideCharPointer();
+	handle = LoadLibraryW(processorLocLPCWSTR);
 #elif defined(__APPLE__)
     CF::CFURLRef bundleURL = CF::CFURLCreateFromFileSystemRepresentation(CF::kCFAllocatorDefault,
                                                                  reinterpret_cast<const CF::UInt8 *>(processorLocCString),
@@ -311,7 +312,7 @@ int PluginManager::loadPlugin(const String& pluginLoc) {
 		return -1;
 	}
 
-	LoadedLibInfo lib;
+	LoadedLibInfo lib{};
 	lib.apiVersion = libInfo.apiVersion;
 	lib.name = libInfo.name;
 	lib.libVersion = libInfo.libVersion;
@@ -335,9 +336,8 @@ int PluginManager::loadPlugin(const String& pluginLoc) {
 			info.name = pInfo.processor.name;
 			info.type = pInfo.processor.type;
 			info.libIndex = libArray.size()-1;
-			Plugin::ProcessorInfo pi = getProcessorInfo(String::fromUTF8(info.name));
-			if(pi.name == nullptr)
-				processorPlugins.add(info);
+			processorPlugins.add(info);
+
 			break;
 		}
 		case Plugin::RECORD_ENGINE:
@@ -347,9 +347,8 @@ int PluginManager::loadPlugin(const String& pluginLoc) {
 			info.creator = pInfo.recordEngine.creator;
 			info.name = pInfo.recordEngine.name;
 			info.libIndex = libArray.size() - 1;
-			Plugin::RecordEngineInfo rei = getRecordEngineInfo(String::fromUTF8(info.name));
-			if(rei.name == nullptr)
-				recordEnginePlugins.add(info);
+			recordEnginePlugins.add(info);
+			
 			break;
 		}
 		case Plugin::DATA_THREAD:
@@ -359,9 +358,8 @@ int PluginManager::loadPlugin(const String& pluginLoc) {
 			info.creator = pInfo.dataThread.creator;
 			info.name = pInfo.dataThread.name;
 			info.libIndex = libArray.size() - 1;
-			Plugin::DataThreadInfo dti = getDataThreadInfo(String::fromUTF8(info.name));
-			if(dti.name == nullptr)
-				dataThreadPlugins.add(info);
+			dataThreadPlugins.add(info);
+			
 			break;
 		}
 		case Plugin::FILE_SOURCE:
@@ -372,9 +370,8 @@ int PluginManager::loadPlugin(const String& pluginLoc) {
 			info.name = pInfo.fileSource.name;
 			info.extensions = pInfo.fileSource.extensions;
 			info.libIndex = libArray.size();
-			Plugin::FileSourceInfo fsi = getFileSourceInfo(String::fromUTF8(info.name));
-			if(fsi.name == nullptr)
-				fileSourcePlugins.add(info);
+			fileSourcePlugins.add(info);
+			
 			break;
 		}
 		default:
@@ -539,8 +536,10 @@ bool PluginManager::findPlugin(String name, String libName, const Array<LoadedPl
 	for (int i = 0; i < pluginArray.size(); i++)
 	{
 		String pName = String(pluginArray[i].name);
-		if (pName == name)
+		LOGC("********** PluginArray[", i, "]: ", pName);
+		if (pName.equalsIgnoreCase(name))
 		{
+			LOGC ("Found plugin: ", name, " in pluginArray");
 			if ((libName.isEmpty()) || (libName == String(libArray[pluginArray[i].libIndex].name)))
 			{
 				pluginInfo = pluginArray[i];
@@ -591,6 +590,8 @@ bool PluginManager::removePlugin(String libName)
 	{
 		if (piFunction(i, &pInfo)) //if somehow there are fewer plugins than stated, stop removing
 			break;
+
+		int pluginIndex = -1;
 		switch (pInfo.type)
 		{
 			case Plugin::PROCESSOR:
@@ -599,11 +600,14 @@ bool PluginManager::removePlugin(String libName)
 				for(int j = 0; j < processorPlugins.size(); j++)
 				{
 					if(processorPlugins[j].name == pInfo.processor.name)
-					{
-						processorPlugins.remove(j);
-						break;
-					}
+						pluginIndex = j;
+					
+					if (processorPlugins[j].libIndex > indexToRemove)
+						processorPlugins[j].setLibIndex(processorPlugins[j].libIndex - 1);
 				}
+				if(pluginIndex != -1)
+					processorPlugins.remove(pluginIndex);
+
 				break;
 			}
 			case Plugin::RECORD_ENGINE:
@@ -612,37 +616,46 @@ bool PluginManager::removePlugin(String libName)
 				for(int j = 0; j < recordEnginePlugins.size(); j++)
 				{
 					if(recordEnginePlugins[j].name == pInfo.recordEngine.name)
-					{
-						recordEnginePlugins.remove(j);
-						break;
-					}
+						pluginIndex = j;
+					
+					if (recordEnginePlugins[j].libIndex > indexToRemove)
+						recordEnginePlugins[j].setLibIndex(recordEnginePlugins[j].libIndex - 1);
 				}
+				if(pluginIndex != -1)
+					recordEnginePlugins.remove(pluginIndex);
+
 				break;
 			}
 			case Plugin::DATA_THREAD:
 			{
-				LOGD("Adding data thread plugin");
+				LOGD("Removing data thread plugin");
 				for(int j = 0; j < dataThreadPlugins.size(); j++)
 				{
 					if(dataThreadPlugins[j].name == pInfo.dataThread.name)
-					{
-						dataThreadPlugins.remove(j);
-						break;
-					}
+						pluginIndex = j;
+					
+					if (dataThreadPlugins[j].libIndex > indexToRemove)
+						dataThreadPlugins[j].setLibIndex(dataThreadPlugins[j].libIndex - 1);
 				}
+				if(pluginIndex != -1)
+					dataThreadPlugins.remove(pluginIndex);
+
 				break;
 			}
 			case Plugin::FILE_SOURCE:
 			{
-				LOGD("Adding file source plugin");
+				LOGD("Removing file source plugin");
 				for(int j = 0; j < fileSourcePlugins.size(); j++)
 				{
 					if(fileSourcePlugins[j].name == pInfo.fileSource.name)
-					{
-						fileSourcePlugins.remove(j);
-						break;
-					}
+						pluginIndex = j;
+					
+					if (fileSourcePlugins[j].libIndex > indexToRemove)
+						fileSourcePlugins[j].setLibIndex(fileSourcePlugins[j].libIndex - 1);
 				}
+				if(pluginIndex != -1)
+					fileSourcePlugins.remove(pluginIndex);
+
 				break;
 			}
 			default:
@@ -653,6 +666,7 @@ bool PluginManager::removePlugin(String libName)
 		}
 	}
 
+	closeHandle(lib.handle);
 	libArray.remove(indexToRemove);
 	return true;
 }

Source/Processors/PluginManager/PluginManager.h

@@ -26,6 +26,7 @@
 
 #include <list>
 #include <string>
+#include <cstring>
 #include <sys/types.h>
 #include "../../../JuceLibraryCode/JuceHeader.h"
 #include "OpenEphysPlugin.h"
@@ -54,6 +55,12 @@ template<class T>
 struct LoadedPluginInfo : public T
 {
 	int libIndex;
+
+	// Setter function to modify the libIndex
+	void setLibIndex(int index)
+	{
+		libIndex = index;
+	}
 };