Fix return value for getValueAsString in SelectedStreamParameter

anjaldoshi · anjaldoshi · commit 61902a122fd3 · 2025-06-10T16:34:27.000-07:00
diff --git a/Source/Processors/Parameter/Parameter.cpp b/Source/Processors/Parameter/Parameter.cpp
@@ -1391,7 +1391,7 @@ int SelectedStreamParameter::getSelectedIndex()
 String SelectedStreamParameter::getValueAsString()
 {
     if ((int) currentValue == -1 || streamNames.size() == 0)
-        return "None";
+        return String();
     else
         return streamNames[(int) currentValue];
 }
@@ -1409,7 +1409,10 @@ void SelectedStreamParameter::fromXml (XmlElement* xml)
 
 String SelectedStreamParameter::getChangeDescription()
 {
-    return getValueAsString();
+    if ((int) currentValue == -1)
+        return "None";
+    else
+        return getValueAsString();
 }
 
 TimeParameter::TimeParameter (ParameterOwner* owner,

Original file line number	Diff line number	Diff line change
`@@ -1391,7 +1391,7 @@ int SelectedStreamParameter::getSelectedIndex()`
`1391`	`1391`	`String SelectedStreamParameter::getValueAsString()`
`1392`	`1392`	`{`
`1393`	`1393`	`if ((int) currentValue == -1 \|\| streamNames.size() == 0)`
`1394`		`- return "None";`
	`1394`	`+ return String();`
`1395`	`1395`	`else`
`1396`	`1396`	`return streamNames[(int) currentValue];`
`1397`	`1397`	`}`
`@@ -1409,7 +1409,10 @@ void SelectedStreamParameter::fromXml (XmlElement* xml)`
`1409`	`1409`
`1410`	`1410`	`String SelectedStreamParameter::getChangeDescription()`
`1411`	`1411`	`{`
`1412`		`- return getValueAsString();`
	`1412`	`+ if ((int) currentValue == -1)`
	`1413`	`+ return "None";`
	`1414`	`+ else`
	`1415`	`+ return getValueAsString();`
`1413`	`1416`	`}`
`1414`	`1417`
`1415`	`1418`	`TimeParameter::TimeParameter (ParameterOwner* owner,`