Make spike channel cache keys dynamic to allow for source changes

Author: medengineer

Plugins/BasicSpikeDisplay/SpikeDisplayNode/SpikeDisplayCanvas.cpp

@@ -228,9 +228,15 @@ void SpikeDisplayCanvas::saveCustomParametersToXml(XmlElement* xml)
 
         spikePlotIdx++;
 
+        const SpikeChannel* spikeChannel = processor->getSpikeChannel(i);
+
+        const uint16 streamId = spikeChannel->getStreamId();
+
         XmlElement* plotNode = xmlNode->createNewChildElement("PLOT");
 
-        plotNode->setAttribute("name", processor->getSpikeChannel(i)->getIdentifier());
+        plotNode->setAttribute("name", spikeChannel->getName());
+        plotNode->setAttribute("stream_name", processor->getDataStream(streamId)->getName());
+        plotNode->setAttribute("stream_source", processor->getDataStream(streamId)->getSourceNodeId());
         plotNode->setAttribute("isMonitored", spikeDisplay->getMonitorStateForPlot(i));
 
         for (int j = 0; j < spikeDisplay->getNumChannelsForPlot(i); j++)
@@ -273,7 +279,11 @@ void SpikeDisplayCanvas::loadCustomParametersFromXml(XmlElement* xml)
                 {
                     plotIndex++;
 
-                    std::string cacheKey = processor->getSpikeChannel(plotIndex)->getIdentifier().toStdString();
+                    std::string source = plotNode->getStringAttribute("stream_source").toStdString();
+                    std::string stream_name = plotNode->getStringAttribute("stream_name").toStdString();
+                    std::string name = plotNode->getStringAttribute("name").toStdString();
+
+                    std::string cacheKey = source + "|" + stream_name + "|" + name;
 
                     cache->setMonitor(cacheKey, plotNode->getBoolAttribute("isMonitored"));
 

Plugins/BasicSpikeDisplay/SpikeDisplayNode/SpikePlots.cpp

@@ -293,6 +293,7 @@ void SpikePlot::buttonClicked(Button* button)
     setLimitsOnAxes();
 
     canvas->cache->setMonitor(identifier, monitorButton->getToggleState());
+    canvas->cache->setRange(identifier, index, ranges[index]);
 
 }
 
@@ -374,6 +375,7 @@ float SpikePlot::getRangeForChannel(int i)
 void SpikePlot::setRangeForChannel(int i, float range)
 {
     //std::cout << "Setting range to " << range << std::endl;
+    ranges.set(i, range);
     waveAxes[i]->setRange(range);
     rangeButtons[i]->setLabel(String(int(range)));
 }

leetcode

@@ -0,0 +1,6 @@
+# 1. TwoSum
+
+Use a map to store the number we've already visited as a key and its index as the value.
+If the target minus the current number is an existing key, return the current index and the existing key's value
+
+This runs in O(n) since we only need to pass through the list once.