BinaryWriter: fix check to update .npy header regularly

mspacek · mspacek · commit 6dbac1035dbd · 2018-06-28T19:01:06.000+02:00
Update .npy header regularly even when record count increment &gt; 1
diff --git a/Source/Plugins/BinaryWriter/NpyFile.cpp b/Source/Plugins/BinaryWriter/NpyFile.cpp
@@ -190,9 +190,10 @@ void NpyFile::writeData(const void* data, size_t size)
 
 void NpyFile::increaseRecordCount(int count)
 {
+    int64 old_recordCount = m_recordCount;
     m_recordCount += count;
-    if (m_recordCount % recordBufferSize == 0)
-        updateHeader(); // also triggers a flush to disk
+    if ((old_recordCount / recordBufferSize) != (m_recordCount / recordBufferSize))
+        updateHeader(); // crossed recordBufferSize threshold, update header
 }
 
 NpyType::NpyType(String n, BaseType t, size_t l)

Original file line number	Diff line number	Diff line change
`@@ -190,9 +190,10 @@ void NpyFile::writeData(const void* data, size_t size)`
`190`	`190`
`191`	`191`	`void NpyFile::increaseRecordCount(int count)`
`192`	`192`	`{`
	`193`	`+ int64 old_recordCount = m_recordCount;`
`193`	`194`	`m_recordCount += count;`
`194`		`- if (m_recordCount % recordBufferSize == 0)`
`195`		`- updateHeader(); // also triggers a flush to disk`
	`195`	`+ if ((old_recordCount / recordBufferSize) != (m_recordCount / recordBufferSize))`
	`196`	`+ updateHeader(); // crossed recordBufferSize threshold, update header`
`196`	`197`	`}`
`197`	`198`
`198`	`199`	`NpyType::NpyType(String n, BaseType t, size_t l)`