BinaryWriter: explicitly flush .npy file on header update

mspacek · mspacek · commit 7fb846fa065e · 2018-06-28T19:01:06.000+02:00
diff --git a/Source/Plugins/BinaryWriter/NpyFile.cpp b/Source/Plugins/BinaryWriter/NpyFile.cpp
@@ -168,7 +168,7 @@ void NpyFile::updateHeader()
             std::cerr << "Error. Header has grown too big to update in-place " << std::endl;
         }
         m_file->write(newShape.toUTF8(), newShape.getNumBytesAsUTF8());
-        //m_file->flush(); // doesn't seem to be necessary, already flushed due to overwrite
+        m_file->flush(); // not necessary, already flushed due to overwrite? do it anyway
         m_file->setPosition(currentPos); // restore position to end of file
     }
     else

Original file line number	Diff line number	Diff line change
`@@ -168,7 +168,7 @@ void NpyFile::updateHeader()`
`168`	`168`	`std::cerr << "Error. Header has grown too big to update in-place " << std::endl;`
`169`	`169`	`}`
`170`	`170`	`m_file->write(newShape.toUTF8(), newShape.getNumBytesAsUTF8());`
`171`		`- //m_file->flush(); // doesn't seem to be necessary, already flushed due to overwrite`
	`171`	`+ m_file->flush(); // not necessary, already flushed due to overwrite? do it anyway`
`172`	`172`	`m_file->setPosition(currentPos); // restore position to end of file`
`173`	`173`	`}`
`174`	`174`	`else`